save-cwd: reduce default dependency

save-cwd generally needs only a working fchdir or a working
getcwd(NULL,0).  If you are not worried about directories whose
absolute name is longer than PATH_MAX, then reducing the default
dependencies reduces the bulk for this module.

However, there are cases where neither function works on Linux
(an unreadable but searchable directory can be opened by O_SEARCH,
except that Linux doesn't implement that yet; and Linux getcwd()
has issues with long absolute names which glibc does not work
around but which the full-blown getcwd module does).  So someone
desiring a truly robust solution needs to import the 'getcwd'
module at the same time as 'save-cwd'.

* modules/save-cwd (Depends-on): Use getcwd-lgpl.
* lib/save-cwd.c: Update comments.
* NEWS: Document the semantic change.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 8cef5ecf43ec007a965739adce2bd970e8a3d449..2b6b0639cfdb2af32149f43c2496827032edde9d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,9 @@
-2011-04-26  Eric Blake  <eblake@redhat.com>
+2011-04-27  Eric Blake  <eblake@redhat.com>
+
+       save-cwd: reduce default dependency
+       * modules/save-cwd (Depends-on): Use getcwd-lgpl.
+       * lib/save-cwd.c: Update comments.
+       * NEWS: Document the semantic change.
 
        getcwd: enhance tests
        * tests/test-getcwd-lgpl.c: New file, taken from...
@@ -9,8 +14,6 @@
        * m4/getcwd-abort-bug.m4: Update comment.
        * m4/getcwd-path-max.m4: Likewise.
 
-2011-04-27  Eric Blake  <eblake@redhat.com>
-
        getcwd-lgpl: new module
        * modules/getcwd-lgpl: New module.
        * lib/getcwd-lgpl.c: New file.

diff --git a/NEWS b/NEWS
index 7dd126dac68132d52b2095298c048a28a78b1a57..5081dbaa8208da3c8eb4133d2c490a154e7904ee 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,11 @@ User visible incompatible changes
 
 Date        Modules         Changes
 
+2011-04-27  save-cwd        This module pulls in fewer dependencies by
+                            default; to retain robust handling of directories
+                            with an absolute name longer than PATH_MAX, you
+                            must now explicitly include the 'getcwd' module.
+
 2011-04-19  close-hook      This module has been renamed to 'fd-hook' and
                             generalized.
 

diff --git a/lib/save-cwd.c b/lib/save-cwd.c
index 16ffa2c490477b8d42fd20afa5c9957a1d52123f..5f8eb7ca53e12b09a50a3f4885d4a6816c2a6f2d 100644 (file)
--- a/lib/save-cwd.c
+++ b/lib/save-cwd.c
@@ -50,7 +50,8 @@
    The `raison d'etre' for this interface is that the working directory
    is sometimes inaccessible, and getcwd is not robust or as efficient.
    So, we prefer to use the open/fchdir approach, but fall back on
-   getcwd if necessary.
+   getcwd if necessary.  This module works for most cases with just
+   the getcwd-lgpl module, but to be truly robust, use the getcwd module.
 
    Some systems lack fchdir altogether: e.g., OS/2, pre-2001 Cygwin,
    SCO Xenix.  Also, SunOS 4 and Irix 5.3 provide the function, yet it

diff --git a/modules/save-cwd b/modules/save-cwd
index 02a072339189e2b0b8769135a4205184b566b344..974b5962c1bbf0b7f3b18875f9890149c4a7ebda 100644 (file)
--- a/modules/save-cwd
+++ b/modules/save-cwd
@@ -9,7 +9,7 @@ m4/save-cwd.m4
 Depends-on:
 chdir-long
 cloexec
-getcwd
+getcwd-lgpl
 fchdir
 stdbool
 unistd-safer