getdate.y: factor out common actions

* lib/getdate.y (apply_relative_time, set_hhmmss): New functions.
Use them in place of open-coded actions.

diff --git a/ChangeLog b/ChangeLog
index b9076e273ed7776828bb31825942579c607bba72..b5d4f057196847c09aa075aff64da1ad3ef53656 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-07-02  Ondřej Vašík  <ovasik@redhat.com>
+
+       getdate.y: factor out common actions
+       * lib/getdate.y (apply_relative_time, set_hhmmss): New functions.
+       Use them in place of open-coded actions.
+
 2008-07-01  Simon Josefsson  <simon@josefsson.org>
 
        Add self-test for getdate module.

diff --git a/lib/getdate.y b/lib/getdate.y
index 1deec5160de23f166e0e569778e8824cc4e56d4a..9171147f44134d2017ea6d5f77cae6e1fe74e4b8 100644 (file)
--- a/lib/getdate.y
+++ b/lib/getdate.y
@@ -246,6 +246,31 @@ digits_to_date_time (parser_control *pc, textint text_int)
     }
 }
 
+/* Increment PC->rel by FACTOR * REL (FACTOR is 1 or -1).  */
+static void
+apply_relative_time (parser_control *pc, relative_time rel, int factor)
+{
+  pc->rel.ns += factor * rel.ns;
+  pc->rel.seconds += factor * rel.seconds;
+  pc->rel.minutes += factor * rel.minutes;
+  pc->rel.hour += factor * rel.hour;
+  pc->rel.day += factor * rel.day;
+  pc->rel.month += factor * rel.month;
+  pc->rel.year += factor * rel.year;
+  pc->rels_seen = true;
+}
+
+/* Set PC-> hour, minutes, seconds and nanoseconds members from arguments.  */
+static void
+set_hhmmss (parser_control *pc, long int hour, long int minutes,
+           time_t sec, long int nsec)
+{
+  pc->hour = hour;
+  pc->minutes = minutes;
+  pc->seconds.tv_sec = sec;
+  pc->seconds.tv_nsec = nsec;
+}
+
 %}
 
 /* We want a reentrant parser, even if the TZ manipulation and the calls to
@@ -313,7 +338,6 @@ item:
   | day
       { pc->days_seen++; }
   | rel
-      { pc->rels_seen = true; }
   | number
   | hybrid
   ;
@@ -321,42 +345,29 @@ item:
 time:
     tUNUMBER tMERIDIAN
       {
-       pc->hour = $1.value;
-       pc->minutes = 0;
-       pc->seconds.tv_sec = 0;
-       pc->seconds.tv_nsec = 0;
+       set_hhmmss (pc, $1.value, 0, 0, 0);
        pc->meridian = $2;
       }
   | tUNUMBER ':' tUNUMBER o_merid
       {
-       pc->hour = $1.value;
-       pc->minutes = $3.value;
-       pc->seconds.tv_sec = 0;
-       pc->seconds.tv_nsec = 0;
+       set_hhmmss (pc, $1.value, $3.value, 0, 0);
        pc->meridian = $4;
       }
   | tUNUMBER ':' tUNUMBER tSNUMBER o_colon_minutes
       {
-       pc->hour = $1.value;
-       pc->minutes = $3.value;
-       pc->seconds.tv_sec = 0;
-       pc->seconds.tv_nsec = 0;
+       set_hhmmss (pc, $1.value, $3.value, 0, 0);
        pc->meridian = MER24;
        pc->zones_seen++;
        pc->time_zone = time_zone_hhmm ($4, $5);
       }
   | tUNUMBER ':' tUNUMBER ':' unsigned_seconds o_merid
       {
-       pc->hour = $1.value;
-       pc->minutes = $3.value;
-       pc->seconds = $5;
+       set_hhmmss (pc, $1.value, $3.value, $5.tv_sec, $5.tv_nsec);
        pc->meridian = $6;
       }
   | tUNUMBER ':' tUNUMBER ':' unsigned_seconds tSNUMBER o_colon_minutes
       {
-       pc->hour = $1.value;
-       pc->minutes = $3.value;
-       pc->seconds = $5;
+       set_hhmmss (pc, $1.value, $3.value, $5.tv_sec, $5.tv_nsec);
        pc->meridian = MER24;
        pc->zones_seen++;
        pc->time_zone = time_zone_hhmm ($6, $7);
@@ -381,14 +392,7 @@ zone:
       { pc->time_zone = $1; }
   | tZONE relunit_snumber
       { pc->time_zone = $1;
-       pc->rel.ns += $2.ns;
-       pc->rel.seconds += $2.seconds;
-       pc->rel.minutes += $2.minutes;
-       pc->rel.hour += $2.hour;
-       pc->rel.day += $2.day;
-       pc->rel.month += $2.month;
-       pc->rel.year += $2.year;
-        pc->rels_seen = true; }
+       apply_relative_time (pc, $2, 1); }
   | tZONE tSNUMBER o_colon_minutes
       { pc->time_zone = $1 + time_zone_hhmm ($2, $3); }
   | tDAYZONE
@@ -495,25 +499,9 @@ date:
 
 rel:
     relunit tAGO
-      {
-       pc->rel.ns -= $1.ns;
-       pc->rel.seconds -= $1.seconds;
-       pc->rel.minutes -= $1.minutes;
-       pc->rel.hour -= $1.hour;
-       pc->rel.day -= $1.day;
-       pc->rel.month -= $1.month;
-       pc->rel.year -= $1.year;
-      }
+      { apply_relative_time (pc, $1, -1); }
   | relunit
-      {
-       pc->rel.ns += $1.ns;
-       pc->rel.seconds += $1.seconds;
-       pc->rel.minutes += $1.minutes;
-       pc->rel.hour += $1.hour;
-       pc->rel.day += $1.day;
-       pc->rel.month += $1.month;
-       pc->rel.year += $1.year;
-      }
+      { apply_relative_time (pc, $1, 1); }
   ;
 
 relunit:
@@ -600,14 +588,7 @@ hybrid:
        /* Hybrid all-digit and relative offset, so that we accept e.g.,
           "YYYYMMDD +N days" as well as "YYYYMMDD N days".  */
        digits_to_date_time (pc, $1);
-       pc->rel.ns += $2.ns;
-       pc->rel.seconds += $2.seconds;
-       pc->rel.minutes += $2.minutes;
-       pc->rel.hour += $2.hour;
-       pc->rel.day += $2.day;
-       pc->rel.month += $2.month;
-       pc->rel.year += $2.year;
-       pc->rels_seen = true;
+       apply_relative_time (pc, $2, 1);
       }
   ;