vswitchd: Initialize configuration on active-backup bonds.

Some configuration settings which were not balance-[slb|tcp]
specific were only initialized for these bond types.

Bug #4806.

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index eadafb0abed69d7c10ea1796aae82581b626845e..1558d3bb90d3afc79cc7cbbb6a94b9a66af98d77 100644 (file)
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -4527,6 +4527,8 @@ port_update_bonding(struct port *port)
         free(port->bond_hash);
         port->bond_hash = NULL;
         port->bond_fake_iface = false;
         free(port->bond_hash);
         port->bond_hash = NULL;
         port->bond_fake_iface = false;

+        port->active_iface = -1;
+        port->no_ifaces_tag = 0;

     } else {
         size_t i;
 
     } else {
         size_t i;
 


@@ -4537,19 +4539,25 @@ port_update_bonding(struct port *port)
                 e->iface_idx = -1;
                 e->tx_bytes = 0;
             }
                 e->iface_idx = -1;
                 e->tx_bytes = 0;
             }

-            port->no_ifaces_tag = tag_create_random();
-            bond_choose_active_iface(port);

             port->bond_next_rebalance
                 = time_msec() + port->bond_rebalance_interval;
             port->bond_next_rebalance
                 = time_msec() + port->bond_rebalance_interval;

-
-            if (port->cfg->bond_fake_iface) {
-                port->bond_next_fake_iface_update = time_msec();
-            }

         } else if (port->bond_mode == BM_AB) {
             free(port->bond_hash);
             port->bond_hash = NULL;
         }
         } else if (port->bond_mode == BM_AB) {
             free(port->bond_hash);
             port->bond_hash = NULL;
         }

+
+        if (!port->no_ifaces_tag) {
+            port->no_ifaces_tag = tag_create_random();
+        }
+
+        if (port->active_iface < 0) {
+            bond_choose_active_iface(port);
+        }
+

         port->bond_fake_iface = port->cfg->bond_fake_iface;
         port->bond_fake_iface = port->cfg->bond_fake_iface;

+        if (port->bond_fake_iface) {
+            port->bond_next_fake_iface_update = time_msec();
+        }

 
         if (!port->miimon) {
             port->monitor = netdev_monitor_create();
 
         if (!port->miimon) {
             port->monitor = netdev_monitor_create();