ofp-errors: Remove OFPERR_NXBIC_DUP_TYPE
authorSimon Horman <horms@verge.net.au>
Tue, 4 Sep 2012 06:51:59 +0000 (15:51 +0900)
committerBen Pfaff <blp@nicira.com>
Tue, 4 Sep 2012 20:04:46 +0000 (13:04 -0700)
commite38c9de5db32342b86f177e9fbd4e1dab77a2a1f
tree4f1769a626dde45aebbaad6246cd36056a66373a
parent5cb7a798405c6ccc07bf9a932b709643c072b086
ofp-errors: Remove OFPERR_NXBIC_DUP_TYPE

OFPERR_NXBIC_DUP_TYPE is currently only used in
decode_openflow11_instructions() which is part of a non-NX extension
portion of the Open Flow 1.1+ implementation.

After recent discussion it has been decided to attempt to only use
standardised, albeit less-specific, errors unless errors arise from use of
an NX extension.

With the above in mind it seems appropriate to:
* Use OFPERR_OFPIT_BAD_INSTRUCTION in place of OFPERR_NXBIC_DUP_TYPE.
* Remove OFPERR_NXBIC_DUP_TYPE as it is no longer used.

An unfortunate side-effect of this change is that the error for
the case in question is now less-specific.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/ofp-actions.c
lib/ofp-errors.h
tests/ofp-actions.at