ofp-util: Again allow OpenFlow port 0 in commands and actions.
authorBen Pfaff <blp@nicira.com>
Wed, 17 Oct 2012 20:29:34 +0000 (13:29 -0700)
committerBen Pfaff <blp@nicira.com>
Thu, 18 Oct 2012 16:23:16 +0000 (09:23 -0700)
commite3432ee978b4fd740aa4db785742a28a573e2cde
tree03584408926965da4af14a063ff28dc0f8cdddde
parent8010100bb17598479d1b3bb06452546075038f6f
ofp-util: Again allow OpenFlow port 0 in commands and actions.

Commit c6100d92142b (ovs-ofctl: Accept port keywords, OF1.1 port numbers,
reject port number 0.) intentionally prohibited using port 0, which is not
a valid OpenFlow port number, in OpenFlow commands and actions.  However,
since then we have discovered that the NVP controller uses port 0 in
"resubmit" actions and hence in flow matches as well.  This seems like a
valid enough use case; after all, the port number in a resubmit action is
really just an arbitrary number that need not (and preferably does not)
refer to an actual OpenFlow port.  Therefore, this commit restores the
ability to use port 0.

(Only functions that parse OpenFlow commands and actions from strings, not
those that interpret binary OpenFlow coming in on OpenFlow connections,
were affected by this prohibition, so this only comes up in corner cases
anyhow.)

Reported-by: Gurucharan Shetty <gshetty@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
NEWS
lib/ofp-util.c
tests/ovs-ofctl.at