Rearrange structures to better fit valgrind's memory leak heuristics.
authorBen Pfaff <blp@nicira.com>
Wed, 28 Mar 2012 21:13:02 +0000 (14:13 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 28 Mar 2012 21:55:27 +0000 (14:55 -0700)
commit6e492d81450217a5c90cbb4ad31d81b1e611989b
tree6882ef2d7c93c6887a8fcc48dbed3a7b55084b95
parent94c336723ca2228cfd60d2207775871e4b773c8b
Rearrange structures to better fit valgrind's memory leak heuristics.

valgrind's memory leak detector considers a pointer to the head of a memory
block to be "definitely" a pointer to that memory block but a pointer to
the interior of a memory block only "possibly" a pointer to that memory
block.  Open vSwitch hmap_node and list data structures can go anywhere
inside a structure; if they are in the middle of a structure then valgrind
considers pointers to them to be possible leaks.  Therefore, this commit
moves some of these from the middle of data structures to the head, to
reduce valgrind's uncertainty.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif.c
ofproto/ofproto-provider.h
ovsdb/jsonrpc-server.c
ovsdb/row.h
ovsdb/server.h
vswitchd/bridge.c