Avoid shadowing local variable names.
authorBen Pfaff <blp@nicira.com>
Thu, 2 Sep 2010 17:09:09 +0000 (10:09 -0700)
committerBen Pfaff <blp@nicira.com>
Mon, 20 Sep 2010 16:39:54 +0000 (09:39 -0700)
commit2a022368f4b37559de5d5621a88c648023493f75
treebfb5291578273782b71ad2d5fbdb72744e94d857
parent1089aab7136612acb86cdcd638d7d2261311531a
Avoid shadowing local variable names.

All of these changes avoid using the same name for two local variables
within a same function.  None of them are actual bugs as far as I can tell,
but any of them could be confusing to the casual reader.

The one in lib/ovsdb-idl.c is particularly brilliant: inner and outer
loops both using (different) variables named 'i'.

Found with GCC -Wshadow.
19 files changed:
lib/dpif-netdev.c
lib/dynamic-string.c
lib/json.c
lib/learning-switch.c
lib/netdev-linux.c
lib/netlink.c
lib/ofp-parse.c
lib/ovsdb-idl.c
lib/process.c
lib/stream-fd.c
lib/stream-ssl.c
ofproto/ofproto.c
ovsdb/execution.c
tests/test-csum.c
tests/test-ovsdb.c
utilities/ovs-controller.c
utilities/ovs-openflowd.c
utilities/ovs-vsctl.c
vswitchd/bridge.c