X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=vswitchd%2Fbridge.c;h=c8b50d7136bb7750a997290f4de926860effe28f;hb=6aa7430820bb327b65de0e02baf928ed663bef2b;hp=ed2f53735f1a7b5f38dae8a2dd0db62e4de65c7e;hpb=cca46d331eac52e58c0cf9662833a76c71e27af4;p=openvswitch

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index ed2f5373..c8b50d71 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -43,6 +43,7 @@
 #include "hash.h"
 #include "hmap.h"
 #include "jsonrpc.h"
+#include "lacp.h"
 #include "list.h"
 #include "mac-learning.h"
 #include "netdev.h"
@@ -95,13 +96,6 @@ static void dst_set_init(struct dst_set *);
 static void dst_set_add(struct dst_set *, const struct dst *);
 static void dst_set_free(struct dst_set *);
 
-enum lacp_status {
-    LACP_CURRENT   = 0x01, /* Current State. */
-    LACP_EXPIRED   = 0x02, /* Expired State. */
-    LACP_DEFAULTED = 0x04, /* Partner is defaulted. */
-    LACP_ATTACHED  = 0x08, /* Attached. Interface may be choosen for flows. */
-};
-
 struct iface {
     /* These members are always valid. */
     struct port *port;          /* Containing port. */
@@ -122,12 +116,7 @@ struct iface {
     const struct ovsrec_interface *cfg;
 
     /* LACP information. */
-    enum lacp_status lacp_status;  /* LACP status. */
-    uint16_t lacp_priority;        /* LACP port priority. */
-    struct lacp_info lacp_actor;   /* LACP actor information. */
-    struct lacp_info lacp_partner; /* LACP partner information. */
-    long long int lacp_tx;         /* Next LACP message transmission time. */
-    long long int lacp_rx;         /* Next LACP message receive time. */
+    uint16_t lacp_priority;     /* LACP port priority. */
 };
 
 #define BOND_MASK 0xff
@@ -164,11 +153,6 @@ struct mirror {
     int out_vlan;
 };
 
-/* Flags for a port's lacp member. */
-#define LACP_ACTIVE     0x01 /* LACP is in active mode. */
-#define LACP_PASSIVE    0x02 /* LACP is in passive mode. */
-#define LACP_NEGOTIATED 0x04 /* LACP has successfully negotiated. */
-
 #define FLOOD_PORT ((struct port *) 1) /* The 'flood' output port. */
 struct port {
     struct bridge *bridge;
@@ -179,6 +163,11 @@ struct port {
     const struct ovsrec_port *cfg;
     char *name;
 
+    /* Monitoring. */
+    struct netdev_monitor *monitor;   /* Tracks carrier. NULL if miimon. */
+    long long int miimon_interval;    /* Miimon status refresh interval. */
+    long long int miimon_next_update; /* Time of next miimon update. */
+
     /* An ordinary bridge port has 1 interface.
      * A bridge port for bonding has at least 2 interfaces. */
     struct iface **ifaces;
@@ -191,17 +180,12 @@ struct port {
     tag_type no_ifaces_tag;     /* Tag for flows when all ifaces disabled. */
     int updelay, downdelay;     /* Delay before iface goes up/down, in ms. */
     bool bond_fake_iface;       /* Fake a bond interface for legacy compat? */
-    bool miimon;                /* Use miimon instead of carrier? */
-    long long int bond_miimon_interval; /* Miimon status refresh interval. */
-    long long int bond_miimon_next_update; /* Time of next miimon update. */
     long long int bond_next_fake_iface_update; /* Time of next update. */
-    struct netdev_monitor *monitor; /* Tracks carrier up/down status. */
 
     /* LACP information. */
-    int lacp;                   /* LACP status flags. 0 if LACP is off. */
-    uint16_t lacp_key;          /* LACP aggregation key. */
+    struct lacp *lacp;          /* LACP object. NULL if LACP is disabled. */
+    bool lacp_active;           /* True if LACP is active */
     uint16_t lacp_priority;     /* LACP system priority. */
-    bool lacp_need_update;      /* Need to update attached interfaces? */
 
     /* SLB specific bonding info. */
     struct bond_entry *bond_hash; /* An array of (BOND_MASK + 1) elements. */
@@ -281,18 +265,17 @@ static struct iface *bridge_get_local_iface(struct bridge *);
 static uint64_t dpid_from_hash(const void *, size_t nbytes);
 
 static unixctl_cb_func bridge_unixctl_fdb_show;
-
-static void lacp_run(struct bridge *);
-static void lacp_wait(struct bridge *);
-static void lacp_process_packet(const struct ofpbuf *, struct iface *);
+static unixctl_cb_func qos_unixctl_show;
 
 static void bond_init(void);
-static void bond_run(struct bridge *);
-static void bond_wait(struct bridge *);
+static void bond_run(struct port *);
+static void bond_wait(struct port *);
 static void bond_rebalance_port(struct port *);
 static void bond_send_learning_packets(struct port *);
 static void bond_enable_slave(struct iface *iface, bool enable);
 
+static void port_run(struct port *);
+static void port_wait(struct port *);
 static struct port *port_create(struct bridge *, const char *name);
 static void port_reconfigure(struct port *, const struct ovsrec_port *);
 static void port_del_ifaces(struct port *, const struct ovsrec_port *);
@@ -314,6 +297,7 @@ static struct iface *iface_create(struct port *port,
                                   const struct ovsrec_interface *if_cfg);
 static void iface_destroy(struct iface *);
 static struct iface *iface_lookup(const struct bridge *, const char *name);
+static struct iface *iface_find(const char *name);
 static struct iface *iface_from_dp_ifidx(const struct bridge *,
                                          uint16_t dp_ifidx);
 static void iface_set_mac(struct iface *);
@@ -322,10 +306,7 @@ static void iface_update_qos(struct iface *, const struct ovsrec_qos *);
 static void iface_update_cfm(struct iface *);
 static void iface_refresh_cfm_stats(struct iface *iface);
 static void iface_send_packet(struct iface *, struct ofpbuf *packet);
-static uint8_t iface_get_lacp_state(const struct iface *);
-static void iface_get_lacp_priority(struct iface *, struct lacp_info *);
-static void iface_set_lacp_defaulted(struct iface *);
-static void iface_set_lacp_expired(struct iface *);
+static void iface_update_carrier(struct iface *, bool carrier);
 
 static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
                                    struct shash *);
@@ -362,10 +343,12 @@ bridge_init(const char *remote)
 
     /* Register unixctl commands. */
     unixctl_command_register("fdb/show", bridge_unixctl_fdb_show, NULL);
+    unixctl_command_register("qos/show", qos_unixctl_show, NULL);
     unixctl_command_register("bridge/dump-flows", bridge_unixctl_dump_flows,
                              NULL);
     unixctl_command_register("bridge/reconnect", bridge_unixctl_reconnect,
                              NULL);
+    lacp_init();
     bond_init();
 }
 
@@ -908,8 +891,16 @@ bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
             struct port *port = br->ports[i];
             int j;
 
-            port_update_bonding(port);
+            if (port->monitor) {
+                for (j = 0; j < port->n_ifaces; j++) {
+                    netdev_monitor_add(port->monitor, port->ifaces[j]->netdev);
+                }
+            } else {
+                port->miimon_next_update = 0;
+            }
+
             port_update_lacp(port);
+            port_update_bonding(port);
 
             for (j = 0; j < port->n_ifaces; j++) {
                 iface_update_qos(port->ifaces[j], port->cfg->qos);
@@ -1487,22 +1478,19 @@ void
 bridge_wait(void)
 {
     struct bridge *br;
-    struct iface *iface;
 
     LIST_FOR_EACH (br, node, &all_bridges) {
+        size_t i;
+
         ofproto_wait(br->ofproto);
         if (ofproto_has_primary_controller(br->ofproto)) {
             continue;
         }
 
         mac_learning_wait(br->ml);
-        lacp_wait(br);
-        bond_wait(br);
 
-        HMAP_FOR_EACH (iface, dp_ifidx_node, &br->ifaces) {
-            if (iface->cfm) {
-                cfm_wait(iface->cfm);
-            }
+        for (i = 0; i < br->n_ports; i++) {
+            port_wait(br->ports[i]);
         }
     }
     ovsdb_idl_wait(idl);
@@ -1567,6 +1555,99 @@ bridge_unixctl_fdb_show(struct unixctl_conn *conn,
     ds_destroy(&ds);
 }
 
+/* QoS unixctl user interface functions. */
+
+struct qos_unixctl_show_cbdata {
+    struct ds *ds;
+    struct iface *iface;
+};
+
+static void
+qos_unixctl_show_cb(unsigned int queue_id,
+                    const struct shash *details,
+                    void *aux)
+{
+    struct qos_unixctl_show_cbdata *data = aux;
+    struct ds *ds = data->ds;
+    struct iface *iface = data->iface;
+    struct netdev_queue_stats stats;
+    struct shash_node *node;
+    int error;
+
+    ds_put_cstr(ds, "\n");
+    if (queue_id) {
+        ds_put_format(ds, "Queue %u:\n", queue_id);
+    } else {
+        ds_put_cstr(ds, "Default:\n");
+    }
+
+    SHASH_FOR_EACH (node, details) {
+        ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
+    }
+
+    error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
+    if (!error) {
+        if (stats.tx_packets != UINT64_MAX) {
+            ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
+        }
+
+        if (stats.tx_bytes != UINT64_MAX) {
+            ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
+        }
+
+        if (stats.tx_errors != UINT64_MAX) {
+            ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
+        }
+    } else {
+        ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
+                      queue_id, strerror(error));
+    }
+}
+
+static void
+qos_unixctl_show(struct unixctl_conn *conn,
+                 const char *args, void *aux OVS_UNUSED)
+{
+    struct ds ds = DS_EMPTY_INITIALIZER;
+    struct shash sh = SHASH_INITIALIZER(&sh);
+    struct iface *iface;
+    const char *type;
+    struct shash_node *node;
+    struct qos_unixctl_show_cbdata data;
+    int error;
+
+    iface = iface_find(args);
+    if (!iface) {
+        unixctl_command_reply(conn, 501, "no such interface");
+        return;
+    }
+
+    netdev_get_qos(iface->netdev, &type, &sh);
+
+    if (*type != '\0') {
+        ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
+
+        SHASH_FOR_EACH (node, &sh) {
+            ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
+        }
+
+        data.ds = &ds;
+        data.iface = iface;
+        error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
+
+        if (error) {
+            ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
+        }
+        unixctl_command_reply(conn, 200, ds_cstr(&ds));
+    } else {
+        ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
+        unixctl_command_reply(conn, 501, ds_cstr(&ds));
+    }
+
+    shash_destroy_free_data(&sh);
+    ds_destroy(&ds);
+}
+
 /* Bridge reconfiguration functions. */
 static struct bridge *
 bridge_create(const struct ovsrec_bridge *br_cfg)
@@ -1703,8 +1784,8 @@ bridge_unixctl_reconnect(struct unixctl_conn *conn,
 static int
 bridge_run_one(struct bridge *br)
 {
+    size_t i;
     int error;
-    struct iface *iface;
 
     error = ofproto_run1(br->ofproto);
     if (error) {
@@ -1712,27 +1793,14 @@ bridge_run_one(struct bridge *br)
     }
 
     mac_learning_run(br->ml, ofproto_get_revalidate_set(br->ofproto));
-    lacp_run(br);
-    bond_run(br);
+
+    for (i = 0; i < br->n_ports; i++) {
+        port_run(br->ports[i]);
+    }
 
     error = ofproto_run2(br->ofproto, br->flush);
     br->flush = false;
 
-    HMAP_FOR_EACH (iface, dp_ifidx_node, &br->ifaces) {
-        struct ofpbuf *packet;
-
-        if (!iface->cfm) {
-            continue;
-        }
-
-        packet = cfm_run(iface->cfm);
-        if (packet) {
-            iface_send_packet(iface, packet);
-            ofpbuf_uninit(packet);
-            free(packet);
-        }
-    }
-
     return error;
 }
 
@@ -1874,8 +1942,6 @@ bridge_ofproto_controller_for_mgmt(const struct bridge *br,
     oc->max_backoff = 0;
     oc->probe_interval = 60;
     oc->band = OFPROTO_OUT_OF_BAND;
-    oc->accept_re = NULL;
-    oc->update_resolv_conf = false;
     oc->rate_limit = 0;
     oc->burst_limit = 0;
 }
@@ -1890,8 +1956,6 @@ bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
     oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
     oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
                 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
-    oc->accept_re = c->discover_accept_regex;
-    oc->update_resolv_conf = c->discover_update_resolv_conf;
     oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
     oc->burst_limit = (c->controller_burst_limit
                        ? *c->controller_burst_limit : 0);
@@ -1909,11 +1973,6 @@ bridge_configure_local_iface_netdev(struct bridge *br,
     struct iface *local_iface;
     struct in_addr ip;
 
-    /* Controller discovery does its own TCP/IP configuration later. */
-    if (strcmp(c->target, "discover")) {
-        return;
-    }
-
     /* If there's no local interface or no IP address, give up. */
     local_iface = bridge_get_local_iface(br);
     if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
@@ -2108,7 +2167,7 @@ bridge_fetch_dp_ifaces(struct bridge *br)
 static bool
 bond_is_tcp_hash(const struct port *port)
 {
-    return port->bond_mode == BM_TCP && port->lacp & LACP_NEGOTIATED;
+    return port->bond_mode == BM_TCP && lacp_negotiated(port->lacp);
 }
 
 static int
@@ -2156,8 +2215,7 @@ bond_choose_iface(const struct port *port)
         if (iface->enabled) {
             return i;
         } else if (iface->delay_expires < next_delay_expiration
-                   && (iface->lacp_status & LACP_ATTACHED
-                       || !(port->lacp & LACP_NEGOTIATED))) {
+                   && lacp_slave_may_enable(port->lacp, iface)) {
             best_down_slave = i;
             next_delay_expiration = iface->delay_expires;
         }
@@ -2216,29 +2274,17 @@ bond_link_status_update(struct iface *iface)
 {
     static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
     struct port *port = iface->port;
-    bool up = iface->up;
+    bool up = iface->up && lacp_slave_may_enable(port->lacp, iface);
     int updelay, downdelay;
 
     updelay = port->updelay;
     downdelay = port->downdelay;
 
-    if (iface->port->lacp & LACP_NEGOTIATED) {
+    if (lacp_negotiated(port->lacp)) {
         downdelay = 0;
         updelay = 0;
     }
 
-    if (iface->port->lacp && up) {
-        /* The interface is up if it's attached to an aggregator and its
-         * partner is synchronized.  The only exception is defaulted links.
-         * They are not required to have synchronized partners because they
-         * have no partners at all.  However, they will only be attached if
-         * negotiations failed on all interfaces in the bond. */
-        up = iface->lacp_status & LACP_ATTACHED
-            && (iface->lacp_partner.state & LACP_STATE_SYNC
-                 || iface->lacp_status & LACP_DEFAULTED);
-    }
-
-
     if ((up == iface->enabled) == (iface->delay_expires == LLONG_MAX)) {
         /* Nothing to do. */
         return;
@@ -2371,107 +2417,50 @@ bond_update_fake_iface_stats(struct port *port)
 }
 
 static void
-bond_link_carrier_update(struct iface *iface, bool carrier)
+bond_run(struct port *port)
 {
-    if (carrier == iface->up) {
+    size_t i;
+
+    if (port->n_ifaces < 2) {
         return;
     }
 
-    if (iface->lacp_status & LACP_CURRENT) {
-        iface_set_lacp_expired(iface);
+    for (i = 0; i < port->n_ifaces; i++) {
+        bond_link_status_update(port->ifaces[i]);
     }
 
-    iface->up = carrier;
-    iface->lacp_tx = 0;
-}
-
-static void
-bond_run(struct bridge *br)
-{
-    size_t i, j;
-
-    for (i = 0; i < br->n_ports; i++) {
-        struct port *port = br->ports[i];
-
-        if (port->n_ifaces >= 2) {
-            char *devname;
-
-            if (port->monitor) {
-                assert(!port->miimon);
-
-                /* Track carrier going up and down on interfaces. */
-                while (!netdev_monitor_poll(port->monitor, &devname)) {
-                    struct iface *iface;
-
-                    iface = port_lookup_iface(port, devname);
-                    if (iface) {
-                        bool up = netdev_get_carrier(iface->netdev);
-                        bond_link_carrier_update(iface, up);
-                    }
-                    free(devname);
-                }
-            } else {
-                assert(port->miimon);
-
-                if (time_msec() >= port->bond_miimon_next_update) {
-                    for (j = 0; j < port->n_ifaces; j++) {
-                        struct iface *iface = port->ifaces[j];
-                        bool up = netdev_get_miimon(iface->netdev);
-                        bond_link_carrier_update(iface, up);
-                    }
-                    port->bond_miimon_next_update = time_msec() +
-                        port->bond_miimon_interval;
-                }
-            }
-
-            for (j = 0; j < port->n_ifaces; j++) {
-                bond_link_status_update(port->ifaces[j]);
-            }
-
-            for (j = 0; j < port->n_ifaces; j++) {
-                struct iface *iface = port->ifaces[j];
-                if (time_msec() >= iface->delay_expires) {
-                    bond_enable_slave(iface, !iface->enabled);
-                }
-            }
-
-            if (port->bond_fake_iface
-                && time_msec() >= port->bond_next_fake_iface_update) {
-                bond_update_fake_iface_stats(port);
-                port->bond_next_fake_iface_update = time_msec() + 1000;
-            }
+    for (i = 0; i < port->n_ifaces; i++) {
+        struct iface *iface = port->ifaces[i];
+        if (time_msec() >= iface->delay_expires) {
+            bond_enable_slave(iface, !iface->enabled);
         }
     }
+
+    if (port->bond_fake_iface
+        && time_msec() >= port->bond_next_fake_iface_update) {
+        bond_update_fake_iface_stats(port);
+        port->bond_next_fake_iface_update = time_msec() + 1000;
+    }
 }
 
 static void
-bond_wait(struct bridge *br)
+bond_wait(struct port *port)
 {
-    size_t i, j;
-
-    for (i = 0; i < br->n_ports; i++) {
-        struct port *port = br->ports[i];
-        if (port->n_ifaces < 2) {
-            continue;
-        }
+    size_t i;
 
-        if (port->monitor) {
-            netdev_monitor_poll_wait(port->monitor);
-        }
+    if (port->n_ifaces < 2) {
+        return;
+    }
 
-        if (port->miimon) {
-            poll_timer_wait_until(port->bond_miimon_next_update);
+    for (i = 0; i < port->n_ifaces; i++) {
+        struct iface *iface = port->ifaces[i];
+        if (iface->delay_expires != LLONG_MAX) {
+            poll_timer_wait_until(iface->delay_expires);
         }
+    }
 
-        for (j = 0; j < port->n_ifaces; j++) {
-            struct iface *iface = port->ifaces[j];
-            if (iface->delay_expires != LLONG_MAX) {
-                poll_timer_wait_until(iface->delay_expires);
-            }
-        }
-        if (port->bond_fake_iface) {
-            poll_timer_wait_until(port->bond_next_fake_iface_update);
-        }
+    if (port->bond_fake_iface) {
+        poll_timer_wait_until(port->bond_next_fake_iface_update);
     }
 }
 
@@ -2896,13 +2885,13 @@ is_admissible(struct bridge *br, const struct flow *flow, bool have_packet,
     }
 
     /* When using LACP, do not accept packets from disabled interfaces. */
-    if (in_port->lacp & LACP_NEGOTIATED && !in_iface->enabled) {
+    if (lacp_negotiated(in_port->lacp) && !in_iface->enabled) {
         return false;
     }
 
     /* Packets received on non-LACP bonds need special attention to avoid
      * duplicates. */
-    if (in_port->n_ifaces > 1 && !(in_port->lacp & LACP_NEGOTIATED)) {
+    if (in_port->n_ifaces > 1 && !lacp_negotiated(in_port->lacp)) {
         int src_idx;
         bool is_grat_arp_locked;
 
@@ -3015,9 +3004,13 @@ bridge_special_ofhook_cb(const struct flow *flow,
         return false;
     } else if (flow->dl_type == htons(ETH_TYPE_LACP)) {
 
-        if (iface && packet) {
-            COVERAGE_INC(bridge_process_lacp);
-            lacp_process_packet(packet, iface);
+        if (iface && iface->port->lacp && packet) {
+            const struct lacp_pdu *pdu = parse_lacp_packet(packet);
+
+            if (pdu) {
+                COVERAGE_INC(bridge_process_lacp);
+                lacp_process_pdu(iface->port->lacp, iface, pdu);
+            }
         }
         return false;
     }
@@ -3097,196 +3090,6 @@ static struct ofhooks bridge_ofhooks = {
     bridge_account_checkpoint_ofhook_cb,
 };
 
-/* LACP functions. */
-
-static void
-lacp_process_packet(const struct ofpbuf *packet, struct iface *iface)
-{
-    const struct lacp_pdu *pdu;
-
-    if (!iface->port->lacp) {
-        return;
-    }
-
-    pdu = parse_lacp_packet(packet);
-    if (!pdu) {
-        return;
-    }
-
-    iface->lacp_status |= LACP_CURRENT;
-    iface->lacp_status &= ~(LACP_EXPIRED | LACP_DEFAULTED);
-    iface->lacp_rx = time_msec() + LACP_SLOW_TIME_RX;
-
-    iface->lacp_actor.state = iface_get_lacp_state(iface);
-    if (memcmp(&iface->lacp_actor, &pdu->partner, sizeof pdu->partner)) {
-        iface->lacp_tx = 0;
-    }
-
-    if (memcmp(&iface->lacp_partner, &pdu->actor, sizeof pdu->actor)) {
-        iface->port->lacp_need_update = true;
-        iface->lacp_partner = pdu->actor;
-    }
-}
-
-static void
-lacp_update_ifaces(struct port *port)
-{
-    size_t i;
-    struct iface *lead;
-    struct lacp_info lead_pri;
-    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
-
-    port->lacp_need_update = false;
-    COVERAGE_INC(bridge_lacp_update);
-
-    if (!port->lacp) {
-        return;
-    }
-
-    VLOG_DBG_RL(&rl, "port %s: re-evaluating LACP link status", port->name);
-
-    lead = NULL;
-    for (i = 0; i < port->n_ifaces; i++) {
-        struct iface *iface = port->ifaces[i];
-        struct lacp_info pri;
-
-        iface->lacp_status |= LACP_ATTACHED;
-        ofproto_revalidate(port->bridge->ofproto, iface->tag);
-
-        /* Don't allow loopback interfaces to send traffic or lead. */
-        if (eth_addr_equals(iface->lacp_partner.sysid,
-                            iface->lacp_actor.sysid)) {
-            VLOG_WARN_RL(&rl, "iface %s: Loopback detected. Interface is "
-                         "connected to its own bridge", iface->name);
-            iface->lacp_status &= ~LACP_ATTACHED;
-            continue;
-        }
-
-        if (iface->lacp_status & LACP_DEFAULTED) {
-            continue;
-        }
-
-        iface_get_lacp_priority(iface, &pri);
-
-        if (!lead || memcmp(&pri, &lead_pri, sizeof pri) < 0) {
-            lead = iface;
-            lead_pri = pri;
-        }
-    }
-
-    if (!lead) {
-        port->lacp &= ~LACP_NEGOTIATED;
-        return;
-    }
-
-    port->lacp |= LACP_NEGOTIATED;
-
-    for (i = 0; i < port->n_ifaces; i++) {
-        struct iface *iface = port->ifaces[i];
-
-        if (iface->lacp_status & LACP_DEFAULTED
-            || lead->lacp_partner.key != iface->lacp_partner.key
-            || !eth_addr_equals(lead->lacp_partner.sysid,
-                                iface->lacp_partner.sysid)) {
-            iface->lacp_status &= ~LACP_ATTACHED;
-        }
-    }
-}
-
-static bool
-lacp_iface_may_tx(const struct iface *iface)
-{
-    return iface->port->lacp & LACP_ACTIVE
-        || iface->lacp_status & (LACP_CURRENT | LACP_EXPIRED);
-}
-
-static void
-lacp_run(struct bridge *br)
-{
-    size_t i, j;
-    struct ofpbuf packet;
-
-    ofpbuf_init(&packet, ETH_HEADER_LEN + LACP_PDU_LEN);
-
-    for (i = 0; i < br->n_ports; i++) {
-        struct port *port = br->ports[i];
-
-        if (!port->lacp) {
-            continue;
-        }
-
-        for (j = 0; j < port->n_ifaces; j++) {
-            struct iface *iface = port->ifaces[j];
-
-            if (time_msec() > iface->lacp_rx) {
-                if (iface->lacp_status & LACP_CURRENT) {
-                    iface_set_lacp_expired(iface);
-                } else if (iface->lacp_status & LACP_EXPIRED) {
-                    iface_set_lacp_defaulted(iface);
-                }
-            }
-        }
-
-        if (port->lacp_need_update) {
-            lacp_update_ifaces(port);
-        }
-
-        for (j = 0; j < port->n_ifaces; j++) {
-            struct iface *iface = port->ifaces[j];
-            uint8_t ea[ETH_ADDR_LEN];
-            int error;
-
-            if (time_msec() < iface->lacp_tx || !lacp_iface_may_tx(iface)) {
-                continue;
-            }
-
-            error = netdev_get_etheraddr(iface->netdev, ea);
-            if (!error) {
-                iface->lacp_actor.state = iface_get_lacp_state(iface);
-                compose_lacp_packet(&packet, &iface->lacp_actor,
-                                    &iface->lacp_partner, ea);
-                iface_send_packet(iface, &packet);
-            } else {
-                static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
-                VLOG_ERR_RL(&rl, "iface %s: failed to obtain Ethernet address "
-                            "(%s)", iface->name, strerror(error));
-            }
-
-            iface->lacp_tx = time_msec() +
-                (iface->lacp_partner.state & LACP_STATE_TIME
-                 ? LACP_FAST_TIME_TX
-                 : LACP_SLOW_TIME_TX);
-        }
-    }
-    ofpbuf_uninit(&packet);
-}
-
-static void
-lacp_wait(struct bridge *br)
-{
-    size_t i, j;
-
-    for (i = 0; i < br->n_ports; i++) {
-        struct port *port = br->ports[i];
-
-        if (!port->lacp) {
-            continue;
-        }
-
-        for (j = 0; j < port->n_ifaces; j++) {
-            struct iface *iface = port->ifaces[j];
-
-            if (lacp_iface_may_tx(iface)) {
-                poll_timer_wait_until(iface->lacp_tx);
-            }
-
-            if (iface->lacp_status & (LACP_CURRENT | LACP_EXPIRED)) {
-                poll_timer_wait_until(iface->lacp_rx);
-            }
-        }
-    }
-}
-
 /* Bonding functions. */
 
 /* Statistics for a single interface on a bonded port, used for load-based
@@ -3731,42 +3534,6 @@ bond_find(const char *name)
     return NULL;
 }
 
-static void
-ds_put_lacp_state(struct ds *ds, uint8_t state)
-{
-    if (state & LACP_STATE_ACT) {
-        ds_put_cstr(ds, "activity ");
-    }
-
-    if (state & LACP_STATE_TIME) {
-        ds_put_cstr(ds, "timeout ");
-    }
-
-    if (state & LACP_STATE_AGG) {
-        ds_put_cstr(ds, "aggregation ");
-    }
-
-    if (state & LACP_STATE_SYNC) {
-        ds_put_cstr(ds, "synchronized ");
-    }
-
-    if (state & LACP_STATE_COL) {
-        ds_put_cstr(ds, "collecting ");
-    }
-
-    if (state & LACP_STATE_DIST) {
-        ds_put_cstr(ds, "distributing ");
-    }
-
-    if (state & LACP_STATE_DEF) {
-        ds_put_cstr(ds, "defaulted ");
-    }
-
-    if (state & LACP_STATE_EXP) {
-        ds_put_cstr(ds, "expired ");
-    }
-}
-
 static void
 bond_unixctl_show(struct unixctl_conn *conn,
                   const char *args, void *aux OVS_UNUSED)
@@ -3786,7 +3553,7 @@ bond_unixctl_show(struct unixctl_conn *conn,
 
     if (port->lacp) {
         ds_put_format(&ds, "lacp: %s\n",
-                      port->lacp & LACP_ACTIVE ? "active" : "passive");
+                      port->lacp_active ? "active" : "passive");
     } else {
         ds_put_cstr(&ds, "lacp: off\n");
     }
@@ -3798,11 +3565,11 @@ bond_unixctl_show(struct unixctl_conn *conn,
 
 
     ds_put_format(&ds, "bond-detect-mode: %s\n",
-                  port->miimon ? "miimon" : "carrier");
+                  port->monitor ? "carrier" : "miimon");
 
-    if (port->miimon) {
+    if (!port->monitor) {
         ds_put_format(&ds, "bond-miimon-interval: %lld\n",
-                      port->bond_miimon_interval);
+                      port->miimon_interval);
     }
 
     ds_put_format(&ds, "updelay: %d ms\n", port->updelay);
@@ -3830,70 +3597,6 @@ bond_unixctl_show(struct unixctl_conn *conn,
                           iface->delay_expires - time_msec());
         }
 
-        if (port->lacp) {
-            ds_put_cstr(&ds, "\tstatus: ");
-
-            if (iface->lacp_status & LACP_CURRENT) {
-                ds_put_cstr(&ds, "current ");
-            }
-
-            if (iface->lacp_status & LACP_EXPIRED) {
-                ds_put_cstr(&ds, "expired ");
-            }
-
-            if (iface->lacp_status & LACP_DEFAULTED) {
-                ds_put_cstr(&ds, "defaulted ");
-            }
-
-            if (iface->lacp_status & LACP_ATTACHED) {
-                ds_put_cstr(&ds, "attached ");
-            }
-
-            ds_put_cstr(&ds, "\n");
-
-            ds_put_cstr(&ds, "\n\tactor sysid: ");
-            ds_put_format(&ds, ETH_ADDR_FMT,
-                          ETH_ADDR_ARGS(iface->lacp_actor.sysid));
-            ds_put_cstr(&ds, "\n");
-
-            ds_put_format(&ds, "\tactor sys_priority: %u\n",
-                          ntohs(iface->lacp_actor.sys_priority));
-
-            ds_put_format(&ds, "\tactor portid: %u\n",
-                          ntohs(iface->lacp_actor.portid));
-
-            ds_put_format(&ds, "\tactor port_priority: %u\n",
-                          ntohs(iface->lacp_actor.port_priority));
-
-            ds_put_format(&ds, "\tactor key: %u\n",
-                          ntohs(iface->lacp_actor.key));
-
-            ds_put_cstr(&ds, "\tactor state: ");
-            ds_put_lacp_state(&ds, iface_get_lacp_state(iface));
-            ds_put_cstr(&ds, "\n\n");
-
-            ds_put_cstr(&ds, "\tpartner sysid: ");
-            ds_put_format(&ds, ETH_ADDR_FMT,
-                          ETH_ADDR_ARGS(iface->lacp_partner.sysid));
-            ds_put_cstr(&ds, "\n");
-
-            ds_put_format(&ds, "\tpartner sys_priority: %u\n",
-                          ntohs(iface->lacp_partner.sys_priority));
-
-            ds_put_format(&ds, "\tpartner portid: %u\n",
-                          ntohs(iface->lacp_partner.portid));
-
-            ds_put_format(&ds, "\tpartner port_priority: %u\n",
-                          ntohs(iface->lacp_partner.port_priority));
-
-            ds_put_format(&ds, "\tpartner key: %u\n",
-                          ntohs(iface->lacp_partner.key));
-
-            ds_put_cstr(&ds, "\tpartner state: ");
-            ds_put_lacp_state(&ds, iface->lacp_partner.state);
-            ds_put_cstr(&ds, "\n");
-        }
-
         if (port->bond_mode == BM_AB) {
             continue;
         }
@@ -4142,6 +3845,105 @@ bond_init(void)
 
 /* Port functions. */
 
+static void
+lacp_send_pdu_cb(void *aux, const struct lacp_pdu *pdu)
+{
+    struct iface *iface = aux;
+    uint8_t ea[ETH_ADDR_LEN];
+    int error;
+
+    error = netdev_get_etheraddr(iface->netdev, ea);
+    if (!error) {
+        struct ofpbuf packet;
+
+        ofpbuf_init(&packet, ETH_HEADER_LEN + LACP_PDU_LEN);
+        compose_lacp_packet(&packet, ea, pdu);
+        iface_send_packet(iface, &packet);
+        ofpbuf_uninit(&packet);
+    } else {
+        static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
+        VLOG_ERR_RL(&rl, "iface %s: failed to obtain Ethernet address "
+                    "(%s)", iface->name, strerror(error));
+    }
+}
+
+static void
+port_run(struct port *port)
+{
+    size_t i;
+
+    if (port->monitor) {
+        char *devname;
+
+        /* Track carrier going up and down on interfaces. */
+        while (!netdev_monitor_poll(port->monitor, &devname)) {
+            struct iface *iface;
+
+            iface = port_lookup_iface(port, devname);
+            if (iface) {
+                iface_update_carrier(iface, netdev_get_carrier(iface->netdev));
+            }
+            free(devname);
+        }
+    } else if (time_msec() >= port->miimon_next_update) {
+
+        for (i = 0; i < port->n_ifaces; i++) {
+            struct iface *iface = port->ifaces[i];
+            iface_update_carrier(iface, netdev_get_miimon(iface->netdev));
+        }
+        port->miimon_next_update = time_msec() + port->miimon_interval;
+    }
+
+    if (port->lacp) {
+        for (i = 0; i < port->n_ifaces; i++) {
+            struct iface *iface = port->ifaces[i];
+            lacp_slave_enable(port->lacp, iface, iface->enabled);
+        }
+
+        lacp_run(port->lacp, lacp_send_pdu_cb);
+    }
+
+    bond_run(port);
+
+    for (i = 0; i < port->n_ifaces; i++) {
+        struct iface *iface = port->ifaces[i];
+
+        if (iface->cfm) {
+            struct ofpbuf *packet = cfm_run(iface->cfm);
+            if (packet) {
+                iface_send_packet(iface, packet);
+                ofpbuf_uninit(packet);
+                free(packet);
+            }
+        }
+    }
+}
+
+static void
+port_wait(struct port *port)
+{
+    size_t i;
+
+    if (port->monitor) {
+        netdev_monitor_poll_wait(port->monitor);
+    } else {
+        poll_timer_wait_until(port->miimon_next_update);
+    }
+
+    if (port->lacp) {
+        lacp_wait(port->lacp);
+    }
+
+    bond_wait(port);
+
+    for (i = 0; i < port->n_ifaces; i++) {
+        struct iface *iface = port->ifaces[i];
+        if (iface->cfm) {
+            cfm_wait(iface->cfm);
+        }
+    }
+}
+
 static struct port *
 port_create(struct bridge *br, const char *name)
 {
@@ -4249,24 +4051,26 @@ port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
     detect_mode = get_port_other_config(cfg, "bond-detect-mode",
                                         "carrier");
 
-    if (!strcmp(detect_mode, "carrier")) {
-        port->miimon = false;
-    } else if (!strcmp(detect_mode, "miimon")) {
-        port->miimon = true;
-    } else {
-        port->miimon = false;
-        VLOG_WARN("port %s: unsupported bond-detect-mode %s, defaulting to "
-                  "carrier", port->name, detect_mode);
+    netdev_monitor_destroy(port->monitor);
+    port->monitor = NULL;
+
+    if (strcmp(detect_mode, "miimon")) {
+        port->monitor = netdev_monitor_create();
+
+        if (strcmp(detect_mode, "carrier")) {
+            VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
+                      "defaulting to carrier", port->name, detect_mode);
+        }
     }
 
-    port->bond_miimon_interval = atoi(
+    port->miimon_interval = atoi(
         get_port_other_config(cfg, "bond-miimon-interval", "200"));
-    if (port->bond_miimon_interval < 100) {
-        port->bond_miimon_interval = 100;
+    if (port->miimon_interval < 100) {
+        port->miimon_interval = 100;
     }
-    miimon_next_update = time_msec() + port->bond_miimon_interval;
-    if (port->bond_miimon_next_update > miimon_next_update) {
-        port->bond_miimon_next_update = miimon_next_update;
+    miimon_next_update = time_msec() + port->miimon_interval;
+    if (port->miimon_next_update > miimon_next_update) {
+        port->miimon_next_update = miimon_next_update;
     }
 
     if (!port->cfg->bond_mode ||
@@ -4341,17 +4145,26 @@ port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
     if (!port->cfg->lacp) {
         /* XXX when LACP implementation has been sufficiently tested, enable by
          * default and make active on bonded ports. */
-        port->lacp = 0;
+        lacp_destroy(port->lacp);
+        port->lacp = NULL;
     } else if (!strcmp(port->cfg->lacp, "off")) {
-        port->lacp = 0;
+        lacp_destroy(port->lacp);
+        port->lacp = NULL;
     } else if (!strcmp(port->cfg->lacp, "active")) {
-        port->lacp = LACP_ACTIVE;
+        if (!port->lacp) {
+            port->lacp = lacp_create();
+        }
+        port->lacp_active = true;
     } else if (!strcmp(port->cfg->lacp, "passive")) {
-        port->lacp = LACP_PASSIVE;
+        if (!port->lacp) {
+            port->lacp = lacp_create();
+        }
+        port->lacp_active = false;
     } else {
         VLOG_WARN("port %s: unknown LACP mode %s",
                   port->name, port->cfg->lacp);
-        port->lacp = 0;
+        lacp_destroy(port->lacp);
+        port->lacp = NULL;
     }
 
     /* Get VLAN tag. */
@@ -4472,56 +4285,24 @@ port_lookup_iface(const struct port *port, const char *name)
 static void
 port_update_lacp(struct port *port)
 {
-    size_t i;
-    bool key_changed;
-
-    if (!port->lacp || port->n_ifaces < 1) {
-        for (i = 0; i < port->n_ifaces; i++) {
-            iface_set_lacp_defaulted(port->ifaces[i]);
-        }
-        return;
-    }
-
-    key_changed = true;
-    for (i = 0; i < port->n_ifaces; i++) {
-        struct iface *iface = port->ifaces[i];
+    if (port->lacp) {
+        size_t i;
 
-        if (iface->dp_ifidx <= 0 || iface->dp_ifidx > UINT16_MAX) {
-            port->lacp = 0;
-            return;
-        }
+        lacp_configure(port->lacp, port->name,
+                       port->bridge->ea, port->lacp_priority,
+                       port->lacp_active);
 
-        if (iface->dp_ifidx == port->lacp_key) {
-            key_changed = false;
+        for (i = 0; i < port->n_ifaces; i++) {
+            struct iface *iface = port->ifaces[i];
+            lacp_slave_register(port->lacp, iface, iface->name,
+                                iface->dp_ifidx, iface->lacp_priority);
         }
     }
-
-    if (key_changed) {
-        port->lacp_key = port->ifaces[0]->dp_ifidx;
-    }
-
-    for (i = 0; i < port->n_ifaces; i++) {
-        struct iface *iface = port->ifaces[i];
-
-        iface->lacp_actor.sys_priority = htons(port->lacp_priority);
-        memcpy(&iface->lacp_actor.sysid, port->bridge->ea, ETH_ADDR_LEN);
-
-        iface->lacp_actor.port_priority = htons(iface->lacp_priority);
-        iface->lacp_actor.portid = htons(iface->dp_ifidx);
-        iface->lacp_actor.key = htons(port->lacp_key);
-
-        iface->lacp_tx = 0;
-    }
-    port->lacp_need_update = true;
 }
 
 static void
 port_update_bonding(struct port *port)
 {
-    if (port->monitor) {
-        netdev_monitor_destroy(port->monitor);
-        port->monitor = NULL;
-    }
     if (port->n_ifaces < 2) {
         /* Not a bonded port. */
         free(port->bond_hash);
@@ -4559,101 +4340,11 @@ port_update_bonding(struct port *port)
             port->bond_next_fake_iface_update = time_msec();
         }
 
-        if (!port->miimon) {
-            port->monitor = netdev_monitor_create();
-            for (i = 0; i < port->n_ifaces; i++) {
-                netdev_monitor_add(port->monitor, port->ifaces[i]->netdev);
-            }
-        }
     }
 }
 
 /* Interface functions. */
 
-static void
-iface_set_lacp_defaulted(struct iface *iface)
-{
-    memset(&iface->lacp_partner, 0, sizeof iface->lacp_partner);
-
-    iface->lacp_status |= LACP_DEFAULTED;
-    iface->lacp_status &= ~(LACP_CURRENT | LACP_EXPIRED);
-    iface->lacp_tx = 0;
-    iface->port->lacp_need_update = true;
-}
-
-static void
-iface_set_lacp_expired(struct iface *iface)
-{
-    iface->lacp_status &= ~LACP_CURRENT;
-    iface->lacp_status |= LACP_EXPIRED;
-    iface->lacp_partner.state |= LACP_STATE_TIME;
-    iface->lacp_partner.state &= ~LACP_STATE_SYNC;
-
-    iface->lacp_rx = time_msec() + LACP_FAST_TIME_RX;
-    iface->lacp_tx = 0;
-}
-
-static uint8_t
-iface_get_lacp_state(const struct iface *iface)
-{
-    uint8_t state = 0;
-
-    if (iface->port->lacp & LACP_ACTIVE) {
-        state |= LACP_STATE_ACT;
-    }
-
-    if (iface->lacp_status & LACP_ATTACHED) {
-        state |= LACP_STATE_SYNC;
-    }
-
-    if (iface->lacp_status & LACP_DEFAULTED) {
-        state |= LACP_STATE_DEF;
-    }
-
-    if (iface->lacp_status & LACP_EXPIRED) {
-        state |= LACP_STATE_EXP;
-    }
-
-    if (iface->port->n_ifaces > 1) {
-        state |= LACP_STATE_AGG;
-    }
-
-    if (iface->enabled) {
-        state |= LACP_STATE_COL | LACP_STATE_DIST;
-    }
-
-    return state;
-}
-
-/* Given 'iface', populates 'priority' with data representing its LACP link
- * priority.  If two priority objects populated by this function are compared
- * using memcmp, the higher priority link will be less than the lower priority
- * link. */
-static void
-iface_get_lacp_priority(struct iface *iface, struct lacp_info *priority)
-{
-    uint16_t partner_priority, actor_priority;
-
-    /* Choose the lacp_info of the higher priority system by comparing their
-     * system priorities and mac addresses. */
-    actor_priority   = ntohs(iface->lacp_actor.sys_priority);
-    partner_priority = ntohs(iface->lacp_partner.sys_priority);
-    if (actor_priority < partner_priority) {
-        *priority = iface->lacp_actor;
-    } else if (partner_priority < actor_priority) {
-        *priority = iface->lacp_partner;
-    } else if (eth_addr_compare_3way(iface->lacp_actor.sysid,
-                                     iface->lacp_partner.sysid) < 0) {
-        *priority = iface->lacp_actor;
-    } else {
-        *priority = iface->lacp_partner;
-    }
-
-    /* Key and state are not used in priority comparisons. */
-    priority->key = 0;
-    priority->state = 0;
-}
-
 static void
 iface_send_packet(struct iface *iface, struct ofpbuf *packet)
 {
@@ -4690,11 +4381,6 @@ iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
     iface->delay_expires = LLONG_MAX;
     iface->netdev = NULL;
     iface->cfg = if_cfg;
-    iface_set_lacp_defaulted(iface);
-
-    if (port->lacp & LACP_ACTIVE) {
-        iface_set_lacp_expired(iface);
-    }
 
     shash_add_assert(&br->iface_by_name, iface->name, iface);
 
@@ -4723,7 +4409,11 @@ iface_destroy(struct iface *iface)
         bool del_active = port->active_iface == iface->port_ifidx;
         struct iface *del;
 
-        if (port->monitor) {
+        if (iface->port->lacp) {
+            lacp_slave_unregister(iface->port->lacp, iface);
+        }
+
+        if (port->monitor && iface->netdev) {
             netdev_monitor_remove(port->monitor, iface->netdev);
         }
 
@@ -4759,6 +4449,21 @@ iface_lookup(const struct bridge *br, const char *name)
     return shash_find_data(&br->iface_by_name, name);
 }
 
+static struct iface *
+iface_find(const char *name)
+{
+    const struct bridge *br;
+
+    LIST_FOR_EACH (br, node, &all_bridges) {
+        struct iface *iface = iface_lookup(br, name);
+
+        if (iface) {
+            return iface;
+        }
+    }
+    return NULL;
+}
+
 static struct iface *
 iface_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
 {
@@ -4879,6 +4584,19 @@ iface_delete_queues(unsigned int queue_id,
     }
 }
 
+static void
+iface_update_carrier(struct iface *iface, bool carrier)
+{
+    if (carrier == iface->up) {
+        return;
+    }
+
+    iface->up = carrier;
+    if (iface->port->lacp) {
+        lacp_slave_carrier_changed(iface->port->lacp, iface);
+    }
+}
+
 static void
 iface_update_qos(struct iface *iface, const struct ovsrec_qos *qos)
 {