X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=tests%2FMakefile;h=be8b0d552648438dae7e86818fd05e3122003ea0;hb=615bf3b3d2a8573ed6fb9ddc0055745e163ac999;hp=b084e95bae2e72ef954c763a4ae968701472f100;hpb=94e2e63b24a901da641f5c68cf46ce00681f5dd1;p=pintos-anon

diff --git a/tests/Makefile b/tests/Makefile
index b084e95..be8b0d5 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -1,4 +1,9 @@
-TESTS = threads p1-1 p1-2 p1-3 list stdlib userprog p2 vm filesys
+TESTS = threads p1 userprog p2 vm p3 filesys p4
+
+PATH := $(shell pwd)/../src/utils:$(PATH)
+
+all:
+	@echo "This Makefile has only \`check' targets."
 
 check:
 	$(MAKE) -C .. distclean
@@ -8,106 +13,66 @@ check:
 clean:
 	rm -rf $(TESTS)
 
-define prep-threads-grading
-endef
-
-define prep-userprog-grading
-$(MAKE) -C ../src/userprog -s
-$(MAKE) -C ../grading/userprog -s
-endef
-
-define prep-vm-grading
-$(MAKE) -C ../src/userprog -s
-$(MAKE) -C ../grading/vm -s
-endef
-
-define prep-filesys-grading
-$(MAKE) -C ../grading/filesys -s
-endef
-
-define prep-grading
-$(prep-$(PROJECT)-grading)
-endef
+SUBMAKEFLAGS = -s
 
 define mk-sandbox
-rm -rf $@ && mkdir -p $@/pintos && cp -R ../src $@/pintos
+rm -rf $@ && mkdir $@ && cp -R ../src $@/src
+cd $@/src && $(MAKE) clean $(SUBMAKEFLAGS)
 endef
 
 define run-tests
-cd $@ && ../../grading/$(PROJECT)/run-tests
+cd $@/src/$(PROJECT) && make check
+endef
+
+define compile
+cd $@/src/$(PROJECT) && make
 endef
 
 define clean
-rm -rf $@/pintos
+rm -rf $@
 endef
 
 define apply-patch
-(cd $@/pintos && patch -p0 -s) <
+(cd $@ && patch -p0)
 endef
 
-threads: PROJECT = threads
-threads::
-	$(mk-sandbox)
-	$(run-tests) -d alarm-single
-	$(clean)
+PROJECT = $@
 
-p1-1: PROJECT = threads
-p1-1::
-	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-1.patch
-	$(run-tests) -d alarm.*
-	$(clean)
-
-p1-2: PROJECT = threads
-p1-2::
-	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-2.patch
-	$(run-tests) -d join.*
-	$(clean)
-
-p1-3: PROJECT = threads
-p1-3::
+threads::
 	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-3.patch
-	$(run-tests) -d priority.*
+	$(compile)
+	$(run-tests) TESTS=tests/threads/alarm-single
 	$(clean)
 
-list: PROJECT = threads
-list stdlib::
+userprog vm filesys::
 	$(mk-sandbox)
-	cp ../src/tests/threads/$@.c $@/pintos/src/threads/test.c
-	$(MAKE) -C $@/pintos/src/threads -s
-	-(cd $@/pintos/src/threads/build && pintos -v run -q) | tee $@/output
-	grep -q '$@: PASS' $@/output && ! grep -q 'FAIL' $@/output
+	$(compile)
 	$(clean)
 
-userprog: PROJECT = userprog
-userprog::
-	$(prep-grading)
+p1: PROJECT = threads
+p1::
 	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-2.patch
-	echo '#define THREAD_JOIN_IMPLEMENTED 1' > $@/pintos/src/constants.h
-	$(run-tests) null
+	$(apply-patch) < ../solutions/p1.patch
+	$(run-tests)
 	$(clean)
 
 p2: PROJECT = userprog
 p2::
-	$(prep-grading)
 	$(mk-sandbox)
-	$(apply-patch) ../solutions/p2.patch
+	$(apply-patch) < ../solutions/p2.patch
 	$(run-tests)
 	$(clean)
 
-vm: PROJECT = vm
-vm::
-	$(prep-grading)
+p3: PROJECT = vm
+p3::
 	$(mk-sandbox)
-	$(MAKE) -C $@/pintos/src/vm -s
+	$(apply-patch) < ../solutions/p3.patch
+	$(run-tests)
 	$(clean)
 
-filesys: PROJECT = filesys
-filesys::
-	$(prep-grading)
+p4: PROJECT = filesys
+p4::
 	$(mk-sandbox)
-	$(MAKE) -C $@/pintos/src/filesys -s
+	$(apply-patch) < ../solutions/p4.patch
+	$(run-tests)
 	$(clean)