X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=tests%2FMakefile;h=5d53e286b71c3e49a657e19350003631d8dfba8f;hb=a26618d6f33f13301eb93ee26d6953c76019d879;hp=b084e95bae2e72ef954c763a4ae968701472f100;hpb=94e2e63b24a901da641f5c68cf46ce00681f5dd1;p=pintos-anon

diff --git a/tests/Makefile b/tests/Makefile
index b084e95..5d53e28 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -1,4 +1,9 @@
-TESTS = threads p1-1 p1-2 p1-3 list stdlib userprog p2 vm filesys
+TESTS = threads p1 userprog p2 vm p3 filesys p4 
+
+PATH := $(shell pwd)/../src/utils:$(PATH)
+
+all:
+	@echo "This Makefile has only \`check' targets."
 
 check:
 	$(MAKE) -C .. distclean
@@ -8,106 +13,55 @@ check:
 clean:
 	rm -rf $(TESTS)
 
-define prep-threads-grading
-endef
-
-define prep-userprog-grading
-$(MAKE) -C ../src/userprog -s
-$(MAKE) -C ../grading/userprog -s
-endef
-
-define prep-vm-grading
-$(MAKE) -C ../src/userprog -s
-$(MAKE) -C ../grading/vm -s
-endef
-
-define prep-filesys-grading
-$(MAKE) -C ../grading/filesys -s
+define mk-sandbox
+rm -rf $@ && mkdir $@ && cp -R ../src $@/src
+cd $@/src && $(MAKE) -s clean
 endef
 
-define prep-grading
-$(prep-$(PROJECT)-grading)
+define run-tests
+cd $@/src/$(PROJECT) && $(MAKE) check PINTOSOPTS=$(PINTOSOPTS)
 endef
 
-define mk-sandbox
-rm -rf $@ && mkdir -p $@/pintos && cp -R ../src $@/pintos
+define grade-tests
+cd $@/src/$(PROJECT) && $(MAKE) grade
+cd $@/src/$(PROJECT) && grep -q PERFECT build/grade
+cd $@/src/$(PROJECT) && grep -qv warning build/grade
 endef
 
-define run-tests
-cd $@ && ../../grading/$(PROJECT)/run-tests
+define compile
+cd $@/src/$(PROJECT) && $(MAKE)
 endef
 
 define clean
-rm -rf $@/pintos
+rm -rf $@
 endef
 
 define apply-patch
-(cd $@/pintos && patch -p0 -s) <
+(cd $@ && patch -p0) < ../solutions/$@.patch
 endef
 
-threads: PROJECT = threads
-threads::
-	$(mk-sandbox)
-	$(run-tests) -d alarm-single
-	$(clean)
-
-p1-1: PROJECT = threads
-p1-1::
-	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-1.patch
-	$(run-tests) -d alarm.*
-	$(clean)
-
-p1-2: PROJECT = threads
-p1-2::
-	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-2.patch
-	$(run-tests) -d join.*
-	$(clean)
+PROJECT = $@
+p1: PROJECT = threads
+p2: PROJECT = userprog
+p3: PROJECT = vm
+p4: PROJECT = filesys
 
-p1-3: PROJECT = threads
-p1-3::
+# Tests that just compile the provided code.
+threads::
 	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-3.patch
-	$(run-tests) -d priority.*
+	$(compile)
+	$(run-tests) TESTS=tests/threads/alarm-single
 	$(clean)
-
-list: PROJECT = threads
-list stdlib::
+userprog vm filesys::
 	$(mk-sandbox)
-	cp ../src/tests/threads/$@.c $@/pintos/src/threads/test.c
-	$(MAKE) -C $@/pintos/src/threads -s
-	-(cd $@/pintos/src/threads/build && pintos -v run -q) | tee $@/output
-	grep -q '$@: PASS' $@/output && ! grep -q 'FAIL' $@/output
+	$(compile)
 	$(clean)
 
-userprog: PROJECT = userprog
-userprog::
-	$(prep-grading)
+# Tests for the reference solutions.
+p2 p3 p4: PINTOSOPTS = --qemu
+p1 p2 p3 p4::
 	$(mk-sandbox)
-	$(apply-patch) ../solutions/p1-2.patch
-	echo '#define THREAD_JOIN_IMPLEMENTED 1' > $@/pintos/src/constants.h
-	$(run-tests) null
-	$(clean)
-
-p2: PROJECT = userprog
-p2::
-	$(prep-grading)
-	$(mk-sandbox)
-	$(apply-patch) ../solutions/p2.patch
+	$(apply-patch)
 	$(run-tests)
-	$(clean)
-
-vm: PROJECT = vm
-vm::
-	$(prep-grading)
-	$(mk-sandbox)
-	$(MAKE) -C $@/pintos/src/vm -s
-	$(clean)
-
-filesys: PROJECT = filesys
-filesys::
-	$(prep-grading)
-	$(mk-sandbox)
-	$(MAKE) -C $@/pintos/src/filesys -s
+	$(grade-tests)
 	$(clean)