X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fuserprog%2Fexception.c;h=4e9d28ffd321204709afaabc0ea22f023e53296f;hb=f2f8875638593bd5365cfd6a5ba7c9578e52322f;hp=24985514aa5882d832e1035afd1effa43b7b61cc;hpb=28cfcb0474595208626ae9984c9be99fd92f8159;p=pintos-anon diff --git a/src/userprog/exception.c b/src/userprog/exception.c index 2498551..4e9d28f 100644 --- a/src/userprog/exception.c +++ b/src/userprog/exception.c @@ -1,9 +1,9 @@ -#include "exception.h" +#include "userprog/exception.h" #include -#include "lib.h" -#include "gdt.h" -#include "interrupt.h" -#include "thread.h" +#include +#include "userprog/gdt.h" +#include "threads/interrupt.h" +#include "threads/thread.h" static void kill (struct intr_frame *); static void page_fault (struct intr_frame *); @@ -12,9 +12,10 @@ static void page_fault (struct intr_frame *); programs. In a real Unix-like OS, most of these interrupts would be - passed along to the user process in the form of signals, but - we don't implement signals. Instead, we'll make them simply - kill the user process. + passed along to the user process in the form of signals, as + described in [SV-386] 3-24 and 3-25, but we don't implement + signals. Instead, we'll make them simply kill the user + process. Page faults are an exception. Here they are treated the same way as other exceptions, but this will need to change to @@ -72,7 +73,7 @@ kill (struct intr_frame *f) case SEL_UCSEG: /* User's code segment, so it's a user exception, as we expected. Kill the user process. */ - printk ("%s: dying due to interrupt %#04x (%s).\n", + printf ("%s: dying due to interrupt %#04x (%s).\n", thread_name (thread_current ()), f->vec_no, intr_name (f->vec_no)); intr_dump_frame (f); @@ -89,7 +90,7 @@ kill (struct intr_frame *f) default: /* Some other code segment? Shouldn't happen. Panic the kernel. */ - printk ("Interrupt %#04x (%s) in unknown segment %04x\n", + printf ("Interrupt %#04x (%s) in unknown segment %04x\n", f->vec_no, intr_name (f->vec_no), f->cs); thread_exit (); } @@ -136,7 +137,7 @@ page_fault (struct intr_frame *f) /* To implement virtual memory, delete the rest of the function body, and replace it with code that brings in the page to which fault_addr refers. */ - printk ("Page fault at %08"PRIx32": %s error %s page in %s context.\n", + printf ("Page fault at %08"PRIx32": %s error %s page in %s context.\n", fault_addr, not_present ? "not present" : "rights violation", write ? "writing" : "reading",