X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fui%2Fgui%2Fpsppire-dict.c;h=239f3ce2f3b08eb8ee47653b05884a0b4e2919c7;hb=f790dbda9d498eef9c9c0a49078adbeecf768d56;hp=9e2190b2909e181475309ed1c58e10b3ce304872;hpb=45fb19608ffa759f7a0221878d1a9a72c6727dc7;p=pspp diff --git a/src/ui/gui/psppire-dict.c b/src/ui/gui/psppire-dict.c index 9e2190b290..239f3ce2f3 100644 --- a/src/ui/gui/psppire-dict.c +++ b/src/ui/gui/psppire-dict.c @@ -1,5 +1,5 @@ /* PSPPIRE - a graphical user interface for PSPP. - Copyright (C) 2004, 2006, 2007, 2009 Free Software Foundation + Copyright (C) 2004, 2006, 2007, 2009, 2010, 2011, 2012 Free Software Foundation This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -15,32 +15,34 @@ along with this program. If not, see . */ #include + +#include "ui/gui/psppire-dict.h" + #include #include - #include -#include - -#include "psppire-var-ptr.h" -#include "psppire-dict.h" -#include -#include -#include -#include -#include - -#include "helper.h" -#include "message-dialog.h" +#include "data/dictionary.h" +#include "data/identifier.h" +#include "data/missing-values.h" +#include "data/value-labels.h" +#include "data/variable.h" +#include "libpspp/i18n.h" +#include "libpspp/message.h" +#include "ui/gui/helper.h" +#include "ui/gui/psppire-marshal.h" +#include "ui/gui/psppire-var-ptr.h" + +#include +#define _(msgid) gettext (msgid) +#define N_(msgid) msgid enum { BACKEND_CHANGED, VARIABLE_CHANGED, - VARIABLE_RESIZED, VARIABLE_INSERTED, VARIABLE_DELETED, - VARIABLE_DISPLAY_WIDTH_CHANGED, WEIGHT_CHANGED, FILTER_CHANGED, @@ -52,7 +54,7 @@ enum { /* --- prototypes --- */ static void psppire_dict_class_init (PsppireDictClass *class); static void psppire_dict_init (PsppireDict *dict); -static void psppire_dict_finalize (GObject *object); +static void psppire_dict_dispose (GObject *object); static void dictionary_tree_model_init (GtkTreeModelIface *iface); @@ -111,7 +113,7 @@ psppire_dict_class_init (PsppireDictClass *class) parent_class = g_type_class_peek_parent (class); - object_class->finalize = psppire_dict_finalize; + object_class->dispose = psppire_dict_dispose; signals [BACKEND_CHANGED] = g_signal_new ("backend-changed", @@ -125,20 +127,23 @@ psppire_dict_class_init (PsppireDictClass *class) signals [VARIABLE_CHANGED] = - g_signal_new ("variable_changed", + g_signal_new ("variable-changed", G_TYPE_FROM_CLASS (class), G_SIGNAL_RUN_FIRST, 0, NULL, NULL, - g_cclosure_marshal_VOID__INT, + psppire_marshal_VOID__INT_UINT_POINTER, G_TYPE_NONE, - 1, - G_TYPE_INT); + 3, + G_TYPE_INT, + G_TYPE_UINT, + G_TYPE_POINTER + ); signals [VARIABLE_INSERTED] = - g_signal_new ("variable_inserted", + g_signal_new ("variable-inserted", G_TYPE_FROM_CLASS (class), G_SIGNAL_RUN_FIRST, 0, @@ -155,37 +160,13 @@ psppire_dict_class_init (PsppireDictClass *class) G_SIGNAL_RUN_FIRST, 0, NULL, NULL, - psppire_marshal_VOID__INT_INT_INT, + psppire_marshal_VOID__POINTER_INT_INT, G_TYPE_NONE, 3, - G_TYPE_INT, - G_TYPE_INT, - G_TYPE_INT); - - - signals [VARIABLE_RESIZED] = - g_signal_new ("dict-size-changed", - G_TYPE_FROM_CLASS (class), - G_SIGNAL_RUN_FIRST, - 0, - NULL, NULL, - psppire_marshal_VOID__INT_INT, - G_TYPE_NONE, - 2, + G_TYPE_POINTER, G_TYPE_INT, G_TYPE_INT); - signals [VARIABLE_DISPLAY_WIDTH_CHANGED] = - g_signal_new ("variable-display-width-changed", - G_TYPE_FROM_CLASS (class), - G_SIGNAL_RUN_FIRST, - 0, - NULL, NULL, - g_cclosure_marshal_VOID__INT, - G_TYPE_NONE, - 1, - G_TYPE_INT); - signals [WEIGHT_CHANGED] = g_signal_new ("weight-changed", @@ -223,13 +204,13 @@ psppire_dict_class_init (PsppireDictClass *class) } static void -psppire_dict_finalize (GObject *object) +psppire_dict_dispose (GObject *object) { PsppireDict *d = PSPPIRE_DICT (object); - dict_destroy (d->dict); + dict_set_callbacks (d->dict, NULL, NULL); - G_OBJECT_CLASS (parent_class)->finalize (object); + G_OBJECT_CLASS (parent_class)->dispose (object); } /* Pass on callbacks from src/data/dictionary, as @@ -244,22 +225,17 @@ addcb (struct dictionary *d, int idx, void *pd) } static void -delcb (struct dictionary *d, int dict_idx, int case_idx, int width, void *pd) +delcb (struct dictionary *d, const struct variable *var, + int dict_idx, int case_idx, void *pd) { g_signal_emit (pd, signals [VARIABLE_DELETED], 0, - dict_idx, case_idx, width ); -} - -static void -mutcb (struct dictionary *d, int idx, void *pd) -{ - g_signal_emit (pd, signals [VARIABLE_CHANGED], 0, idx); + var, dict_idx, case_idx); } static void -resize_cb (struct dictionary *d, int idx, int old_width, void *pd) +mutcb (struct dictionary *d, int idx, unsigned int what, const struct variable *oldvar, void *pd) { - g_signal_emit (pd, signals [VARIABLE_RESIZED], 0, idx, old_width); + g_signal_emit (pd, signals [VARIABLE_CHANGED], 0, idx, what, oldvar); } static void @@ -280,24 +256,14 @@ split_changed_callback (struct dictionary *d, void *pd) g_signal_emit (pd, signals [SPLIT_CHANGED], 0); } -static void -variable_display_width_callback (struct dictionary *d, int idx, void *pd) -{ - g_signal_emit (pd, signals [VARIABLE_DISPLAY_WIDTH_CHANGED], 0, idx); -} - - - static const struct dict_callbacks gui_callbacks = { addcb, delcb, mutcb, - resize_cb, weight_changed_callback, filter_changed_callback, - split_changed_callback, - variable_display_width_callback + split_changed_callback }; static void @@ -345,34 +311,56 @@ psppire_dict_replace_dictionary (PsppireDict *dict, struct dictionary *d) } -/* Returns a valid name for a new variable in DICT. - The return value is statically allocated */ -static gchar * -auto_generate_var_name (PsppireDict *dict) +/* Stores a valid name for a new variable in DICT into the SIZE bytes in NAME. + Returns true if successful, false if SIZE is insufficient. */ +bool +psppire_dict_generate_name (const PsppireDict *dict, char *name, size_t size) { - gint d = 0; - static gchar name[10]; + gint d; - while (g_snprintf (name, 10, "VAR%05d",d++), - psppire_dict_lookup_var (dict, name)) - ; + for (d = 1; ; d++) + { + int len; + + /* TRANSLATORS: This string must be a valid variable name. That means: + - The string must be at most 64 bytes (not characters) long. + - The string may not contain whitespace. + - The first character may not be '$' + - The first character may not be a digit + - The final character may not be '.' or '_' + */ + len = snprintf (name, size, _("Var%04d"), d); + if (len + 1 >= size) + return false; + + if (psppire_dict_lookup_var (dict, name) == NULL) + return true; + } return name; } -/* Insert a new variable at posn IDX, with the name NAME. +/* Insert a new variable at posn IDX, with the name NAME, and return the + new variable. If NAME is null, then a name will be automatically assigned. */ -void +struct variable * psppire_dict_insert_variable (PsppireDict *d, gint idx, const gchar *name) { - struct variable *var ; - g_return_if_fail (idx >= 0); - g_return_if_fail (d); - g_return_if_fail (PSPPIRE_IS_DICT (d)); + struct variable *var; + char tmpname[64]; + + g_return_val_if_fail (idx >= 0, NULL); + g_return_val_if_fail (d, NULL); + g_return_val_if_fail (PSPPIRE_IS_DICT (d), NULL); + + if (name == NULL) + { + if (!psppire_dict_generate_name (d, tmpname, sizeof tmpname)) + g_return_val_if_reached (NULL); - if ( ! name ) - name = auto_generate_var_name (d); + name = tmpname; + } d->disable_insert_signal = TRUE; @@ -383,6 +371,8 @@ psppire_dict_insert_variable (PsppireDict *d, gint idx, const gchar *name) d->disable_insert_signal = FALSE; g_signal_emit (d, signals[VARIABLE_INSERTED], 0, idx); + + return var; } /* Delete N variables beginning at FIRST */ @@ -415,7 +405,7 @@ psppire_dict_set_name (PsppireDict* d, gint idx, const gchar *name) g_assert (d); g_assert (PSPPIRE_IS_DICT (d)); - if ( ! var_is_valid_name (name, false)) + if ( ! dict_id_is_valid (d->dict, name, false)) return FALSE; if ( idx < dict_get_var_cnt (d->dict)) @@ -517,13 +507,13 @@ gboolean psppire_dict_check_name (const PsppireDict *dict, const gchar *name, gboolean report) { - if ( ! var_is_valid_name (name, report ) ) + if ( ! dict_id_is_valid (dict->dict, name, report ) ) return FALSE; if (psppire_dict_lookup_var (dict, name)) { if ( report ) - msg (ME,"Duplicate variable name."); + msg (ME, _("Duplicate variable name.")); return FALSE; } @@ -538,22 +528,6 @@ psppire_dict_get_next_value_idx (const PsppireDict *dict) } -void -psppire_dict_resize_variable (PsppireDict *d, const struct variable *pv, - gint old_size, gint new_size) -{ - g_return_if_fail (d); - g_return_if_fail (d->dict); - - if ( old_size == new_size ) - return ; - - g_signal_emit (d, signals [VARIABLE_RESIZED], 0, - var_get_dict_index (pv), - new_size - old_size ); -} - - /* Tree Model Stuff */ static GtkTreeModelFlags tree_model_get_flags (GtkTreeModel *model); @@ -651,6 +625,9 @@ tree_model_column_type (GtkTreeModel *model, gint index) case DICT_TVM_COL_VAR: return PSPPIRE_VAR_PTR_TYPE; break; + case DICT_TVM_COL_LABEL: + return G_TYPE_STRING; + break; default: g_return_val_if_reached ((GType)0); break; @@ -703,11 +680,11 @@ tree_model_iter_next (GtkTreeModel *model, GtkTreeIter *iter) struct variable *var; gint idx; - g_return_val_if_fail (iter->stamp == dict->stamp, FALSE); - if ( iter == NULL || iter->user_data == NULL) return FALSE; + g_return_val_if_fail (iter->stamp == dict->stamp, FALSE); + var = iter->user_data; idx = var_get_dict_index (var); @@ -825,7 +802,7 @@ gboolean psppire_dict_rename_var (PsppireDict *dict, struct variable *v, const gchar *name) { - if ( ! var_is_valid_name (name, false)) + if ( ! dict_id_is_valid (dict->dict, name, false)) return FALSE; /* Make sure no other variable has this name */ @@ -857,7 +834,7 @@ psppire_dict_dump (const PsppireDict *dict) { const struct variable *v = psppire_dict_get_variable (dict, i); int di = var_get_dict_index (v); - g_print ("\"%s\" idx=%d, fv=%d\n", + g_print ("`%s' idx=%d, fv=%d\n", var_get_name(v), di, var_get_case_index(v));