X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fui%2Fgui%2Fpsppire-dialog-action-means.c;h=6610f595563a561c077506d6a0c2beb3b503055e;hb=fc6620099bbc53762095569d5356b67a81a85402;hp=64d0f32876502f342b6ff10c43f23993dbf32641;hpb=ce0e898dc6506c5d980e803e7bdcd27a1752fca6;p=pspp

diff --git a/src/ui/gui/psppire-dialog-action-means.c b/src/ui/gui/psppire-dialog-action-means.c
index 64d0f32876..6610f59556 100644
--- a/src/ui/gui/psppire-dialog-action-means.c
+++ b/src/ui/gui/psppire-dialog-action-means.c
@@ -47,22 +47,21 @@ generate_syntax (PsppireDialogAction *act)
 
   for (l = 0; l < layer->n_layers; ++l)
     {
-      gboolean ok;
       GtkTreeIter iter;
-      PsppireVarView *vv = PSPPIRE_VAR_VIEW (layer->var_view);
-      psppire_var_view_set_current_model (vv, l);
-      g_string_append (string, "\n\tBY");
-      for (ok = psppire_var_view_get_iter_first (vv, &iter);
-	   ok;
-	   ok = psppire_var_view_get_iter_next (vv, &iter))
+
+      GtkTreeModel *m = psppire_means_layer_get_model_n (layer, l);
+      gboolean ok = gtk_tree_model_get_iter_first (m, &iter);
+      if (ok)
+	g_string_append (string, "\n\tBY");
+      for (; ok; ok = gtk_tree_model_iter_next (m, &iter))
 	  {
-	    const struct variable *var = psppire_var_view_get_variable (vv, 0, &iter);
+	    const struct variable *var = psppire_var_view_get_var_from_model (m, 0, &iter);
 	    g_string_append (string, " ");
 	    g_string_append (string, var_get_name (var));
 	  }
     }
 
-  g_string_append (string, ".");
+  g_string_append (string, ".\n");
   text = string->str;
 
   g_string_free (string, FALSE);
@@ -98,35 +97,43 @@ psppire_dialog_action_means_activate (GtkAction *a)
   PsppireDialogAction *pda = PSPPIRE_DIALOG_ACTION (a);
   PsppireDialogActionMeans *act = PSPPIRE_DIALOG_ACTION_MEANS (a);
 
-  GtkBuilder *xml = builder_new ("means.ui");
+  GHashTable *thing = psppire_dialog_action_get_pointer (pda);
+  GtkBuilder *xml = g_hash_table_lookup (thing, a);
+  if (!xml)
+    {
+      xml = builder_new ("means.ui");
+      g_hash_table_insert (thing, a, xml);
+    }
 
-  GtkWidget *vb =   get_widget_assert   (xml, "alignment3");
+  GtkWidget *vb =   get_widget_assert (xml, "alignment3");
+  GtkWidget *selector = get_widget_assert (xml, "layer-selector");
+  
   act->layer = psppire_means_layer_new ();
   gtk_container_add (GTK_CONTAINER (vb), act->layer);
   gtk_widget_show (act->layer);
 
-  pda->dialog = get_widget_assert   (xml, "means-dialog");
-  pda->source = get_widget_assert   (xml, "all-variables");
-  act->variables = get_widget_assert   (xml, "stat-variables");
+  pda->dialog = get_widget_assert (xml, "means-dialog");
+  pda->source = get_widget_assert (xml, "all-variables");
+  act->variables = get_widget_assert (xml, "stat-variables");
 
   g_object_set (pda->source,
 		"predicate", var_is_numeric,
 		NULL);
 
-  psppire_means_layer_set_source (PSPPIRE_MEANS_LAYER (act->layer), pda->source);
+  g_object_set (selector,
+		"dest-widget", act->layer,
+		NULL);
 
   psppire_dialog_action_set_valid_predicate (pda, (void *) dialog_state_valid);
   psppire_dialog_action_set_refresh (pda, dialog_refresh);
 
   PSPPIRE_DIALOG_ACTION_CLASS (psppire_dialog_action_means_parent_class)->activate (pda);
-
-  g_object_unref (xml);
 }
 
 static void
 psppire_dialog_action_means_class_init (PsppireDialogActionMeansClass *class)
 {
-  GTK_ACTION_CLASS (class)->activate = psppire_dialog_action_means_activate;
+  psppire_dialog_action_set_activation (class, psppire_dialog_action_means_activate);
 
   PSPPIRE_DIALOG_ACTION_CLASS (class)->generate_syntax = generate_syntax;
 }