X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fui%2Fgui%2Fmemorandum.txt;h=c2cd66b6b7280e6206efe8c95acca90c7c660eee;hb=e94442a3b00c1f22952586cc26b7be60617b93e1;hp=d316c3a35cb05991f93c04ba4962a1e2a2957a81;hpb=9c52158826c0f171e3d000ccbf07632c412e65e1;p=pspp
diff --git a/src/ui/gui/memorandum.txt b/src/ui/gui/memorandum.txt
index d316c3a35c..c2cd66b6b7 100644
--- a/src/ui/gui/memorandum.txt
+++ b/src/ui/gui/memorandum.txt
@@ -9,10 +9,8 @@ How to add a new dialog to Psppire
Before you start.
-1. You will need to install Glade version 3.8.4 --- ANY OTHER VERSION
-IS UNLIKELY TO WORK --- I know that 3.18.x does not! If your
-distro doesn't have this version, you will need to download it and
-build it from source.
+1. You will need to install Glade (but see the important note
+ about which version at the end of this document!
@@ -33,7 +31,7 @@ build it from source.
Having done the above, you should be able to edit an existing dialog
definition, thus:
- glade-3 src/ui/gui/descriptives.ui
+ glade src/ui/gui/descriptives.ui
You will probably get a lot of Gtk-Warnings/Criticals most of them
are harmless.
@@ -113,7 +111,7 @@ this:
+---------------+-----------------+----------------+-----------------+
In the second panel from the left, we might want a selector button.
-However, we don't want to to fill the entire panel.
+However, we don't want to fill the entire panel.
So we put it in inside a GtkAlignment. From the "Containers" category
click "Alignment". and then the panel. Such a widget is of course
not visible, but you will note its presence from the widget hierarchy
@@ -171,7 +169,7 @@ Displaying the Dialog box in Psppire
1. Define a new PsppireDialogAction Class
Create a new object class derived from PsppireDialogAction (note that
-PsppireDialogAction itself derives from GtkAction). It's probably
+PsppireDialogAction itself implements GAction). It's probably
best if you use an existing example as a template. The minimum you
require is:
@@ -193,7 +191,7 @@ dialog_state_valid (gpointer data)
PsppireDialogActionFoobar *ud = PSPPIRE_DIALOG_ACTION_FOOBAR (data);
// This function is a predicate to determine if the dialog box has
- // been set to a state where is is appropriate to click OK /
+ // been set to a state where it is appropriate to click OK /
// Paste.
// If it returns FALSE, the OK and PASTE buttons are insensitive
@@ -213,9 +211,9 @@ refresh (PsppireDialogAction *rd_)
// This function is called when the menuitem is activated.
-// It is what pops up the dialog
+// It is what pops up the dialog
static void
-psppire_dialog_action_foobar_activate (GtkAction *a)
+psppire_dialog_action_foobar_activate (GAction *a)
{
PsppireDialogAction *pda = PSPPIRE_DIALOG_ACTION (a);
PsppireDialogActionFoobar *act = PSPPIRE_DIALOG_ACTION_FOOBAR (a);
@@ -246,7 +244,7 @@ psppire_dialog_action_foobar_activate (GtkAction *a)
static void
psppire_dialog_action_foobar_class_init (PsppireDialogActionFoobarClass *class)
{
- GtkActionClass *action_class = GTK_ACTION_CLASS (class);
+ GActionClass *action_class = GTK_ACTION_CLASS (class);
action_class->activate = psppire_dialog_action_foobar_activate;
PSPPIRE_DIALOG_ACTION_CLASS (class)->generate_syntax = generate_syntax;
@@ -315,6 +313,34 @@ src/ui/gui/automake.mk and to rerun make ; make install
+Note! Currently (as of commit fe7682b3c3d36cf9ba3e867588e5b808af833262 )
+psppire is in a transitional phase. Our .ui files come in two mutually
+incompatible varieties. The older variety can be identified by a
+string similar to:
+
+
+
+
+
+To edit these files you will need to install Glade version 3.8.4 ---
+ANY OTHER VERSION IS UNLIKELY TO WORK --- I know that 3.18.x does
+not! If your distro doesn't have this version, you will need to
+download it and build it from source.
+
+
+The newer ones contain the string:
+
+
+
+
+
+Like the string suggests Glade version 3.18.x or later will probably
+be ok for these files.
+
+Hopefully the older style .ui files will gradually be converted to new
+style ones.
+
+
That's about it, I think. Did I forget anything?