X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fui%2Fgui%2Fhelper.c;h=9cbd6f0f2a9d9bf6991da032358d344e25d505a6;hb=c86f5b8a45cca158b46a4fe3b48280e88ce9aba1;hp=22072578d737fcc75333cbca70038adea29fa274;hpb=43b1296aafe7582e7dbe6c2b6a8b478d7d9b0fcf;p=pspp diff --git a/src/ui/gui/helper.c b/src/ui/gui/helper.c index 22072578d7..9cbd6f0f2a 100644 --- a/src/ui/gui/helper.c +++ b/src/ui/gui/helper.c @@ -20,25 +20,33 @@ */ #include +#include + #include #include "helper.h" #include "message-dialog.h" #include #include #include +#include #include #include #include #include +#include #include #include +#include #include #include #include "psppire-data-store.h" +#include +#include "output-viewer.h" +#include "xalloc.h" #include @@ -83,7 +91,7 @@ text_to_value (const gchar *text, union value *v, } msg_disable (); - ok = data_in (ss_cstr (text), format.type, 0, 0, + ok = data_in (ss_cstr (text), LEGACY_NATIVE, format.type, 0, 0, v, fmt_var_width (&format)); msg_enable (); @@ -101,7 +109,7 @@ get_widget_assert (GladeXML *xml, const gchar *name) w = glade_xml_get_widget (xml, name); if ( !w ) - g_warning ("Widget \"%s\" could not be found\n", name); + g_critical ("Widget \"%s\" could not be found\n", name); return w; } @@ -162,27 +170,64 @@ extern struct dataset *the_dataset; extern struct source_stream *the_source_stream; extern PsppireDataStore *the_data_store; +/* Lazy casereader callback function used by execute_syntax. */ +static struct casereader * +create_casereader_from_data_store (void *data_store_) +{ + PsppireDataStore *data_store = data_store_; + return psppire_data_store_get_reader (data_store); +} + gboolean execute_syntax (struct getl_interface *sss) { - gboolean status; struct lexer *lexer; - - struct casereader *reader = psppire_data_store_get_reader (the_data_store); - + gboolean retval = TRUE; + + struct casereader *reader; + size_t value_cnt; + casenumber case_cnt; + unsigned long int lazy_serial; + + /* When the user executes a number of snippets of syntax in a + row, none of which read from the active file, the GUI becomes + progressively less responsive. The reason is that each syntax + execution encapsulates the active file data in another + datasheet layer. The cumulative effect of having a number of + layers of datasheets wastes time and space. + + To solve the problem, we use a "lazy casereader", a wrapper + around the casereader obtained from the data store, that + only actually instantiates that casereader when it is + needed. If the data store casereader is never needed, then + it is reused the next time syntax is run, without wrapping + it in another layer. */ + value_cnt = psppire_data_store_get_value_count (the_data_store); + case_cnt = psppire_data_store_get_case_count (the_data_store); + reader = lazy_casereader_create (value_cnt, case_cnt, + create_casereader_from_data_store, + the_data_store, &lazy_serial); proc_set_active_file_data (the_dataset, reader); g_return_val_if_fail (proc_has_active_file (the_dataset), FALSE); lexer = lex_create (the_source_stream); - getl_append_source (the_source_stream, sss); + getl_append_source (the_source_stream, sss, GETL_BATCH, ERRMODE_CONTINUE); for (;;) { - int result = cmd_parse (lexer, the_dataset); + enum cmd_result result = cmd_parse (lexer, the_dataset); + + if ( cmd_result_is_failure (result)) + { + retval = FALSE; + if ( source_stream_current_error_mode (the_source_stream) + == ERRMODE_STOP ) + break; + } - if (result == CMD_EOF || result == CMD_FINISH) + if ( result == CMD_EOF || result == CMD_FINISH) break; } @@ -190,21 +235,108 @@ execute_syntax (struct getl_interface *sss) lex_destroy (lexer); - /* GUI syntax needs this implicit EXECUTE command at the end of - every script. Otherwise commands like GET could leave the GUI - without a datasheet. */ - status = proc_execute (the_dataset); - psppire_dict_replace_dictionary (the_data_store->dict, dataset_dict (the_dataset)); - { - PsppireCaseFile *pcf = psppire_case_file_new (dataset_source (the_dataset)); + reader = proc_extract_active_file_data (the_dataset); + if (!lazy_casereader_destroy (reader, lazy_serial)) + psppire_data_store_set_case_file (the_data_store, + psppire_case_file_new (reader)); + + som_flush (); - psppire_data_store_set_case_file (the_data_store, pcf); - } + reload_the_viewer (); + + return retval; +} + + + +#ifdef G_ENABLE_DEBUG +# define g_marshal_value_peek_int(v) g_value_get_int (v) +#else +# define g_marshal_value_peek_int(v) (v)->data[0].v_int +#endif + + +/* VOID:INT,INT,INT */ +void +marshaller_VOID__INT_INT_INT (GClosure *closure, + GValue *return_value, + guint n_param_values, + const GValue *param_values, + gpointer invocation_hint, + gpointer marshal_data) +{ + typedef void (*GMarshalFunc_VOID__INT_INT_INT) (gpointer data1, + gint arg_1, + gint arg_2, + gint arg_3, + gpointer data2); + register GMarshalFunc_VOID__INT_INT_INT callback; + register GCClosure *cc = (GCClosure*) closure; + register gpointer data1, data2; + + g_return_if_fail (n_param_values == 4); + + if (G_CCLOSURE_SWAP_DATA (closure)) + { + data1 = closure->data; + data2 = g_value_peek_pointer (param_values + 0); + } + else + { + data1 = g_value_peek_pointer (param_values + 0); + data2 = closure->data; + } + callback = (GMarshalFunc_VOID__INT_INT_INT) (marshal_data ? marshal_data : cc->callback); + + callback (data1, + g_marshal_value_peek_int (param_values + 1), + g_marshal_value_peek_int (param_values + 2), + g_marshal_value_peek_int (param_values + 3), + data2); +} + +/* Create a deep copy of SRC */ +GtkListStore * +clone_list_store (const GtkListStore *src) +{ + GtkTreeIter src_iter; + gboolean ok; + gint i; + const gint n_cols = gtk_tree_model_get_n_columns (GTK_TREE_MODEL (src)); + GType *types = g_malloc (sizeof (*types) * n_cols); + + int row = 0; + GtkListStore *dest; + + for (i = 0 ; i < n_cols; ++i ) + types[i] = gtk_tree_model_get_column_type (GTK_TREE_MODEL (src), i); + + dest = gtk_list_store_newv (n_cols, types); + + for (ok = gtk_tree_model_get_iter_first (GTK_TREE_MODEL (src), + &src_iter); + ok; + ok = gtk_tree_model_iter_next (GTK_TREE_MODEL (src), &src_iter)) + { + GtkTreeIter dest_iter; + gtk_list_store_append (dest, &dest_iter); + + for (i = 0 ; i < n_cols; ++i ) + { + GValue val = {0}; + + gtk_tree_model_get_value (GTK_TREE_MODEL (src), &src_iter, i, &val); + gtk_list_store_set_value (dest, &dest_iter, i, &val); + + g_value_unset (&val); + } + row++; + } - return status; + return dest; }