X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Ft-test.q;h=b33c5c2824185ab985a96877bad50e96a358a116;hb=4fdeb2145d081ff1b84e3f6c99f9d1c048c0d64a;hp=376477c3f52fbf48877204c40f727fe9935c4324;hpb=92bfefccd465052e492f669ce561aa25b0110283;p=pspp-builds.git

diff --git a/src/t-test.q b/src/t-test.q
index 376477c3..b33c5c28 100644
--- a/src/t-test.q
+++ b/src/t-test.q
@@ -16,8 +16,8 @@
 
    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
-   02111-1307, USA. */
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301, USA. */
 
 #include <config.h>
 #include <gsl/gsl_cdf.h>
@@ -27,7 +27,9 @@
 #include <math.h>
 #include "alloc.h"
 #include "str.h"
+#include "case.h"
 #include "command.h"
+#include "dictionary.h"
 #include "lexer.h"
 #include "error.h"
 #include "magic.h"
@@ -38,14 +40,15 @@
 #include "var.h"
 #include "vfm.h"
 #include "hash.h"
-#include "t-test.h"
+#include "group_proc.h"
 #include "casefile.h"
 #include "levene.h"
+/* (headers) */
 
 /* (specification)
    "T-TEST" (tts_):
      +groups=custom;
-     +testval=double;
+     testval=double;
      variables=varlist("PV_NO_SCRATCH | PV_NUMERIC");
      pairs=custom;
      +missing=miss:!analysis/listwise,
@@ -65,12 +68,34 @@ static is_missing_func value_is_missing;
 /* Variable for the GROUPS subcommand, if given. */
 static struct variable *indep_var;
 
-/* GROUPS: Number of values specified by the user; the values
-   specified if any. */
+enum comparison
+  {
+    CMP_LE = -2,
+    CMP_EQ = 0,
+  };
+
+struct group_properties
+{
+  /* The comparison criterion */
+  enum comparison criterion;
+
+  /* The width of the independent variable */
+  int indep_width ;  
+
+  union {
+    /* The value of the independent variable at which groups are determined to 
+       belong to one group or the other */
+    double critical_value;
+    
+
+    /* The values of the independent variable for each group */
+    union value g_value[2];
+  } v ;
+
+};
+
 
-static int n_group_values;
-static union value groups_values[2];
-static enum comparison criteria[2];
+static struct group_properties gp ;
 
 
 
@@ -199,9 +224,6 @@ static int  group_calc (const struct ccase *, struct cmd_t_test *);
 static void group_postcalc (struct cmd_t_test *);
 
 
-static int compare_var_name (const void *a_, const void *b_, void *v_ UNUSED);
-static unsigned hash_var_name (const void *a_, void *v_ UNUSED);
-
 static void calculate(const struct casefile *cf, void *_mode);
 
 static  int mode;
@@ -210,12 +232,21 @@ static struct cmd_t_test cmd;
 
 static int bad_weight_warn;
 
+
+static int compare_group_binary(const struct group_statistics *a, 
+				const struct group_statistics *b, 
+				const struct group_properties *p);
+
+
+static unsigned  hash_group_binary(const struct group_statistics *g, 
+				   const struct group_properties *p);
+
+
+
 int
 cmd_t_test(void)
 {
 
-
-
   if ( !parse_t_test(&cmd) )
     return CMD_FAILURE;
 
@@ -233,6 +264,7 @@ cmd_t_test(void)
 	msg(SE, 
 	    _("TESTVAL, GROUPS and PAIRS subcommands are mutually exclusive.")
 	    );
+        free_t_test(&cmd);
 	return CMD_FAILURE;
       }
   }
@@ -249,6 +281,7 @@ cmd_t_test(void)
       if (cmd.sbc_variables) 
 	{
 	  msg(SE, _("VARIABLES subcommand is not appropriate with PAIRS"));
+          free_t_test(&cmd);
 	  return CMD_FAILURE;
 	}
       else
@@ -261,7 +294,7 @@ cmd_t_test(void)
 	  struct hsh_table *hash;
 	  struct variable *v;
 
-	  hash=hsh_create(n_pairs,compare_var_name,hash_var_name,0,0);
+	  hash = hsh_create (n_pairs, compare_var_names, hash_var_name, 0, 0);
 
 	  for (i=0; i < n_pairs; ++i)
 	    {
@@ -286,6 +319,7 @@ cmd_t_test(void)
   else if ( !cmd.sbc_variables) 
     {
       msg(SE, _("One or more VARIABLES must be specified."));
+      free_t_test(&cmd);
       return CMD_FAILURE;
     }
 
@@ -306,20 +340,23 @@ cmd_t_test(void)
 
   if ( mode == T_IND_SAMPLES) 
     {
-      int i;
+      int v;
       /* Destroy any group statistics we created */
-      for (i= 0 ; i < cmd.n_variables ; ++i ) 
+      for (v = 0 ; v < cmd.n_variables ; ++v ) 
 	{
-	  free(cmd.v_variables[i]->p.t_t.gs);
+	  struct group_proc *grpp = group_proc_get (cmd.v_variables[v]);
+	  hsh_destroy (grpp->group_hash);
 	}
     }
     
+  free_t_test(&cmd);
   return CMD_SUCCESS;
 }
 
 static int
 tts_custom_groups (struct cmd_t_test *cmd UNUSED)
 {
+  int n_group_values=0;
 
   lex_match('=');
 
@@ -349,41 +386,56 @@ tts_custom_groups (struct cmd_t_test *cmd UNUSED)
     {
       if (indep_var->type == NUMERIC)
 	{
-	  groups_values[0].f = 1;
-	  groups_values[1].f = 2;
-	  criteria[0] = criteria[1] = CMP_EQ;
+	  gp.v.g_value[0].f = 1;
+	  gp.v.g_value[1].f = 2;
+
+	  gp.criterion = CMP_EQ;
+	  
 	  n_group_values = 2;
+
 	  return 1;
 	}
       else
 	{
-	  msg (SE, _("When applying GROUPS to a string variable, at "
-		     "least one value must be specified."));
+	  msg (SE, _("When applying GROUPS to a string variable, two "
+		     "values must be specified."));
 	  return 0;
 	}
     }
 
-  if (!parse_value (&groups_values[0],indep_var->type))
+  if (!parse_value (&gp.v.g_value[0], indep_var->type))
       return 0;
 
   lex_match (',');
   if (lex_match (')'))
     {
-      criteria[0] =  CMP_LE;
-      criteria[1] =  CMP_GT;
-      groups_values[1] = groups_values[0];
+      if (indep_var->type != NUMERIC)
+	{
+
+	  msg (SE, _("When applying GROUPS to a string variable, two "
+		     "values must be specified."));
+	  return 0;
+	}
+      gp.criterion = CMP_LE;
+      gp.v.critical_value = gp.v.g_value[0].f;
+
       n_group_values = 1;
       return 1;
     }
 
-  if (!parse_value (&groups_values[1],indep_var->type))
+  if (!parse_value (&gp.v.g_value[1], indep_var->type))
     return 0;
-  
+
   n_group_values = 2;
   if (!lex_force_match (')'))
     return 0;
 
-  criteria[0] = criteria[1] = CMP_EQ;
+  if ( n_group_values == 2 ) 
+    gp.criterion = CMP_EQ ;
+  else
+    gp.criterion = CMP_LE ;
+
+
   return 1;
 }
 
@@ -514,6 +566,7 @@ tts_custom_pairs (struct cmd_t_test *cmd UNUSED)
 
   n_pairs+=n_pairs_local;
 
+  free (vars);
   return 1;
 }
 
@@ -556,6 +609,7 @@ void ssbox_independent_samples_init(struct ssbox *this,
 void ssbox_paired_init(struct ssbox *this,
 			   struct cmd_t_test *cmd);
 
+
 /* Factory to create an ssbox */
 void 
 ssbox_create(struct ssbox *ssb, struct cmd_t_test *cmd, int mode)
@@ -577,6 +631,7 @@ ssbox_create(struct ssbox *ssb, struct cmd_t_test *cmd, int mode)
 }
 
 
+
 /* Despatcher for the populate method */
 void
 ssbox_populate(struct ssbox *ssb,struct cmd_t_test *cmd)
@@ -600,6 +655,8 @@ ssbox_base_finalize(struct ssbox *ssb)
   tab_submit(ssb->t);
 }
 
+
+
 /* Initialize a ssbox struct */
 void 
 ssbox_base_init(struct ssbox *this, int cols,int rows)
@@ -629,7 +686,7 @@ ssbox_one_sample_init(struct ssbox *this,
 
   ssbox_base_init(this, hsize,vsize);
   tab_title (this->t, 0, _("One-Sample Statistics"));
-  tab_vline(this->t, TAL_2, 1,0,vsize);
+  tab_vline(this->t, TAL_2, 1,0,vsize - 1);
   tab_text (this->t, 1, 0, TAB_CENTER | TAT_TITLE, _("N"));
   tab_text (this->t, 2, 0, TAB_CENTER | TAT_TITLE, _("Mean"));
   tab_text (this->t, 3, 0, TAB_CENTER | TAT_TITLE, _("Std. Deviation"));
@@ -651,7 +708,7 @@ ssbox_independent_samples_init(struct ssbox *this,
 
   ssbox_base_init(this, hsize,vsize);
   tab_title (this->t, 0, _("Group Statistics"));
-  tab_vline(this->t,0,1,0,vsize);
+  tab_vline(this->t,0,1,0,vsize - 1);
   tab_text (this->t, 1, 0, TAB_CENTER | TAT_TITLE, indep_var->name);
   tab_text (this->t, 2, 0, TAB_CENTER | TAT_TITLE, _("N"));
   tab_text (this->t, 3, 0, TAB_CENTER | TAT_TITLE, _("Mean"));
@@ -669,31 +726,41 @@ ssbox_independent_samples_populate(struct ssbox *ssb,
 
   char *val_lab0=0;
   char *val_lab1=0;
+  double indep_value[2];
 
   char prefix[2][3]={"",""};
 
   if ( indep_var->type == NUMERIC ) 
     {
-      val_lab0 = val_labs_find( indep_var->val_labs,groups_values[0]); 
-      val_lab1 = val_labs_find( indep_var->val_labs,groups_values[1]);
+      val_lab0 = val_labs_find( indep_var->val_labs,gp.v.g_value[0]); 
+      val_lab1 = val_labs_find( indep_var->val_labs,gp.v.g_value[1]);
     }
   else
     {
-      val_lab0 = groups_values[0].s;
-      val_lab1 = groups_values[1].s;
+      val_lab0 = gp.v.g_value[0].s;
+      val_lab1 = gp.v.g_value[1].s;
     }
 
-  if (n_group_values == 1) 
+  if (gp.criterion == CMP_LE ) 
     {
       strcpy(prefix[0],"< ");
       strcpy(prefix[1],">=");
+      indep_value[0] = gp.v.critical_value;
+      indep_value[1] = gp.v.critical_value;
+    }
+  else
+    {
+      indep_value[0] = gp.v.g_value[0].f;
+      indep_value[1] = gp.v.g_value[1].f;
     }
 
   assert(ssb->t);
 
   for (i=0; i < cmd->n_variables; ++i)
     {
-      int g;
+      struct variable *var = cmd->v_variables[i];
+      struct hsh_table *grp_hash = group_proc_get (var)->group_hash;
+      int count=0;
 
       tab_text (ssb->t, 0, i*2+1, TAB_LEFT, cmd->v_variables[i]->name);
 
@@ -701,26 +768,50 @@ ssbox_independent_samples_populate(struct ssbox *ssb,
 	tab_text (ssb->t, 1, i*2+1, TAB_LEFT | TAT_PRINTF, 
 		  "%s%s", prefix[0], val_lab0);
       else
-	tab_text (ssb->t, 1, i*2+1, TAB_LEFT | TAT_PRINTF, 
-		  "%s%g", prefix[0], groups_values[0].f); 
+	  tab_text (ssb->t, 1, i*2+1, TAB_LEFT | TAT_PRINTF, 
+		    "%s%g", prefix[0], indep_value[0]);
 
 
       if (val_lab1)
 	tab_text (ssb->t, 1, i*2+1+1, TAB_LEFT | TAT_PRINTF, 
 		  "%s%s", prefix[1], val_lab1);
       else
-	tab_text (ssb->t, 1, i*2+1+1, TAB_LEFT | TAT_PRINTF, 
-		  "%s%g", prefix[1], groups_values[1].f); 
+	  tab_text (ssb->t, 1, i*2+1+1, TAB_LEFT | TAT_PRINTF, 
+		    "%s%g", prefix[1], indep_value[1]);
+
 
       /* Fill in the group statistics */
-      for ( g=0; g < 2 ; ++g ) 
+      for ( count = 0 ; count < 2 ; ++count ) 
 	{
-	  struct group_statistics *gs = &cmd->v_variables[i]->p.t_t.gs[g];
+	  union value search_val;
+
+	  struct group_statistics *gs;
 
-	  tab_float(ssb->t, 2 ,i*2+g+1, TAB_RIGHT, gs->n, 2, 0);
-	  tab_float(ssb->t, 3 ,i*2+g+1, TAB_RIGHT, gs->mean, 8, 2);
-	  tab_float(ssb->t, 4 ,i*2+g+1, TAB_RIGHT, gs->std_dev, 8, 3);
-	  tab_float(ssb->t, 5 ,i*2+g+1, TAB_RIGHT, gs->se_mean, 8, 3);
+	  if ( gp.criterion == CMP_LE ) 
+	    {
+	      if ( count == 0 ) 
+		{
+		  /*  less than ( < )  case */
+		  search_val.f = gp.v.critical_value - 1.0;
+		}
+	      else
+		{
+		  /* >= case  */
+		  search_val.f = gp.v.critical_value + 1.0;
+		}
+	    }
+	  else
+	    {
+	      search_val = gp.v.g_value[count];
+	    }
+
+	  gs = hsh_find(grp_hash, (void *) &search_val);
+	  assert(gs);
+
+	  tab_float(ssb->t, 2 ,i*2+count+1, TAB_RIGHT, gs->n, 2, 0);
+	  tab_float(ssb->t, 3 ,i*2+count+1, TAB_RIGHT, gs->mean, 8, 2);
+	  tab_float(ssb->t, 4 ,i*2+count+1, TAB_RIGHT, gs->std_dev, 8, 3);
+	  tab_float(ssb->t, 5 ,i*2+count+1, TAB_RIGHT, gs->se_mean, 8, 3);
 	}
     }
 }
@@ -768,7 +859,7 @@ ssbox_paired_populate(struct ssbox *ssb,struct cmd_t_test *cmd UNUSED)
 	{
 	  struct group_statistics *gs;
 
-	  gs=&pairs[i].v[j]->p.t_t.ugs;
+	  gs = &group_proc_get (pairs[i].v[j])->ugs;
 
 	  /* Titles */
 
@@ -794,8 +885,7 @@ ssbox_one_sample_populate(struct ssbox *ssb, struct cmd_t_test *cmd)
 
   for (i=0; i < cmd->n_variables; ++i)
     {
-      struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      struct group_statistics *gs = &group_proc_get (cmd->v_variables[i])->ugs;
 
       tab_text (ssb->t, 0, i+1, TAB_LEFT, cmd->v_variables[i]->name);
       tab_float (ssb->t,1, i+1, TAB_RIGHT, gs->n, 2, 0);
@@ -929,20 +1019,43 @@ trbox_independent_samples_populate(struct trbox *self,
       double std_err_diff;
       double mean_diff;
 
-      struct group_statistics *gs0 = &cmd->v_variables[i]->p.t_t.gs[0];
-      struct group_statistics *gs1 = &cmd->v_variables[i]->p.t_t.gs[1];
+      struct variable *var = cmd->v_variables[i];
+      struct group_proc *grp_data = group_proc_get (var);
+
+      struct hsh_table *grp_hash = grp_data->group_hash;
+
+      struct group_statistics *gs0 ;
+      struct group_statistics *gs1 ;
+	  
+      union value search_val;
+	  
+      if ( gp.criterion == CMP_LE ) 
+	search_val.f = gp.v.critical_value - 1.0;
+      else
+	search_val = gp.v.g_value[0];
+
+      gs0 = hsh_find(grp_hash, (void *) &search_val);
+      assert(gs0);
+
+      if ( gp.criterion == CMP_LE ) 
+	search_val.f = gp.v.critical_value + 1.0;
+      else
+	search_val = gp.v.g_value[1];
+
+      gs1 = hsh_find(grp_hash, (void *) &search_val);
+      assert(gs1);
+
 	  
       tab_text (self->t, 0, i*2+3, TAB_LEFT, cmd->v_variables[i]->name);
 
       tab_text (self->t, 1, i*2+3, TAB_LEFT, _("Equal variances assumed"));
 
 
-      tab_float(self->t, 2, i*2+3, TAB_CENTER, 
-		cmd->v_variables[i]->p.t_t.levene, 8,3);
+      tab_float(self->t, 2, i*2+3, TAB_CENTER, grp_data->levene, 8,3);
 
       /* Now work out the significance of the Levene test */
-      df1 = 1; df2 = cmd->v_variables[i]->p.t_t.ugs.n - 2;
-      q = gsl_cdf_fdist_Q(cmd->v_variables[i]->p.t_t.levene, df1, df2);
+      df1 = 1; df2 = grp_data->ugs.n - 2;
+      q = gsl_cdf_fdist_Q(grp_data->levene, df1, df2);
 
       tab_float(self->t, 3, i*2+3, TAB_CENTER, q, 8,3 );
 
@@ -1047,7 +1160,7 @@ trbox_paired_init(struct trbox *self,
   trbox_base_init(self,n_pairs,hsize);
   tab_title (self->t, 0, _("Paired Samples Test"));
   tab_hline(self->t,TAL_1,2,6,1);
-  tab_vline(self->t,TAL_2,2,0,vsize);
+  tab_vline(self->t,TAL_2,2,0,vsize - 1);
   tab_joint_text(self->t,2,0,6,0,TAB_CENTER,_("Paired Differences"));
   tab_box(self->t,-1,-1,-1,TAL_1, 2,1,6,vsize-1);
   tab_box(self->t,-1,-1,-1,TAL_1, 6,0,hsize-1,vsize-1);
@@ -1141,10 +1254,10 @@ trbox_one_sample_init(struct trbox *self, struct cmd_t_test *cmd )
   trbox_base_init(self, cmd->n_variables,hsize);
   tab_title (self->t, 0, _("One-Sample Test"));
   tab_hline(self->t, TAL_1, 1, hsize - 1, 1);
-  tab_vline(self->t, TAL_2, 1, 0, vsize);
+  tab_vline(self->t, TAL_2, 1, 0, vsize - 1);
 
   tab_joint_text(self->t, 1, 0, hsize-1,0, TAB_CENTER | TAT_PRINTF, 
-		 _("Test Value = %f"),cmd->n_testval);
+		 _("Test Value = %f"), cmd->n_testval[0]);
 
   tab_box(self->t, -1, -1, -1, TAL_1, 1,1,hsize-1,vsize-1);
 
@@ -1178,13 +1291,12 @@ trbox_one_sample_populate(struct trbox *trb, struct cmd_t_test *cmd)
       double t;
       double p,q;
       double df;
-      struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      struct group_statistics *gs = &group_proc_get (cmd->v_variables[i])->ugs;
 
 
       tab_text (trb->t, 0, i+3, TAB_LEFT, cmd->v_variables[i]->name);
 
-      t = (gs->mean - cmd->n_testval ) * sqrt(gs->n) / gs->std_dev ;
+      t = (gs->mean - cmd->n_testval[0] ) * sqrt(gs->n) / gs->std_dev ;
 
       tab_float (trb->t, 1, i+3, TAB_RIGHT, t, 8,3);
 
@@ -1296,6 +1408,7 @@ pscbox(void)
 
 
 
+
 /* Calculation Implementation */
 
 /* Per case calculations common to all variants of the T test */
@@ -1314,7 +1427,7 @@ common_calc (const struct ccase *c, void *_cmd)
       for(i=0; i< cmd->n_variables ; ++i) 
 	{
 	  struct variable *v = cmd->v_variables[i];
-	  const union value *val = &c->data[v->fv];
+	  const union value *val = case_data (c, v->fv);
 
 	  if (value_is_missing(val,v) )
 	    {
@@ -1326,7 +1439,7 @@ common_calc (const struct ccase *c, void *_cmd)
   /* Listwise has to be implicit if the independent variable is missing ?? */
   if ( cmd->sbc_groups )
     {
-      const union value *gv = &c->data[indep_var->fv];
+      const union value *gv = case_data (c, indep_var->fv);
       if ( value_is_missing(gv,indep_var) )
 	{
 	  return 0;
@@ -1338,9 +1451,9 @@ common_calc (const struct ccase *c, void *_cmd)
     {
       struct group_statistics *gs;
       struct variable *v = cmd->v_variables[i];
-      const union value *val = &c->data[v->fv];
+      const union value *val = case_data (c, v->fv);
 
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
 
       if (! value_is_missing(val,v) )
 	{
@@ -1361,7 +1474,7 @@ common_precalc ( struct cmd_t_test *cmd )
   for(i=0; i< cmd->n_variables ; ++i) 
     {
       struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
       
       gs->sum=0;
       gs->n=0;
@@ -1380,7 +1493,7 @@ common_postcalc (  struct cmd_t_test *cmd )
   for(i=0; i< cmd->n_variables ; ++i) 
     {
       struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
       
       gs->mean=gs->sum / gs->n;
       gs->s_std_dev= sqrt(
@@ -1413,7 +1526,7 @@ one_sample_calc (const struct ccase *c, void *cmd_)
       for(i=0; i< cmd->n_variables ; ++i) 
 	{
 	  struct variable *v = cmd->v_variables[i];
-	  const union value *val = &c->data[v->fv];
+	  const union value *val = case_data (c, v->fv);
 
 	  if (value_is_missing(val,v) )
 	    {
@@ -1426,12 +1539,12 @@ one_sample_calc (const struct ccase *c, void *cmd_)
     {
       struct group_statistics *gs;
       struct variable *v = cmd->v_variables[i];
-      const union value *val = &c->data[v->fv];
+      const union value *val = case_data (c, v->fv);
 
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
       
       if ( ! value_is_missing(val,v))
-	gs->sum_diff += weight * (val->f - cmd->n_testval);
+	gs->sum_diff += weight * (val->f - cmd->n_testval[0]);
     }
 
   return 0;
@@ -1446,7 +1559,7 @@ one_sample_precalc ( struct cmd_t_test *cmd )
   for(i=0; i< cmd->n_variables ; ++i) 
     {
       struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
       
       gs->sum_diff=0;
     }
@@ -1461,7 +1574,7 @@ one_sample_postcalc (struct cmd_t_test *cmd)
   for(i=0; i< cmd->n_variables ; ++i) 
     {
       struct group_statistics *gs;
-      gs= &cmd->v_variables[i]->p.t_t.ugs;
+      gs= &group_proc_get (cmd->v_variables[i])->ugs;
 
       gs->mean_diff = gs->sum_diff / gs->n ;
     }
@@ -1469,25 +1582,6 @@ one_sample_postcalc (struct cmd_t_test *cmd)
 
 
 
-static int
-compare_var_name (const void *a_, const void *b_, void *v_ UNUSED)
-{
-  const struct variable *a = a_;
-  const struct variable *b = b_;
-
-  return strcmp(a->name,b->name);
-}
-
-static unsigned
-hash_var_name (const void *a_, void *v_ UNUSED)
-{
-  const struct variable *a = a_;
-
-  return hsh_hash_bytes (a->name, strlen(a->name));
-}
-
-
-
 static void 
 paired_precalc (struct cmd_t_test *cmd UNUSED)
 {
@@ -1525,8 +1619,8 @@ paired_calc (const struct ccase *c, void *cmd_)
 	  struct variable *v0 = pairs[i].v[0];
 	  struct variable *v1 = pairs[i].v[1];
 
-	  const union value *val0 = &c->data[v0->fv];
-	  const union value *val1 = &c->data[v1->fv];
+	  const union value *val0 = case_data (c, v0->fv);
+	  const union value *val1 = case_data (c, v1->fv);
 	  
 	  if ( value_is_missing(val0,v0) ||
 	       value_is_missing(val1,v1) )
@@ -1541,8 +1635,8 @@ paired_calc (const struct ccase *c, void *cmd_)
       struct variable *v0 = pairs[i].v[0];
       struct variable *v1 = pairs[i].v[1];
 
-      const union value *val0 = &c->data[v0->fv];
-      const union value *val1 = &c->data[v1->fv];
+      const union value *val0 = case_data (c, v0->fv);
+      const union value *val1 = case_data (c, v1->fv);
 
       if ( ( !value_is_missing(val0,v0) && !value_is_missing(val1,v1) ) )
       {
@@ -1602,44 +1696,6 @@ paired_postcalc (struct cmd_t_test *cmd UNUSED)
     }
 }
 
-/* Return the group # corresponding to the 
-   independent variable with the value val 
-*/
-static int
-get_group(const union value *val, struct variable *indep)
-{
-  int i; 
-
-  for (i = 0; i < 2  ; ++i )
-    {
-      const int cmp = compare_values(val,&groups_values[i],indep->width) ;
-      switch ( criteria[i])
-	{
-	case CMP_EQ: 
-	  if ( 0 == cmp )   return i;
-	  break;	   
-	case CMP_LT:	   
-	  if ( 0 >  cmp )  return i;
-	  break;	   
-	case CMP_LE:	   
-	  if ( cmp <= 0 )   return i;
-	  break;
-	case CMP_GT:
-	  if ( cmp > 0 ) return i;
-	  break;
-	case CMP_GE:
-	  if ( cmp >= 0 ) return i;
-	  break;
-	default:
-	  assert(0);
-	};
-    }
-
-  /* No groups matched */
-  return -1;
-}
-
-
 static void 
 group_precalc (struct cmd_t_test *cmd )
 {
@@ -1648,23 +1704,43 @@ group_precalc (struct cmd_t_test *cmd )
 
   for(i=0; i< cmd->n_variables ; ++i) 
     {
-      struct t_test_proc *ttpr = &cmd->v_variables[i]->p.t_t;
+      struct group_proc *ttpr = group_proc_get (cmd->v_variables[i]);
 
       /* There's always 2 groups for a T - TEST */
       ttpr->n_groups = 2;
-      ttpr->gs = xmalloc(sizeof(struct group_statistics) * 2) ;
+
+      gp.indep_width = indep_var->width;
+      
+      ttpr->group_hash = hsh_create(2, 
+				    (hsh_compare_func *) compare_group_binary,
+				    (hsh_hash_func *) hash_group_binary,
+				    (hsh_free_func *) free_group,
+				    (void *) &gp );
 
       for (j=0 ; j < 2 ; ++j)
 	{
-	  ttpr->gs[j].sum = 0;
-	  ttpr->gs[j].n = 0;
-	  ttpr->gs[j].ssq = 0;
+
+	  struct group_statistics *gs = (struct group_statistics *) 
+	    xmalloc (sizeof(struct group_statistics));
+
+	  gs->sum = 0;
+	  gs->n = 0;
+	  gs->ssq = 0;
 	
-	  if ( n_group_values == 2 ) 
-	    ttpr->gs[j].id = groups_values[j];
+	  if ( gp.criterion == CMP_EQ ) 
+	    {
+	      gs->id = gp.v.g_value[j];
+	    }
 	  else
-	    ttpr->gs[j].id = groups_values[0];
-	  ttpr->gs[j].criterion = criteria[j];
+	    {
+	      if ( j == 0 ) 
+		gs->id.f = gp.v.critical_value - 1.0 ;
+	      else
+		gs->id.f = gp.v.critical_value + 1.0 ;
+	    }
+	  
+	  hsh_insert ( ttpr->group_hash, (void *) gs );
+
 	}
     }
 
@@ -1674,9 +1750,8 @@ static int
 group_calc (const struct ccase *c, struct cmd_t_test *cmd)
 {
   int i;
-  int g;
 
-  const union value *gv = &c->data[indep_var->fv];
+  const union value *gv = case_data (c, indep_var->fv);
 
   const double weight = dict_get_case_weight(default_dict,c,&bad_weight_warn);
 
@@ -1690,7 +1765,7 @@ group_calc (const struct ccase *c, struct cmd_t_test *cmd)
       for(i=0; i< cmd->n_variables ; ++i) 
 	{
 	  struct variable *v = cmd->v_variables[i];
-	  const union value *val = &c->data[v->fv];
+	  const union value *val = case_data (c, v->fv);
 
 	  if (value_is_missing(val,v) )
 	    {
@@ -1699,24 +1774,21 @@ group_calc (const struct ccase *c, struct cmd_t_test *cmd)
 	}
     }
 
-
-  gv = &c->data[indep_var->fv];
-
-  g = get_group(gv,indep_var);
-
-
-  /* If the independent variable doesn't match either of the values 
-     for this case then move on to the next case */
-  if (g == -1 ) 
-    return 0;
+  gv = case_data (c, indep_var->fv);
 
   for(i=0; i< cmd->n_variables ; ++i) 
     {
       struct variable *var = cmd->v_variables[i];
+      const union value *val = case_data (c, var->fv);
+      struct hsh_table *grp_hash = group_proc_get (var)->group_hash;
+      struct group_statistics *gs;
 
-      struct group_statistics *gs = &var->p.t_t.gs[g];
+      gs = hsh_find(grp_hash, (void *) gv);
 
-      const union value *val=&c->data[var->fv];
+      /* If the independent variable doesn't match either of the values 
+         for this case then move on to the next case */
+      if ( ! gs ) 
+      	return 0;
 
       if ( !value_is_missing(val,var) )
 	{
@@ -1734,28 +1806,34 @@ static void
 group_postcalc ( struct cmd_t_test *cmd )
 {
   int i;
-  int j;
 
   for(i=0; i< cmd->n_variables ; ++i) 
     {
-      for (j=0 ; j < 2 ; ++j)
-	{
-	  struct group_statistics *gs;
-	  gs=&cmd->v_variables[i]->p.t_t.gs[j];
+      struct variable *var = cmd->v_variables[i];
+      struct hsh_table *grp_hash = group_proc_get (var)->group_hash;
+      struct hsh_iterator g;
+      struct group_statistics *gs;
+      int count=0;
 
+      for (gs =  hsh_first (grp_hash,&g); 
+	   gs != 0; 
+	   gs = hsh_next(grp_hash,&g))
+	{
 	  gs->mean = gs->sum / gs->n;
 	  
 	  gs->s_std_dev= sqrt(
-			 ( (gs->ssq / gs->n ) - gs->mean * gs->mean )
-			 ) ;
+			      ( (gs->ssq / gs->n ) - gs->mean * gs->mean )
+			      ) ;
 
 	  gs->std_dev= sqrt(
-			 gs->n/(gs->n-1) *
-			 ( (gs->ssq / gs->n ) - gs->mean * gs->mean )
-			 ) ;
+			    gs->n/(gs->n-1) *
+			    ( (gs->ssq / gs->n ) - gs->mean * gs->mean )
+			    ) ;
 	  
 	  gs->se_mean = gs->std_dev / sqrt(gs->n);
+	  count ++;
 	}
+      assert(count == 2);
     }
 }
 
@@ -1768,15 +1846,16 @@ calculate(const struct casefile *cf, void *cmd_)
   struct trbox test_results_box;
 
   struct casereader *r;
-  const struct ccase *c;
+  struct ccase c;
 
   struct cmd_t_test *cmd = (struct cmd_t_test *) cmd_;
 
   common_precalc(cmd);
   for(r = casefile_get_reader (cf);
-      casereader_read (r, &c) ; ) 
+      casereader_read (r, &c) ;
+      case_destroy (&c)) 
     {
-      common_calc(c,cmd);
+      common_calc(&c,cmd);
     }
   casereader_destroy (r);
   common_postcalc(cmd);
@@ -1786,9 +1865,10 @@ calculate(const struct casefile *cf, void *cmd_)
     case T_1_SAMPLE:
       one_sample_precalc(cmd);
       for(r = casefile_get_reader (cf);
-	  casereader_read (r, &c) ; ) 
+	  casereader_read (r, &c) ;
+          case_destroy (&c)) 
 	{
-	  one_sample_calc(c,cmd);
+	  one_sample_calc(&c,cmd);
 	}
       casereader_destroy (r);
       one_sample_postcalc(cmd);
@@ -1797,9 +1877,10 @@ calculate(const struct casefile *cf, void *cmd_)
     case T_PAIRED:
       paired_precalc(cmd);
       for(r = casefile_get_reader (cf);
-	  casereader_read (r, &c) ; ) 
+	  casereader_read (r, &c) ;
+          case_destroy (&c)) 
 	{
-	  paired_calc(c,cmd);
+	  paired_calc(&c,cmd);
 	}
       casereader_destroy (r);
       paired_postcalc(cmd);
@@ -1809,14 +1890,14 @@ calculate(const struct casefile *cf, void *cmd_)
 
       group_precalc(cmd);
       for(r = casefile_get_reader (cf);
-	  casereader_read (r, &c) ; ) 
+	  casereader_read (r, &c) ;
+          case_destroy (&c)) 
 	{
-	  group_calc(c,cmd);
+	  group_calc(&c,cmd);
 	}
       casereader_destroy (r);
       group_postcalc(cmd);
 
-
       levene(cf, indep_var, cmd->n_variables, cmd->v_variables,
 	     (cmd->miss == TTS_LISTWISE)?LEV_LISTWISE:LEV_ANALYSIS ,
 	     value_is_missing);
@@ -1835,3 +1916,80 @@ calculate(const struct casefile *cf, void *cmd_)
   trbox_finalize(&test_results_box);
 
 }
+
+short which_group(const struct group_statistics *g,
+		  const struct group_properties *p);
+
+/* Return -1 if the id of a is less than b; +1 if greater than and 
+   0 if equal */
+static int 
+compare_group_binary(const struct group_statistics *a, 
+		     const struct group_statistics *b, 
+		     const struct group_properties *p)
+{
+  short flag_a;
+  short flag_b;
+  
+  if ( p->criterion == CMP_LE ) 
+    {
+      /* less-than-or-equal comparision is not meaningfull for
+	 alpha variables, so we shouldn't ever arrive here */
+      assert(p->indep_width == 0 ) ;
+      
+      flag_a = ( a->id.f < p->v.critical_value ) ;
+      flag_b = ( b->id.f < p->v.critical_value ) ;
+    }
+  else
+    {
+      flag_a = which_group(a, p);
+      flag_b = which_group(b, p);
+    }
+
+  if (flag_a < flag_b ) 
+    return -1;
+
+  return (flag_a > flag_b);
+}
+
+/* This is a degenerate case of a hash, since it can only return three possible
+   values.  It's really a comparison, being used as a hash function */
+
+static unsigned 
+hash_group_binary(const struct group_statistics *g, 
+		  const struct group_properties *p)
+{
+  short flag = -1;
+
+  if ( p->criterion == CMP_LE ) 
+    {
+      /* Not meaningfull to do a less than compare for alpha values ? */
+      assert(p->indep_width == 0 ) ;
+      flag = ( g->id.f < p->v.critical_value ) ; 
+    }
+  else if ( p->criterion == CMP_EQ) 
+    {
+      flag = which_group(g,p);
+    }
+  else
+    assert(0);
+
+  return flag;
+}
+
+/* return 0 if G belongs to group 0, 
+          1 if it belongs to group 1,
+	  2 if it belongs to neither group */
+short
+which_group(const struct group_statistics *g,
+	    const struct group_properties *p)
+{
+ 
+  if ( 0 == compare_values (&g->id, &p->v.g_value[0], p->indep_width))
+    return 0;
+
+  if ( 0 == compare_values (&g->id, &p->v.g_value[1], p->indep_width))
+    return 1;
+
+  return 2;
+}
+