X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Foutput%2Fdriver.c;h=7782e91f0c07b241bb129f517168691ea221a72d;hb=56e6166660c0f1388cad4cb4d3189e026bc84dd5;hp=44aa2558247394b3c81f6f5341ebead2ca501437;hpb=456b47421c16fdbbfe7f1e74e661d7c7876ff6df;p=pspp diff --git a/src/output/driver.c b/src/output/driver.c index 44aa255824..7782e91f0c 100644 --- a/src/output/driver.c +++ b/src/output/driver.c @@ -32,6 +32,7 @@ #include "data/settings.h" #include "libpspp/array.h" #include "libpspp/assertion.h" +#include "libpspp/i18n.h" #include "libpspp/message.h" #include "libpspp/llx.h" #include "libpspp/string-map.h" @@ -53,7 +54,8 @@ struct output_engine { struct ll ll; /* Node for this engine. */ struct llx_list drivers; /* Contains "struct output_driver"s. */ - struct string deferred_syntax; /* TEXT_ITEM_SYNTAX being accumulated. */ + struct string deferred_text; /* Output text being accumulated. */ + enum text_item_type deferred_type; /* Type of text being accumulated. */ char *command_name; /* Name of command being processed. */ char *title, *subtitle; /* Components of page title. */ @@ -76,7 +78,7 @@ static struct output_engine * engine_stack_top (void) { struct ll *head = ll_head (&engine_stack); - if (ll_is_empty (head)) + if (ll_is_empty (&engine_stack)) return NULL; return ll_data (head, struct output_engine, ll); } @@ -99,7 +101,7 @@ output_engine_push (void) struct output_engine *e = xzalloc (sizeof (*e)); llx_init (&e->drivers); - ds_init_empty (&e->deferred_syntax); + ds_init_empty (&e->deferred_text); string_map_init (&e->heading_vars); @@ -122,7 +124,7 @@ output_engine_pop (void) struct output_driver *d = llx_pop_head (&e->drivers, &llx_malloc_mgr); output_driver_destroy (d); } - ds_destroy (&e->deferred_syntax); + ds_destroy (&e->deferred_text); free (e->command_name); free (e->title); free (e->subtitle); @@ -176,25 +178,43 @@ output_submit__ (struct output_engine *e, struct output_item *item) } static void -flush_deferred_syntax (struct output_engine *e) +flush_deferred_text (struct output_engine *e) { - if (!ds_is_empty (&e->deferred_syntax)) + if (!ds_is_empty (&e->deferred_text)) { - ds_trim (&e->deferred_syntax, ss_cstr ("\n")); - if (!ds_is_empty (&e->deferred_syntax)) - { - char *syntax = ds_steal_cstr (&e->deferred_syntax); - output_submit__ (e, text_item_super (text_item_create_nocopy ( - TEXT_ITEM_SYNTAX, syntax))); - } + char *text = ds_steal_cstr (&e->deferred_text); + output_submit__ (e, text_item_super (text_item_create_nocopy ( + e->deferred_type, text))); } } static bool -is_syntax_item (const struct output_item *item) +defer_text (struct output_engine *e, struct output_item *item) { - return (is_text_item (item) - && text_item_get_type (to_text_item (item)) == TEXT_ITEM_SYNTAX); + if (!is_text_item (item)) + return false; + + struct text_item *text_item = to_text_item (item); + if (text_item->markup) /* XXX */ + return false; + + enum text_item_type type = text_item_get_type (text_item); + if (type != TEXT_ITEM_SYNTAX && type != TEXT_ITEM_LOG) + return false; + + if (!ds_is_empty (&e->deferred_text) && e->deferred_type != type) + flush_deferred_text (e); + + e->deferred_type = type; + + if (!ds_is_empty (&e->deferred_text)) + ds_put_byte (&e->deferred_text, '\n'); + + const char *text = text_item_get_text (text_item); + ds_put_cstr (&e->deferred_text, text); + output_item_unref (item); + + return true; } /* Submits ITEM to the configured output drivers, and transfers ownership to @@ -210,14 +230,9 @@ output_submit (struct output_item *item) if (item == NULL) return; - if (is_syntax_item (item)) - { - ds_put_cstr (&e->deferred_syntax, text_item_get_text (to_text_item (item))); - output_item_unref (item); - return; - } - - flush_deferred_syntax (e); + if (defer_text (e, item)) + return; + flush_deferred_text (e); if (is_group_open_item (item)) { @@ -240,7 +255,7 @@ output_submit (struct output_item *item) if (idx >= 1 && idx <= 4) { char *key = xasprintf ("Head%zu", idx); - string_map_find_and_delete (&e->heading_vars, key); + free (string_map_find_and_delete (&e->heading_vars, key)); free (key); } } @@ -263,7 +278,11 @@ output_submit (struct output_item *item) output_submit__ (e, item); } -const char * +/* Returns the name of the command currently being parsed, in all uppercase. + The caller must free the returned value. + + Returns NULL if no command is being parsed. */ +char * output_get_command_name (void) { struct output_engine *e = engine_stack_top (); @@ -272,7 +291,7 @@ output_get_command_name (void) for (size_t i = e->n_groups; i-- > 0; ) if (e->groups[i]) - return e->groups[i]; + return utf8_to_upper (e->groups[i]); return NULL; } @@ -285,7 +304,7 @@ output_flush (void) struct output_engine *e = engine_stack_top (); struct llx *llx; - flush_deferred_syntax (e); + flush_deferred_text (e); for (llx = llx_head (&e->drivers); llx != llx_null (&e->drivers); llx = llx_next (llx)) { @@ -416,6 +435,7 @@ extern const struct output_driver_factory list_driver_factory; extern const struct output_driver_factory html_driver_factory; extern const struct output_driver_factory csv_driver_factory; extern const struct output_driver_factory odt_driver_factory; +extern const struct output_driver_factory spv_driver_factory; #ifdef HAVE_CAIRO extern const struct output_driver_factory pdf_driver_factory; extern const struct output_driver_factory ps_driver_factory; @@ -429,6 +449,7 @@ static const struct output_driver_factory *factories[] = &html_driver_factory, &csv_driver_factory, &odt_driver_factory, + &spv_driver_factory, #ifdef HAVE_CAIRO &pdf_driver_factory, &ps_driver_factory,