X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fmath%2Fmoments.c;h=517219d54fcf5d3cc159b4b64c8f6454f64a5bd4;hb=49aaf665f7ad1fed25d23b6ccb0da1c5461c4846;hp=e289e8aec0ef27c2372e2c007eeb30e6b2f6d469;hpb=fe8dc2171009e90d2335f159d05f7e6660e24780;p=pspp

diff --git a/src/math/moments.c b/src/math/moments.c
index e289e8aec0..517219d54f 100644
--- a/src/math/moments.c
+++ b/src/math/moments.c
@@ -28,8 +28,6 @@
 
 #include "gl/xalloc.h"
 
-#include "gettext.h"
-#define _(msgid) gettext (msgid)
 
 /* Calculates variance, skewness, and kurtosis into *VARIANCE,
    *SKEWNESS, and *KURTOSIS if they are non-null and not greater
@@ -225,12 +223,8 @@ moments_calculate (const struct moments *m,
     }
   else
     {
-      /* After the second pass we can calculate any stat.  We
-         don't support "online" computation during the second
-         pass, so As a simple self-check, the total weight for
-         the passes must agree. */
+      /* After the second pass we can calculate any stat.  */
       assert (m->pass == 2);
-      assert (m->w1 == m->w2);
 
       if (m->w2 > 0.)
         {
@@ -250,14 +244,14 @@ moments_destroy (struct moments *m)
   free (m);
 }
 
-/* Calculates the requested moments on the CNT values in ARRAY.
+/* Calculates the requested moments on the N values in ARRAY.
    Each value is given a weight of 1.  The total weight is stored
    into *WEIGHT (trivially) and the mean, variance, skewness, and
    kurtosis are stored into *MEAN, *VARIANCE, *SKEWNESS, and
    *KURTOSIS, respectively.  Any of the result pointers may be
    null, in which case no value is stored. */
 void
-moments_of_doubles (const double *array, size_t cnt,
+moments_of_doubles (const double *array, size_t n,
                     double *weight,
                     double *mean, double *variance,
                     double *skewness, double *kurtosis)
@@ -276,21 +270,21 @@ moments_of_doubles (const double *array, size_t cnt,
     max_moment = MOMENT_MEAN;
 
   init_moments (&m, max_moment);
-  for (idx = 0; idx < cnt; idx++)
+  for (idx = 0; idx < n; idx++)
     moments_pass_one (&m, array[idx], 1.);
-  for (idx = 0; idx < cnt; idx++)
+  for (idx = 0; idx < n; idx++)
     moments_pass_two (&m, array[idx], 1.);
   moments_calculate (&m, weight, mean, variance, skewness, kurtosis);
 }
 
-/* Calculates the requested moments on the CNT numeric values in
+/* Calculates the requested moments on the N numeric values in
    ARRAY.  Each value is given a weight of 1.  The total weight
    is stored into *WEIGHT (trivially) and the mean, variance,
    skewness, and kurtosis are stored into *MEAN, *VARIANCE,
    *SKEWNESS, and *KURTOSIS, respectively.  Any of the result
    pointers may be null, in which case no value is stored. */
 void
-moments_of_values (const union value *array, size_t cnt,
+moments_of_values (const union value *array, size_t n,
                    double *weight,
                    double *mean, double *variance,
                    double *skewness, double *kurtosis)
@@ -309,9 +303,9 @@ moments_of_values (const union value *array, size_t cnt,
     max_moment = MOMENT_MEAN;
 
   init_moments (&m, max_moment);
-  for (idx = 0; idx < cnt; idx++)
+  for (idx = 0; idx < n; idx++)
     moments_pass_one (&m, array[idx].f, 1.);
-  for (idx = 0; idx < cnt; idx++)
+  for (idx = 0; idx < n; idx++)
     moments_pass_two (&m, array[idx].f, 1.);
   moments_calculate (&m, weight, mean, variance, skewness, kurtosis);
 }
@@ -461,6 +455,13 @@ moments1_destroy (struct moments1 *m)
   free (m);
 }
 
+
+double
+calc_semean (double variance, double W)
+{
+  return sqrt (variance / W);
+}
+
 /* Returns the standard error of the skewness for the given total
    weight W.