X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flibpspp%2Fsparse-array.c;h=28398d5cc86321e9e648a9c0ac30c052c1d26641;hb=29678b3e963f9831e281266f2d59c87a9a09b34d;hp=ebc81ff45137734736069abf6eaaa0d13d4b0fae;hpb=a68e3f51236286fe02c6c4b6d40efa1bcec36349;p=pspp-builds.git diff --git a/src/libpspp/sparse-array.c b/src/libpspp/sparse-array.c index ebc81ff4..28398d5c 100644 --- a/src/libpspp/sparse-array.c +++ b/src/libpspp/sparse-array.c @@ -294,12 +294,9 @@ sparse_array_insert (struct sparse_array *spar, unsigned long int key) void * sparse_array_get (const struct sparse_array *spar, unsigned long int key) { - if (index_in_range (spar, key)) - { - struct leaf_node *leaf = find_leaf_node (spar, key); - if (leaf != NULL && is_in_use (leaf, key)) - return leaf_element (spar, leaf, key); - } + struct leaf_node *leaf = find_leaf_node (spar, key); + if (leaf != NULL && is_in_use (leaf, key)) + return leaf_element (spar, leaf, key); return NULL; } @@ -319,9 +316,6 @@ sparse_array_remove (struct sparse_array *spar, unsigned long int key) union pointer *p; int level; - if (!index_in_range (spar, key)) - return false; - /* Find and free element in leaf. */ leaf = find_leaf_node (spar, key); if (leaf == NULL || !is_in_use (leaf, key)) @@ -587,12 +581,13 @@ find_leaf_node (const struct sparse_array *spar_, unsigned long int key) const union pointer *p; int level; - assert (index_in_range (spar, key)); - /* Check the cache first. */ if (key >> BITS_PER_LEVEL == spar->cache_ofs) return spar->cache; + if (!index_in_range (spar, key)) + return NULL; + /* Descend through internal nodes. */ p = &spar->root; for (level = spar->height - 1; level > 0; level--)