X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flibpspp%2Fmessage.c;h=80475b35455e4b3c5e6e3abcdeff258dc6c71855;hb=9ade26c8349b4434008c46cf09bc7473ec743972;hp=0d226a1732ed45a2825ac02ce263780f769947ee;hpb=3f31e9c3fe628db6fe7bb7fdf2a80634cecc8181;p=pspp-builds.git diff --git a/src/libpspp/message.c b/src/libpspp/message.c index 0d226a17..80475b35 100644 --- a/src/libpspp/message.c +++ b/src/libpspp/message.c @@ -1,5 +1,5 @@ /* PSPP - a program for statistical analysis. - Copyright (C) 1997-9, 2000, 2006, 2009, 2010 Free Software Foundation, Inc. + Copyright (C) 1997-9, 2000, 2006, 2009, 2010, 2011 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -16,8 +16,7 @@ #include -#include "message.h" -#include "msg-locator.h" +#include "libpspp/message.h" #include #include @@ -26,10 +25,12 @@ #include #include -#include -#include -#include +#include "libpspp/cast.h" +#include "libpspp/str.h" +#include "libpspp/version.h" +#include "data/settings.h" +#include "gl/minmax.h" #include "gl/progname.h" #include "gl/xalloc.h" #include "gl/xvasprintf.h" @@ -37,8 +38,9 @@ #include "gettext.h" #define _(msgid) gettext (msgid) -/* Message handler as set by msg_init(). */ -static void (*msg_handler) (const struct msg *); +/* Message handler as set by msg_set_handler(). */ +static void (*msg_handler) (const struct msg *, void *aux); +static void *msg_aux; /* Disables emitting messages if positive. */ static int messages_disabled; @@ -57,23 +59,19 @@ msg (enum msg_class class, const char *format, ...) m.severity = msg_class_to_severity (class); va_start (args, format); m.text = xvasprintf (format, args); + m.file_name = NULL; + m.first_line = m.last_line = 0; + m.first_column = m.last_column = 0; va_end (args); msg_emit (&m); } -static struct source_stream *s_stream; - void -msg_init (struct source_stream *ss, void (*handler) (const struct msg *) ) +msg_set_handler (void (*handler) (const struct msg *, void *aux), void *aux) { - s_stream = ss; msg_handler = handler; -} - -void -msg_done (void) -{ + msg_aux = aux; } /* Working with messages. */ @@ -85,8 +83,8 @@ msg_dup (const struct msg *m) struct msg *new_msg; new_msg = xmemdup (m, sizeof *m); - if (m->where.file_name != NULL) - new_msg->where.file_name = xstrdup (m->where.file_name); + if (m->file_name != NULL) + new_msg->file_name = xstrdup (m->file_name); new_msg->text = xstrdup (m->text); return new_msg; @@ -94,13 +92,13 @@ msg_dup (const struct msg *m) /* Frees a message created by msg_dup(). - (Messages not created by msg_dup(), as well as their where.file_name + (Messages not created by msg_dup(), as well as their file_name members, are typically not dynamically allocated, so this function should not be used to destroy them.) */ void msg_destroy (struct msg *m) { - free (m->where.file_name); + free (m->file_name); free (m->text); free (m); } @@ -114,13 +112,58 @@ msg_to_string (const struct msg *m, const char *command_name) ds_init_empty (&s); if (m->category != MSG_C_GENERAL - && (m->where.file_name || m->where.line_number != -1)) + && (m->file_name || m->first_line > 0 || m->first_column > 0)) { - if (m->where.file_name) - ds_put_format (&s, "%s:", m->where.file_name); - if (m->where.line_number != -1) - ds_put_format (&s, "%d:", m->where.line_number); - ds_put_char (&s, ' '); + int l1 = m->first_line; + int l2 = MAX (m->first_line, m->last_line - 1); + int c1 = m->first_column; + int c2 = MAX (m->first_column, m->last_column - 1); + + if (m->file_name) + ds_put_format (&s, "%s", m->file_name); + + if (l1 > 0) + { + if (!ds_is_empty (&s)) + ds_put_byte (&s, ':'); + + if (l2 > l1) + { + if (c1 > 0) + ds_put_format (&s, "%d.%d-%d.%d", l1, c1, l2, c2); + else + ds_put_format (&s, "%d-%d", l1, l2); + } + else + { + if (c1 > 0) + { + if (c2 > c1) + { + /* The GNU coding standards say to use + LINENO-1.COLUMN-1-COLUMN-2 for this case, but GNU + Emacs interprets COLUMN-2 as LINENO-2 if I do that. + I've submitted an Emacs bug report: + http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7725. + + For now, let's be compatible. */ + ds_put_format (&s, "%d.%d-%d.%d", l1, c1, l1, c2); + } + else + ds_put_format (&s, "%d.%d", l1, c1); + } + else + ds_put_format (&s, "%d", l1); + } + } + else if (c1 > 0) + { + if (c2 > c1) + ds_put_format (&s, ".%d-%d", c1, c2); + else + ds_put_format (&s, ".%d", c1); + } + ds_put_cstr (&s, ": "); } switch (m->severity) @@ -156,6 +199,9 @@ static bool too_many_errors; /* True after the maximum number of notes has been exceeded. */ static bool too_many_notes; +/* True iff warnings have been explicitly disabled (MXWARNS = 0) */ +static bool warnings_off = false; + /* Checks whether we've had so many errors that it's time to quit processing this syntax file. */ bool @@ -164,6 +210,13 @@ msg_ui_too_many_errors (void) return too_many_errors; } +void +msg_ui_disable_warnings (bool x) +{ + warnings_off = x; +} + + void msg_ui_reset_counts (void) { @@ -188,22 +241,30 @@ submit_note (char *s) m.category = MSG_C_GENERAL; m.severity = MSG_S_NOTE; - m.where.file_name = NULL; - m.where.line_number = -1; + m.file_name = NULL; + m.first_line = 0; + m.last_line = 0; + m.first_column = 0; + m.last_column = 0; m.text = s; - msg_handler (&m); + msg_handler (&m, msg_aux); free (s); } + + static void process_msg (const struct msg *m) { int n_msgs, max_msgs; - if (too_many_errors || (too_many_notes && m->severity == MSG_S_NOTE)) + + if (too_many_errors + || (too_many_notes && m->severity == MSG_S_NOTE) + || (warnings_off && m->severity == MSG_S_WARNING) ) return; - msg_handler (m); + msg_handler (m, msg_aux); counts[m->severity]++; max_msgs = settings_get_max_messages (m->severity); @@ -223,10 +284,10 @@ process_msg (const struct msg *m) { too_many_errors = true; if (m->severity == MSG_S_WARNING) - submit_note (xasprintf (_("Warnings (%d) exceed limit (%d)."), + submit_note (xasprintf (_("Warnings (%d) exceed limit (%d). Syntax processing will be halted."), n_msgs, max_msgs)); else - submit_note (xasprintf (_("Errors (%d) exceed limit (%d)."), + submit_note (xasprintf (_("Errors (%d) exceed limit (%d). Syntax processing will be halted."), n_msgs, max_msgs)); } } @@ -238,14 +299,6 @@ process_msg (const struct msg *m) void msg_emit (struct msg *m) { - if ( s_stream ) - get_msg_location (s_stream, &m->where); - else - { - m->where.file_name = NULL; - m->where.line_number = -1; - } - if (!messages_disabled) process_msg (m); @@ -273,7 +326,7 @@ msg_enable (void) /* Private functions. */ void -request_bug_report_and_abort (const char *msg) +request_bug_report (const char *msg) { fprintf (stderr, "******************************************************\n"); fprintf (stderr, "You have discovered a bug in PSPP. Please report this\n"); @@ -295,7 +348,5 @@ request_bug_report_and_abort (const char *msg) #endif ); fprintf (stderr, "******************************************************\n"); - - _exit (EXIT_FAILURE); }