X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flibpspp%2Fi18n.c;h=c0deb119c0f3faa9c277ba0f3f931e856bd534e7;hb=7f7e4dc8457c408269e94307d9545fd504891afc;hp=3735e95d8438821e6b338641581836f83dc7da7c;hpb=b042e2bf98b0e320ee55213252bac1a0260fafc3;p=pspp
diff --git a/src/libpspp/i18n.c b/src/libpspp/i18n.c
index 3735e95d84..c0deb119c0 100644
--- a/src/libpspp/i18n.c
+++ b/src/libpspp/i18n.c
@@ -15,31 +15,29 @@
along with this program. If not, see . */
#include
-#include
+
+#include "libpspp/i18n.h"
+
#include
+#include
+#include
+#include
+#include
#include
-#include
#include
+#include
#include
-#include
-#include
-#include
-#include
-#include "assertion.h"
-#include "hmapx.h"
-#include "hash-functions.h"
-#include "pool.h"
-
-#include "i18n.h"
-#include "version.h"
+#include "libpspp/assertion.h"
+#include "libpspp/hmapx.h"
+#include "libpspp/hash-functions.h"
+#include "libpspp/pool.h"
+#include "libpspp/version.h"
-#include
-#include "xstrndup.h"
-
-#if HAVE_NL_LANGINFO
-#include
-#endif
+#include "gl/localcharset.h"
+#include "gl/xalloc.h"
+#include "gl/relocatable.h"
+#include "gl/xstrndup.h"
struct converter
{
@@ -98,6 +96,59 @@ recode_string (const char *to, const char *from,
}
+/* Uses CONV to convert the INBYTES starting at IP into the OUTBYTES starting
+ at OP, and appends a null terminator to the output.
+
+ Returns true if successful, false if the output buffer is too small. */
+static bool
+try_recode (iconv_t conv,
+ const char *ip, size_t inbytes,
+ char *op, size_t outbytes)
+{
+ /* FIXME: Need to ensure that this char is valid in the target encoding */
+ const char fallbackchar = '?';
+
+ /* Put the converter into the initial shift state, in case there was any
+ state information left over from its last usage. */
+ iconv (conv, NULL, 0, NULL, 0);
+
+ while (iconv (conv, (ICONV_CONST char **) &ip, &inbytes,
+ &op, &outbytes) == -1)
+ switch (errno)
+ {
+ case EINVAL:
+ if (outbytes < 2)
+ return false;
+ *op++ = fallbackchar;
+ *op++ = '\0';
+ return true;
+
+ case EILSEQ:
+ if (outbytes == 0)
+ return false;
+ *op++ = fallbackchar;
+ outbytes--;
+ ip++;
+ inbytes--;
+ break;
+
+ case E2BIG:
+ return false;
+
+ default:
+ /* should never happen */
+ fprintf (stderr, "Character conversion error: %s\n", strerror (errno));
+ NOT_REACHED ();
+ break;
+ }
+
+ if (outbytes == 0)
+ return false;
+
+ *op = '\0';
+ return true;
+}
+
/* Converts the string TEXT, which should be encoded in FROM-encoding, to a
dynamically allocated string in TO-encoding. Any characters which cannot be
converted will be represented by '?'.
@@ -114,17 +165,9 @@ char *
recode_string_pool (const char *to, const char *from,
const char *text, int length, struct pool *pool)
{
- char *outbuf = 0;
size_t outbufferlength;
- size_t result;
- char *op ;
- size_t inbytes = 0;
- size_t outbytes ;
iconv_t conv ;
- /* FIXME: Need to ensure that this char is valid in the target encoding */
- const char fallbackchar = '?';
-
if ( text == NULL )
return NULL;
@@ -144,70 +187,16 @@ recode_string_pool (const char *to, const char *from,
for ( outbufferlength = 1 ; outbufferlength != 0; outbufferlength <<= 1 )
if ( outbufferlength > length)
- break;
-
- outbuf = pool_malloc (pool, outbufferlength);
- op = outbuf;
-
- outbytes = outbufferlength;
- inbytes = length;
-
-
- do {
- const char *ip = text;
- result = iconv (conv, (ICONV_CONST char **) &text, &inbytes,
- &op, &outbytes);
-
- if ( -1 == result )
{
- int the_error = errno;
-
- switch (the_error)
- {
- case EILSEQ:
- case EINVAL:
- if ( outbytes > 0 )
- {
- *op++ = fallbackchar;
- outbytes--;
- text++;
- inbytes--;
- break;
- }
- /* Fall through */
- case E2BIG:
- pool_free (pool, outbuf);
- outbufferlength <<= 1;
- outbuf = pool_malloc (pool, outbufferlength);
- op = outbuf;
- outbytes = outbufferlength;
- inbytes = length;
- text = ip;
- break;
- default:
- /* should never happen */
- fprintf (stderr, "Character conversion error: %s\n",
- strerror (the_error));
- NOT_REACHED ();
- break;
- }
+ char *output = pool_malloc (pool, outbufferlength);
+ if (try_recode (conv, text, length, output, outbufferlength))
+ return output;
+ pool_free (pool, output);
}
- } while ( -1 == result );
-
- if (outbytes == 0 )
- {
- char *const oldaddr = outbuf;
- outbuf = pool_realloc (pool, outbuf, outbufferlength + 1);
- op += (outbuf - oldaddr) ;
- }
-
- *op = '\0';
-
- return outbuf;
+ NOT_REACHED ();
}
-
void
i18n_init (void)
{
@@ -311,7 +300,7 @@ i18n_done (void)
bool
valid_encoding (const char *enc)
{
- iconv_t conv = iconv_open ("UTF8", enc);
+ iconv_t conv = iconv_open (UTF8, enc);
if ( conv == (iconv_t) -1)
return false;