X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fstats%2Freliability.c;h=695beabb5706d863dd716e5d24e1612afb9c777e;hb=97de936d25fbed47960ac4ebd9a911fdd528f9e4;hp=744763382a374b815e9a235b9c86a18f82b0cc39;hpb=17d24f693f92db39158e0204d7125c5c0b9b5009;p=pspp

diff --git a/src/language/stats/reliability.c b/src/language/stats/reliability.c
index 744763382a..695beabb57 100644
--- a/src/language/stats/reliability.c
+++ b/src/language/stats/reliability.c
@@ -1,5 +1,5 @@
 /* PSPP - a program for statistical analysis.
-   Copyright (C) 2009, 2010, 2011 Free Software Foundation, Inc.
+   Copyright (C) 2009, 2010, 2011, 2013 Free Software Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -108,6 +108,26 @@ struct reliability
 
 static bool run_reliability (struct dataset *ds, const struct reliability *reliability);
 
+static void
+reliability_destroy (struct reliability *rel)
+{
+  int j;
+  ds_destroy (&rel->scale_name);
+  if (rel->sc)
+    for (j = 0; j < rel->n_sc ; ++j)
+      {
+	int x;
+	free (rel->sc[j].items);
+	moments1_destroy (rel->sc[j].total);
+	for (x = 0; x < rel->sc[j].n_items; ++x)
+	  free (rel->sc[j].m[x]);
+	free (rel->sc[j].m);
+      }
+
+  free (rel->sc);
+  free (rel->variables);
+}
+
 int
 cmd_reliability (struct lexer *lexer, struct dataset *ds)
 {
@@ -117,12 +137,14 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
   reliability.n_variables = 0;
   reliability.variables = NULL;
   reliability.model = MODEL_ALPHA;
-    reliability.exclude = MV_ANY;
+  reliability.exclude = MV_ANY;
   reliability.summary = 0;
-
+  reliability.n_sc = 0;
+  reliability.sc = NULL;
   reliability.wv = dict_get_weight (dict);
-
   reliability.total_start = 0;
+  ds_init_empty (&reliability.scale_name);
+
 
   lex_match (lexer, T_SLASH);
 
@@ -149,7 +171,7 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
       reliability.n_sc = 1;
       reliability.sc = xzalloc (sizeof (struct cronbach) * reliability.n_sc);
 
-      ds_init_cstr (&reliability.scale_name, "ANY");
+      ds_assign_cstr (&reliability.scale_name, "ANY");
 
       c = &reliability.sc[0];
       c->n_items = reliability.n_variables;
@@ -174,7 +196,7 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
 	  if ( ! lex_force_string (lexer) ) 
 	    goto error;
 
-	  ds_init_substring (&reliability.scale_name, lex_tokss (lexer));
+	  ds_assign_substring (&reliability.scale_name, lex_tokss (lexer));
 
 	  lex_get (lexer);
 
@@ -185,7 +207,7 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
 
 	  vs = const_var_set_create_from_array (reliability.variables, reliability.n_variables);
 
-
+	  free (reliability.sc->items);
 	  if (!parse_const_var_set_vars (lexer, vs, &reliability.sc->items, &reliability.sc->n_items, 0))
 	    {
 	      const_var_set_destroy (vs);
@@ -325,11 +347,11 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
   if ( ! run_reliability (ds, &reliability)) 
     goto error;
 
-  free (reliability.variables);
+  reliability_destroy (&reliability);
   return CMD_SUCCESS;
 
  error:
-  free (reliability.variables);
+  reliability_destroy (&reliability);
   return CMD_FAILURE;
 }
 
@@ -353,7 +375,6 @@ run_reliability (struct dataset *ds, const struct reliability *reliability)
 
   struct casegrouper *grouper = casegrouper_create_splits (proc_open (ds), dict);
 
-
   while (casegrouper_get_next_group (grouper, &group))
     {
       do_reliability (group, ds, reliability);