X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fstats%2Freliability.c;h=144c31125b6f7fc4ca70c22b92bb79a7abfba284;hb=refs%2Fbuilds%2F20121128032039%2Fpspp;hp=1c1212e3303d3ee3db98bec3c4142cb2a9a4d636;hpb=fe8dc2171009e90d2335f159d05f7e6660e24780;p=pspp

diff --git a/src/language/stats/reliability.c b/src/language/stats/reliability.c
index 1c1212e330..144c31125b 100644
--- a/src/language/stats/reliability.c
+++ b/src/language/stats/reliability.c
@@ -108,6 +108,25 @@ struct reliability
 
 static bool run_reliability (struct dataset *ds, const struct reliability *reliability);
 
+static void
+reliability_destroy (struct reliability *rel)
+{
+  int j;
+  ds_destroy (&rel->scale_name);
+  for (j = 0; j < rel->n_sc ; ++j)
+    {
+      int x;
+      free (rel->sc[j].items);
+      moments1_destroy (rel->sc[j].total);
+      for (x = 0; x < rel->sc[j].n_items; ++x)
+	free (rel->sc[j].m[x]);
+      free (rel->sc[j].m);
+    }
+
+  free (rel->sc);
+  free (rel->variables);
+}
+
 int
 cmd_reliability (struct lexer *lexer, struct dataset *ds)
 {
@@ -174,7 +193,7 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
 	  if ( ! lex_force_string (lexer) ) 
 	    goto error;
 
-	  ds_init_substring (&reliability.scale_name, lex_tokss (lexer));
+	  ds_assign_substring (&reliability.scale_name, lex_tokss (lexer));
 
 	  lex_get (lexer);
 
@@ -185,7 +204,7 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
 
 	  vs = const_var_set_create_from_array (reliability.variables, reliability.n_variables);
 
-
+	  free (reliability.sc->items);
 	  if (!parse_const_var_set_vars (lexer, vs, &reliability.sc->items, &reliability.sc->n_items, 0))
 	    {
 	      const_var_set_destroy (vs);
@@ -263,6 +282,12 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
       int i;
       const struct cronbach *s;
 
+      if ( reliability.split_point >= reliability.n_variables)
+        {
+          msg (ME, _("The split point must be less than the number of variables"));
+          goto error;
+        }
+
       reliability.n_sc += 2 ;
       reliability.sc = xrealloc (reliability.sc, sizeof (struct cronbach) * reliability.n_sc);
 
@@ -319,11 +344,11 @@ cmd_reliability (struct lexer *lexer, struct dataset *ds)
   if ( ! run_reliability (ds, &reliability)) 
     goto error;
 
-  free (reliability.variables);
+  reliability_destroy (&reliability);
   return CMD_SUCCESS;
 
  error:
-  free (reliability.variables);
+  reliability_destroy (&reliability);
   return CMD_FAILURE;
 }
 
@@ -347,7 +372,6 @@ run_reliability (struct dataset *ds, const struct reliability *reliability)
 
   struct casegrouper *grouper = casegrouper_create_splits (proc_open (ds), dict);
 
-
   while (casegrouper_get_next_group (grouper, &group))
     {
       do_reliability (group, ds, reliability);
@@ -472,7 +496,7 @@ do_reliability (struct casereader *input, struct dataset *ds,
 	alpha (s->n_items, s->sum_of_variances, s->variance_of_sums);
     }
 
-  text_item_submit (text_item_create_format (TEXT_ITEM_PARAGRAPH, "Scale: %s",
+  text_item_submit (text_item_create_format (TEXT_ITEM_PARAGRAPH, _("Scale: %s"),
                                              ds_cstr (&rel->scale_name)));
 
   case_processing_summary (n_valid, n_missing, dataset_dict (ds));