X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fstats%2Fregression.q;h=7b02e4b9dcfdaed3dc669efdbc5129071cc28d97;hb=7a887989fb1da56ebd264ee3338c1472c7e40a51;hp=609ec3953f5dd9ca2fde7a91b96d9eacfc7ad3a4;hpb=afbd9bcace01167e6e2d00031e523aa80e68a4fb;p=pspp-builds.git

diff --git a/src/language/stats/regression.q b/src/language/stats/regression.q
index 609ec395..7b02e4b9 100644
--- a/src/language/stats/regression.q
+++ b/src/language/stats/regression.q
@@ -92,9 +92,6 @@ struct moments_var
   const struct variable *v;
 };
 
-/* Linear regression models. */
-static pspp_linreg_cache **models = NULL;
-
 /*
   Transformations for saving predicted values
   and residuals, etc.
@@ -122,7 +119,7 @@ static size_t n_variables;
 static struct file_handle *model_file;
 
 static bool run_regression (struct casereader *, struct cmd_regression *,
-			    struct dataset *);
+			    struct dataset *, pspp_linreg_cache **);
 
 /*
    STATISTICS subcommand output functions.
@@ -948,6 +945,7 @@ cmd_regression (struct lexer *lexer, struct dataset *ds)
 {
   struct casegrouper *grouper;
   struct casereader *group;
+  pspp_linreg_cache **models;
   bool ok;
   size_t i;
 
@@ -963,13 +961,15 @@ cmd_regression (struct lexer *lexer, struct dataset *ds)
   /* Data pass. */
   grouper = casegrouper_create_splits (proc_open (ds), dataset_dict (ds));
   while (casegrouper_get_next_group (grouper, &group))
-    run_regression (group, &cmd, ds);
+    run_regression (group, &cmd, ds, models);
   ok = casegrouper_destroy (grouper);
   ok = proc_commit (ds) && ok;
 
   subcommand_save (ds, cmd.sbc_save, models);
   free (v_variables);
   free (models);
+  free_regression (&cmd);
+
   return ok ? CMD_SUCCESS : CMD_FAILURE;
 }
 
@@ -1122,7 +1122,7 @@ compute_moments (pspp_linreg_cache * c, struct moments_var *mom,
 
 static bool
 run_regression (struct casereader *input, struct cmd_regression *cmd,
-		struct dataset *ds)
+		struct dataset *ds, pspp_linreg_cache **models)
 {
   size_t i;
   int n_indep = 0;
@@ -1138,7 +1138,10 @@ run_regression (struct casereader *input, struct cmd_regression *cmd,
   assert (models != NULL);
 
   if (!casereader_peek (input, 0, &c))
-    return true;
+    {
+      casereader_destroy (input);
+      return true;
+    }
   output_split_file_values (ds, &c);
   case_destroy (&c);
 
@@ -1198,8 +1201,6 @@ run_regression (struct casereader *input, struct cmd_regression *cmd,
 	      lopts.get_indep_mean_std[i] = 1;
 	    }
 	  models[k] = pspp_linreg_cache_alloc (X->m->size1, X->m->size2);
-	  models[k]->indep_means = gsl_vector_alloc (X->m->size2);
-	  models[k]->indep_std = gsl_vector_alloc (X->m->size2);
 	  models[k]->depvar = dep_var;
 	  /*
 	     For large data sets, use QR decomposition.
@@ -1255,6 +1256,11 @@ run_regression (struct casereader *input, struct cmd_regression *cmd,
 	}
       casereader_destroy (reader);
     }
+  for (i = 0; i < n_variables; i++)
+    {
+      moments1_destroy ((mom + i)->m);
+    }
+  free (mom);
   free (indep_vars);
   free (lopts.get_indep_mean_std);
   casereader_destroy (input);