X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fexpressions%2Fparse.c;h=f2b4f1c78b4cc2b4a85f6ea752e74990d19c952b;hb=751d7694b0904b580fad3903205341c85c04d421;hp=72604ed95236b0101341e020c18114b7cb2bbe93;hpb=e9aa6e433b846849da90550f6800095d569fb549;p=pspp diff --git a/src/language/expressions/parse.c b/src/language/expressions/parse.c index 72604ed952..f2b4f1c78b 100644 --- a/src/language/expressions/parse.c +++ b/src/language/expressions/parse.c @@ -1,46 +1,49 @@ -/* PSPP - computes sample statistics. - Copyright (C) 1997-9, 2000 Free Software Foundation, Inc. - Written by Ben Pfaff . +/* PSPP - a program for statistical analysis. + Copyright (C) 1997-9, 2000, 2006, 2010 Free Software Foundation, Inc. - This program is free software; you can redistribute it and/or - modify it under the terms of the GNU General Public License as - published by the Free Software Foundation; either version 2 of the - License, or (at your option) any later version. + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. - This program is distributed in the hope that it will be useful, but - WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - General Public License for more details. + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA - 02110-1301, USA. */ + along with this program. If not, see . */ #include + #include "private.h" + #include #include #include #include -#include -#include + +#include "helpers.h" #include #include -#include -#include "helpers.h" +#include +#include +#include #include #include +#include +#include +#include #include #include -#include #include -#include + +#include "xalloc.h" /* Declarations. */ /* Recursive descent parser in order of increasing precedence. */ -typedef union any_node *parse_recursively_func (struct expression *); +typedef union any_node *parse_recursively_func (struct lexer *, struct expression *); static parse_recursively_func parse_or, parse_and, parse_not; static parse_recursively_func parse_rel, parse_add, parse_mul; static parse_recursively_func parse_neg, parse_exp; @@ -48,7 +51,7 @@ static parse_recursively_func parse_primary; static parse_recursively_func parse_vector_element, parse_function; /* Utility functions. */ -static struct expression *expr_create (struct dictionary *); +static struct expression *expr_create (struct dataset *ds); atom_type expr_node_returns (const union any_node *); static const char *atom_type_name (atom_type); @@ -57,7 +60,7 @@ static struct expression *finish_expression (union any_node *, static bool type_check (struct expression *, union any_node **, enum expr_type expected_type); static union any_node *allocate_unary_variable (struct expression *, - struct variable *); + const struct variable *); /* Public functions. */ @@ -68,21 +71,21 @@ static union any_node *allocate_unary_variable (struct expression *, Returns the new expression if successful or a null pointer otherwise. */ struct expression * -expr_parse (struct dictionary *dict, enum expr_type type) +expr_parse (struct lexer *lexer, struct dataset *ds, enum expr_type type) { union any_node *n; struct expression *e; assert (type == EXPR_NUMBER || type == EXPR_STRING || type == EXPR_BOOLEAN); - e = expr_create (dict); - n = parse_or (e); + e = expr_create (ds); + n = parse_or (lexer, e); if (n != NULL && type_check (e, &n, type)) return finish_expression (expr_optimize (n, e), e); else { expr_free (e); - return NULL; + return NULL; } } @@ -90,10 +93,12 @@ expr_parse (struct dictionary *dict, enum expr_type type) expr_parse(), and sets up so that destroying POOL will free the expression as well. */ struct expression * -expr_parse_pool (struct pool *pool, - struct dictionary *dict, enum expr_type type) +expr_parse_pool (struct lexer *lexer, + struct pool *pool, + struct dataset *ds, + enum expr_type type) { - struct expression *e = expr_parse (dict, type); + struct expression *e = expr_parse (lexer, ds, type); if (e != NULL) pool_add_subpool (pool, e->expr_pool); return e; @@ -108,19 +113,19 @@ expr_free (struct expression *e) } struct expression * -expr_parse_any (struct dictionary *dict, bool optimize) +expr_parse_any (struct lexer *lexer, struct dataset *ds, bool optimize) { union any_node *n; struct expression *e; - e = expr_create (dict); - n = parse_or (e); + e = expr_create (ds); + n = parse_or (lexer, e); if (n == NULL) { expr_free (e); return NULL; } - + if (optimize) n = expr_optimize (n, e); return finish_expression (n, e); @@ -129,7 +134,7 @@ expr_parse_any (struct dictionary *dict, bool optimize) /* Finishing up expression building. */ /* Height of an expression's stacks. */ -struct stack_heights +struct stack_heights { int number_height; /* Height of number stack. */ int string_height; /* Height of string stack. */ @@ -146,8 +151,8 @@ static const struct stack_heights * atom_type_stack (atom_type type) { assert (is_atom (type)); - - switch (type) + + switch (type) { case OP_number: case OP_boolean: @@ -165,9 +170,9 @@ atom_type_stack (atom_type type) case OP_pos_int: case OP_vector: return ¬_on_stack; - + default: - abort (); + NOT_REACHED (); } } @@ -181,7 +186,7 @@ measure_stack (const union any_node *n, { const struct stack_heights *return_height; - if (is_composite (n->type)) + if (is_composite (n->type)) { struct stack_heights args; int i; @@ -206,7 +211,7 @@ measure_stack (const union any_node *n, /* Allocates stacks within E sufficient for evaluating node N. */ static void -allocate_stacks (union any_node *n, struct expression *e) +allocate_stacks (union any_node *n, struct expression *e) { struct stack_heights initial = {0, 0}; struct stack_heights max = {0, 0}; @@ -245,7 +250,7 @@ type_check (struct expression *e, { atom_type actual_type = expr_node_returns (*n); - switch (expected_type) + switch (expected_type) { case EXPR_BOOLEAN: case EXPR_NUMBER: @@ -259,7 +264,7 @@ type_check (struct expression *e, if (actual_type == OP_number && expected_type == OP_boolean) *n = expr_allocate_unary (e, OP_NUM_TO_BOOLEAN, *n); break; - + case EXPR_STRING: if (actual_type != OP_string) { @@ -271,9 +276,9 @@ type_check (struct expression *e, break; default: - abort (); + NOT_REACHED (); } - + return true; } @@ -297,12 +302,12 @@ type_coercion_core (struct expression *e, atom_type required_type, union any_node **node, const char *operator_name, - bool do_coercion) + bool do_coercion) { atom_type actual_type; assert (!!do_coercion == (e != NULL)); - if (*node == NULL) + if (*node == NULL) { /* Propagate error. Whatever caused the original error already emitted an error message. */ @@ -310,23 +315,23 @@ type_coercion_core (struct expression *e, } actual_type = expr_node_returns (*node); - if (actual_type == required_type) + if (actual_type == required_type) { /* Type match. */ - return true; + return true; } - switch (required_type) + switch (required_type) { case OP_number: - if (actual_type == OP_boolean) + if (actual_type == OP_boolean) { /* To enforce strict typing rules, insert Boolean to numeric "conversion". This conversion is a no-op, so it will be removed later. */ if (do_coercion) *node = expr_allocate_unary (e, OP_BOOLEAN_TO_NUM, *node); - return true; + return true; } break; @@ -339,34 +344,46 @@ type_coercion_core (struct expression *e, { /* Convert numeric to boolean. */ if (do_coercion) - *node = expr_allocate_unary (e, OP_NUM_TO_BOOLEAN, *node); + { + union any_node *op_name; + + op_name = expr_allocate_string (e, ss_cstr (operator_name)); + *node = expr_allocate_binary (e, OP_NUM_TO_BOOLEAN, *node, + op_name); + } return true; } break; case OP_format: - abort (); + NOT_REACHED (); case OP_ni_format: + msg_disable (); if ((*node)->type == OP_format - && check_input_specifier (&(*node)->format.f, false) - && check_specifier_type (&(*node)->format.f, NUMERIC, false)) + && fmt_check_input (&(*node)->format.f) + && fmt_check_type_compat (&(*node)->format.f, VAL_NUMERIC)) { + msg_enable (); if (do_coercion) (*node)->type = OP_ni_format; return true; } + msg_enable (); break; case OP_no_format: + msg_disable (); if ((*node)->type == OP_format - && check_output_specifier (&(*node)->format.f, false) - && check_specifier_type (&(*node)->format.f, NUMERIC, false)) + && fmt_check_output (&(*node)->format.f) + && fmt_check_type_compat (&(*node)->format.f, VAL_NUMERIC)) { + msg_enable (); if (do_coercion) (*node)->type = OP_no_format; return true; } + msg_enable (); break; case OP_num_var: @@ -387,10 +404,19 @@ type_coercion_core (struct expression *e, } break; + case OP_var: + if ((*node)->type == OP_NUM_VAR || (*node)->type == OP_STR_VAR) + { + if (do_coercion) + *node = (*node)->composite.args[0]; + return true; + } + break; + case OP_pos_int: if ((*node)->type == OP_number && floor ((*node)->number.n) == (*node)->number.n - && (*node)->number.n > 0 && (*node)->number.n < INT_MAX) + && (*node)->number.n > 0 && (*node)->number.n < INT_MAX) { if (do_coercion) *node = expr_allocate_pos_int (e, (*node)->number.n); @@ -399,10 +425,10 @@ type_coercion_core (struct expression *e, break; default: - abort (); + NOT_REACHED (); } - if (do_coercion) + if (do_coercion) { msg (SE, _("Type mismatch while applying %s operator: " "cannot convert %s to %s."), @@ -443,6 +469,16 @@ is_coercible (atom_type required_type, union any_node *const *node) (union any_node **) node, NULL, false); } +/* Returns true if ACTUAL_TYPE is a kind of REQUIRED_TYPE, false + otherwise. */ +static bool +is_compatible (atom_type required_type, atom_type actual_type) +{ + return (required_type == actual_type + || (required_type == OP_var + && (actual_type == OP_num_var || actual_type == OP_str_var))); +} + /* How to parse an operator. */ struct operator { @@ -457,16 +493,16 @@ struct operator On failure, returns false and, if OPERATOR is non-null, sets *OPERATOR to a null pointer. */ static bool -match_operator (const struct operator ops[], size_t op_cnt, - const struct operator **operator) +match_operator (struct lexer *lexer, const struct operator ops[], size_t op_cnt, + const struct operator **operator) { const struct operator *op; for (op = ops; op < ops + op_cnt; op++) { if (op->token == '-') - lex_negative_to_dash (); - if (lex_match (op->token)) + lex_negative_to_dash (lexer); + if (lex_match (lexer, op->token)) { if (operator != NULL) *operator = op; @@ -479,7 +515,7 @@ match_operator (const struct operator ops[], size_t op_cnt, } static bool -check_operator (const struct operator *op, int arg_cnt, atom_type arg_type) +check_operator (const struct operator *op, int arg_cnt, atom_type arg_type) { const struct operation *o; size_t i; @@ -488,8 +524,8 @@ check_operator (const struct operator *op, int arg_cnt, atom_type arg_type) o = &operations[op->type]; assert (o->arg_cnt == arg_cnt); assert ((o->flags & OPF_ARRAY_OPERAND) == 0); - for (i = 0; i < arg_cnt; i++) - assert (o->args[i] == arg_type); + for (i = 0; i < arg_cnt; i++) + assert (is_compatible (arg_type, o->args[i])); return true; } @@ -505,7 +541,7 @@ check_binary_operators (const struct operator ops[], size_t op_cnt, } static atom_type -get_operand_type (const struct operator *op) +get_operand_type (const struct operator *op) { return operations[op->type].args[0]; } @@ -517,7 +553,7 @@ get_operand_type (const struct operator *op) is non-null, then it will be issued as a warning if more than one operator/operand pair is parsed. */ static union any_node * -parse_binary_operators (struct expression *e, union any_node *node, +parse_binary_operators (struct lexer *lexer, struct expression *e, union any_node *node, const struct operator ops[], size_t op_cnt, parse_recursively_func *parse_next_level, const char *chain_warning) @@ -530,7 +566,7 @@ parse_binary_operators (struct expression *e, union any_node *node, if (node == NULL) return node; - for (op_count = 0; match_operator (ops, op_cnt, &operator); op_count++) + for (op_count = 0; match_operator (lexer, ops, op_cnt, &operator); op_count++) { union any_node *rhs; @@ -540,22 +576,22 @@ parse_binary_operators (struct expression *e, union any_node *node, /* Parse the right-hand side and coerce to type OPERAND_TYPE. */ - rhs = parse_next_level (e); + rhs = parse_next_level (lexer, e); if (!type_coercion (e, operand_type, &rhs, operator->name)) return NULL; node = expr_allocate_binary (e, operator->type, node, rhs); } if (op_count > 1 && chain_warning != NULL) - msg (SW, chain_warning); + msg (SW, "%s", chain_warning); return node; } static union any_node * -parse_inverting_unary_operator (struct expression *e, +parse_inverting_unary_operator (struct lexer *lexer, struct expression *e, const struct operator *op, - parse_recursively_func *parse_next_level) + parse_recursively_func *parse_next_level) { union any_node *node; unsigned op_count; @@ -563,10 +599,10 @@ parse_inverting_unary_operator (struct expression *e, check_operator (op, 1, get_operand_type (op)); op_count = 0; - while (match_operator (op, 1, NULL)) + while (match_operator (lexer, op, 1, NULL)) op_count++; - node = parse_next_level (e); + node = parse_next_level (lexer, e); if (op_count > 0 && type_coercion (e, get_operand_type (op), &node, op->name) && op_count % 2 != 0) @@ -577,87 +613,90 @@ parse_inverting_unary_operator (struct expression *e, /* Parses the OR level. */ static union any_node * -parse_or (struct expression *e) +parse_or (struct lexer *lexer, struct expression *e) { - static const struct operator op = - { T_OR, OP_OR, "logical disjunction (\"OR\")" }; - - return parse_binary_operators (e, parse_and (e), &op, 1, parse_and, NULL); + static const struct operator op = + { T_OR, OP_OR, "logical disjunction (`OR')" }; + + return parse_binary_operators (lexer, e, parse_and (lexer, e), &op, 1, parse_and, NULL); } /* Parses the AND level. */ static union any_node * -parse_and (struct expression *e) +parse_and (struct lexer *lexer, struct expression *e) { - static const struct operator op = - { T_AND, OP_AND, "logical conjunction (\"AND\")" }; - - return parse_binary_operators (e, parse_not (e), &op, 1, parse_not, NULL); + static const struct operator op = + { T_AND, OP_AND, "logical conjunction (`AND')" }; + + return parse_binary_operators (lexer, e, parse_not (lexer, e), + &op, 1, parse_not, NULL); } /* Parses the NOT level. */ static union any_node * -parse_not (struct expression *e) +parse_not (struct lexer *lexer, struct expression *e) { static const struct operator op - = { T_NOT, OP_NOT, "logical negation (\"NOT\")" }; - return parse_inverting_unary_operator (e, &op, parse_rel); + = { T_NOT, OP_NOT, "logical negation (`NOT')" }; + return parse_inverting_unary_operator (lexer, e, &op, parse_rel); } /* Parse relational operators. */ static union any_node * -parse_rel (struct expression *e) +parse_rel (struct lexer *lexer, struct expression *e) { - const char *chain_warning = - _("Chaining relational operators (e.g. \"a < b < c\") will " + const char *chain_warning = + _("Chaining relational operators (e.g. `a < b < c') will " "not produce the mathematically expected result. " "Use the AND logical operator to fix the problem " - "(e.g. \"a < b AND b < c\"). " + "(e.g. `a < b AND b < c'). " "If chaining is really intended, parentheses will disable " - "this warning (e.g. \"(a < b) < c\".)"); + "this warning (e.g. `(a < b) < c'.)"); - union any_node *node = parse_add (e); + union any_node *node = parse_add (lexer, e); if (node == NULL) return NULL; - - switch (expr_node_returns (node)) + + switch (expr_node_returns (node)) { case OP_number: - case OP_boolean: + case OP_boolean: { static const struct operator ops[] = { - { '=', OP_EQ, "numeric equality (\"=\")" }, - { T_EQ, OP_EQ, "numeric equality (\"EQ\")" }, - { T_GE, OP_GE, "numeric greater-than-or-equal-to (\">=\")" }, - { T_GT, OP_GT, "numeric greater than (\">\")" }, - { T_LE, OP_LE, "numeric less-than-or-equal-to (\"<=\")" }, - { T_LT, OP_LT, "numeric less than (\"<\")" }, - { T_NE, OP_NE, "numeric inequality (\"<>\")" }, + { '=', OP_EQ, "numeric equality (`=')" }, + { T_EQ, OP_EQ, "numeric equality (`EQ')" }, + { T_GE, OP_GE, "numeric greater-than-or-equal-to (`>=')" }, + { T_GT, OP_GT, "numeric greater than (`>')" }, + { T_LE, OP_LE, "numeric less-than-or-equal-to (`<=')" }, + { T_LT, OP_LT, "numeric less than (`<')" }, + { T_NE, OP_NE, "numeric inequality (`<>')" }, }; - return parse_binary_operators (e, node, ops, sizeof ops / sizeof *ops, + return parse_binary_operators (lexer, e, node, ops, + sizeof ops / sizeof *ops, parse_add, chain_warning); } - + case OP_string: { static const struct operator ops[] = { - { '=', OP_EQ_STRING, "string equality (\"=\")" }, - { T_EQ, OP_EQ_STRING, "string equality (\"EQ\")" }, - { T_GE, OP_GE_STRING, "string greater-than-or-equal-to (\">=\")" }, - { T_GT, OP_GT_STRING, "string greater than (\">\")" }, - { T_LE, OP_LE_STRING, "string less-than-or-equal-to (\"<=\")" }, - { T_LT, OP_LT_STRING, "string less than (\"<\")" }, - { T_NE, OP_NE_STRING, "string inequality (\"<>\")" }, + { '=', OP_EQ_STRING, "string equality (`=')" }, + { T_EQ, OP_EQ_STRING, "string equality (`EQ')" }, + { T_GE, OP_GE_STRING, "string greater-than-or-equal-to (`>=')" }, + { T_GT, OP_GT_STRING, "string greater than (`>')" }, + { T_LE, OP_LE_STRING, "string less-than-or-equal-to (`<=')" }, + { T_LT, OP_LT_STRING, "string less than (`<')" }, + { T_NE, OP_NE_STRING, "string inequality (`<>')" }, }; - return parse_binary_operators (e, node, ops, sizeof ops / sizeof *ops, + return parse_binary_operators (lexer, e, node, ops, + sizeof ops / sizeof *ops, parse_add, chain_warning); } - + default: return node; } @@ -665,65 +704,65 @@ parse_rel (struct expression *e) /* Parses the addition and subtraction level. */ static union any_node * -parse_add (struct expression *e) +parse_add (struct lexer *lexer, struct expression *e) { - static const struct operator ops[] = + static const struct operator ops[] = { - { '+', OP_ADD, "addition (\"+\")" }, - { '-', OP_SUB, "subtraction (\"-\")" }, + { '+', OP_ADD, "addition (`+')" }, + { '-', OP_SUB, "subtraction (`-')" }, }; - - return parse_binary_operators (e, parse_mul (e), + + return parse_binary_operators (lexer, e, parse_mul (lexer, e), ops, sizeof ops / sizeof *ops, parse_mul, NULL); } /* Parses the multiplication and division level. */ static union any_node * -parse_mul (struct expression *e) +parse_mul (struct lexer *lexer, struct expression *e) { - static const struct operator ops[] = + static const struct operator ops[] = { - { '*', OP_MUL, "multiplication (\"*\")" }, - { '/', OP_DIV, "division (\"/\")" }, + { '*', OP_MUL, "multiplication (`*')" }, + { '/', OP_DIV, "division (`/')" }, }; - - return parse_binary_operators (e, parse_neg (e), + + return parse_binary_operators (lexer, e, parse_neg (lexer, e), ops, sizeof ops / sizeof *ops, parse_neg, NULL); } /* Parses the unary minus level. */ static union any_node * -parse_neg (struct expression *e) +parse_neg (struct lexer *lexer, struct expression *e) { - static const struct operator op = { '-', OP_NEG, "negation (\"-\")" }; - return parse_inverting_unary_operator (e, &op, parse_exp); + static const struct operator op = { '-', OP_NEG, "negation (`-')" }; + return parse_inverting_unary_operator (lexer, e, &op, parse_exp); } static union any_node * -parse_exp (struct expression *e) +parse_exp (struct lexer *lexer, struct expression *e) { - static const struct operator op = - { T_EXP, OP_POW, "exponentiation (\"**\")" }; - - const char *chain_warning = - _("The exponentiation operator (\"**\") is left-associative, " + static const struct operator op = + { T_EXP, OP_POW, "exponentiation (`**')" }; + + const char *chain_warning = + _("The exponentiation operator (`**') is left-associative, " "even though right-associative semantics are more useful. " - "That is, \"a**b**c\" equals \"(a**b)**c\", not as \"a**(b**c)\". " + "That is, `a**b**c' equals `(a**b)**c', not as `a**(b**c)'. " "To disable this warning, insert parentheses."); - return parse_binary_operators (e, parse_primary (e), &op, 1, + return parse_binary_operators (lexer, e, parse_primary (lexer, e), &op, 1, parse_primary, chain_warning); } /* Parses system variables. */ static union any_node * -parse_sysvar (struct expression *e) +parse_sysvar (struct lexer *lexer, struct expression *e) { - if (lex_match_id ("$CASENUM")) + if (lex_match_id (lexer, "$CASENUM")) return expr_allocate_nullary (e, OP_CASENUM); - else if (lex_match_id ("$DATE")) + else if (lex_match_id (lexer, "$DATE")) { static const char *months[12] = { @@ -731,7 +770,7 @@ parse_sysvar (struct expression *e) "JUL", "AUG", "SEP", "OCT", "NOV", "DEC", }; - time_t last_proc_time = time_of_last_procedure (); + time_t last_proc_time = time_of_last_procedure (e->ds); struct tm *time; char temp_buf[10]; @@ -741,23 +780,23 @@ parse_sysvar (struct expression *e) return expr_allocate_string_buffer (e, temp_buf, strlen (temp_buf)); } - else if (lex_match_id ("$TRUE")) + else if (lex_match_id (lexer, "$TRUE")) return expr_allocate_boolean (e, 1.0); - else if (lex_match_id ("$FALSE")) + else if (lex_match_id (lexer, "$FALSE")) return expr_allocate_boolean (e, 0.0); - else if (lex_match_id ("$SYSMIS")) + else if (lex_match_id (lexer, "$SYSMIS")) return expr_allocate_number (e, SYSMIS); - else if (lex_match_id ("$JDATE")) + else if (lex_match_id (lexer, "$JDATE")) { - time_t time = time_of_last_procedure (); + time_t time = time_of_last_procedure (e->ds); struct tm *tm = localtime (&time); return expr_allocate_number (e, expr_ymd_to_ofs (tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday)); } - else if (lex_match_id ("$TIME")) + else if (lex_match_id (lexer, "$TIME")) { - time_t time = time_of_last_procedure (); + time_t time = time_of_last_procedure (e->ds); struct tm *tm = localtime (&time); return expr_allocate_number (e, expr_ymd_to_date (tm->tm_year + 1900, @@ -767,96 +806,99 @@ parse_sysvar (struct expression *e) + tm->tm_min * 60. + tm->tm_sec); } - else if (lex_match_id ("$LENGTH")) - return expr_allocate_number (e, get_viewlength ()); - else if (lex_match_id ("$WIDTH")) - return expr_allocate_number (e, get_viewwidth ()); + else if (lex_match_id (lexer, "$LENGTH")) + return expr_allocate_number (e, settings_get_viewlength ()); + else if (lex_match_id (lexer, "$WIDTH")) + return expr_allocate_number (e, settings_get_viewwidth ()); else { - msg (SE, _("Unknown system variable %s."), tokid); + msg (SE, _("Unknown system variable %s."), lex_tokid (lexer)); return NULL; } } /* Parses numbers, varnames, etc. */ static union any_node * -parse_primary (struct expression *e) +parse_primary (struct lexer *lexer, struct expression *e) { - switch (token) + switch (lex_token (lexer)) { case T_ID: - if (lex_look_ahead () == '(') + if (lex_look_ahead (lexer) == '(') { /* An identifier followed by a left parenthesis may be a vector element reference. If not, it's a function call. */ - if (e->dict != NULL && dict_lookup_vector (e->dict, tokid) != NULL) - return parse_vector_element (e); + if (e->ds != NULL && dict_lookup_vector (dataset_dict (e->ds), lex_tokid (lexer)) != NULL) + return parse_vector_element (lexer, e); else - return parse_function (e); + return parse_function (lexer, e); } - else if (tokid[0] == '$') + else if (lex_tokid (lexer)[0] == '$') { /* $ at the beginning indicates a system variable. */ - return parse_sysvar (e); + return parse_sysvar (lexer, e); } - else if (e->dict != NULL && dict_lookup_var (e->dict, tokid)) + else if (e->ds != NULL && dict_lookup_var (dataset_dict (e->ds), lex_tokid (lexer))) { /* It looks like a user variable. (It could be a format specifier, but we'll assume it's a variable unless proven otherwise. */ - return allocate_unary_variable (e, parse_dict_variable (e->dict)); + return allocate_unary_variable (e, parse_variable (lexer, dataset_dict (e->ds))); } - else + else { /* Try to parse it as a format specifier. */ struct fmt_spec fmt; - if (parse_format_specifier (&fmt, FMTP_SUPPRESS_ERRORS)) + bool ok; + + msg_disable (); + ok = parse_format_specifier (lexer, &fmt); + msg_enable (); + + if (ok) return expr_allocate_format (e, &fmt); /* All attempts failed. */ - msg (SE, _("Unknown identifier %s."), tokid); + msg (SE, _("Unknown identifier %s."), lex_tokid (lexer)); return NULL; } break; - - case T_POS_NUM: - case T_NEG_NUM: + + case T_POS_NUM: + case T_NEG_NUM: { - union any_node *node = expr_allocate_number (e, tokval); - lex_get (); - return node; + union any_node *node = expr_allocate_number (e, lex_tokval (lexer) ); + lex_get (lexer); + return node; } case T_STRING: { union any_node *node = expr_allocate_string_buffer ( - e, ds_cstr (&tokstr), ds_length (&tokstr)); - lex_get (); + e, ds_cstr (lex_tokstr (lexer) ), ds_length (lex_tokstr (lexer) )); + lex_get (lexer); return node; } case '(': { union any_node *node; - lex_get (); - node = parse_or (e); - if (node != NULL && !lex_match (')')) - { - lex_error (_("expecting `)'")); - return NULL; - } + lex_get (lexer); + node = parse_or (lexer, e); + if (node != NULL && !lex_force_match (lexer, ')')) + return NULL; return node; } default: - lex_error (_("in expression")); + lex_error (lexer, NULL); return NULL; } } static union any_node * -parse_vector_element (struct expression *e) +parse_vector_element (struct lexer *lexer, struct expression *e) { const struct vector *vector; union any_node *element; @@ -864,45 +906,45 @@ parse_vector_element (struct expression *e) /* Find vector, skip token. The caller must already have verified that the current token is the name of a vector. */ - vector = dict_lookup_vector (default_dict, tokid); + vector = dict_lookup_vector (dataset_dict (e->ds), lex_tokid (lexer)); assert (vector != NULL); - lex_get (); + lex_get (lexer); /* Skip left parenthesis token. The caller must have verified that the lookahead is a left parenthesis. */ - assert (token == '('); - lex_get (); + assert (lex_token (lexer) == '('); + lex_get (lexer); - element = parse_or (e); + element = parse_or (lexer, e); if (!type_coercion (e, OP_number, &element, "vector indexing") - || !lex_match (')')) + || !lex_match (lexer, ')')) return NULL; - return expr_allocate_binary (e, (vector->var[0]->type == NUMERIC + return expr_allocate_binary (e, (vector_get_type (vector) == VAL_NUMERIC ? OP_VEC_ELEM_NUM : OP_VEC_ELEM_STR), element, expr_allocate_vector (e, vector)); } /* Individual function parsing. */ -struct operation operations[OP_first + OP_cnt] = { +const struct operation operations[OP_first + OP_cnt] = { #include "parse.inc" }; - + static bool -word_matches (const char **test, const char **name) +word_matches (const char **test, const char **name) { size_t test_len = strcspn (*test, "."); size_t name_len = strcspn (*name, "."); - if (test_len == name_len) + if (test_len == name_len) { if (buf_compare_case (*test, *name, test_len)) return false; } else if (test_len < 3 || test_len > name_len) return false; - else + else { if (buf_compare_case (*test, *name, test_len)) return false; @@ -922,9 +964,12 @@ word_matches (const char **test, const char **name) } static int -compare_names (const char *test, const char *name) +compare_names (const char *test, const char *name, bool abbrev_ok) { - for (;;) + if (!abbrev_ok) + return true; + + for (;;) { if (!word_matches (&test, &name)) return true; @@ -934,31 +979,33 @@ compare_names (const char *test, const char *name) } static int -compare_strings (const char *test, const char *name) +compare_strings (const char *test, const char *name, bool abbrev_ok UNUSED) { return strcasecmp (test, name); } static bool lookup_function_helper (const char *name, - int (*compare) (const char *test, const char *name), + int (*compare) (const char *test, const char *name, + bool abbrev_ok), const struct operation **first, const struct operation **last) { - struct operation *f; - + const struct operation *f; + for (f = operations + OP_function_first; - f <= operations + OP_function_last; f++) - if (!compare (name, f->name)) + f <= operations + OP_function_last; f++) + if (!compare (name, f->name, !(f->flags & OPF_NO_ABBREV))) { *first = f; - while (f <= operations + OP_function_last && !compare (name, f->name)) + while (f <= operations + OP_function_last + && !compare (name, f->name, !(f->flags & OPF_NO_ABBREV))) f++; *last = f; return true; - } + } return false; } @@ -966,7 +1013,7 @@ lookup_function_helper (const char *name, static bool lookup_function (const char *name, const struct operation **first, - const struct operation **last) + const struct operation **last) { *first = *last = NULL; return (lookup_function_helper (name, compare_strings, first, last) @@ -974,7 +1021,7 @@ lookup_function (const char *name, } static int -extract_min_valid (char *s) +extract_min_valid (char *s) { char *p = strrchr (s, '.'); if (p == NULL @@ -986,7 +1033,7 @@ extract_min_valid (char *s) } static atom_type -function_arg_type (const struct operation *f, size_t arg_idx) +function_arg_type (const struct operation *f, size_t arg_idx) { assert (arg_idx < f->arg_cnt || (f->flags & OPF_ARRAY_OPERAND)); @@ -1005,26 +1052,26 @@ match_function (union any_node **args, int arg_cnt, const struct operation *f) for (i = 0; i < arg_cnt; i++) if (!is_coercible (function_arg_type (f, i), &args[i])) - return false; + return false; return true; } static void coerce_function_args (struct expression *e, const struct operation *f, - union any_node **args, size_t arg_cnt) + union any_node **args, size_t arg_cnt) { int i; - + for (i = 0; i < arg_cnt; i++) type_coercion_assert (e, function_arg_type (f, i), &args[i]); } static bool -validate_function_args (const struct operation *f, int arg_cnt, int min_valid) +validate_function_args (const struct operation *f, int arg_cnt, int min_valid) { int array_arg_cnt = arg_cnt - (f->arg_cnt - 1); - if (array_arg_cnt < f->array_min_elems) + if (array_arg_cnt < f->array_min_elems) { msg (SE, _("%s must have at least %d arguments in list."), f->prototype, f->array_min_elems); @@ -1032,27 +1079,27 @@ validate_function_args (const struct operation *f, int arg_cnt, int min_valid) } if ((f->flags & OPF_ARRAY_OPERAND) - && array_arg_cnt % f->array_granularity != 0) + && array_arg_cnt % f->array_granularity != 0) { if (f->array_granularity == 2) - msg (SE, _("%s must have even number of arguments in list."), + msg (SE, _("%s must have an even number of arguments in list."), f->prototype); else msg (SE, _("%s must have multiple of %d arguments in list."), f->prototype, f->array_granularity); return false; } - - if (min_valid != -1) + + if (min_valid != -1) { - if (f->array_min_elems == 0) + if (f->array_min_elems == 0) { assert ((f->flags & OPF_MIN_VALID) == 0); msg (SE, _("%s function does not accept a minimum valid " "argument count."), f->prototype); return false; } - else + else { assert (f->flags & OPF_MIN_VALID); if (array_arg_cnt < f->array_min_elems) @@ -1061,7 +1108,7 @@ validate_function_args (const struct operation *f, int arg_cnt, int min_valid) f->prototype, f->array_min_elems); return false; } - else if (min_valid > array_arg_cnt) + else if (min_valid > array_arg_cnt) { msg (SE, _("With %s, " "using minimum valid argument count of %d " @@ -1080,7 +1127,7 @@ static void add_arg (union any_node ***args, int *arg_cnt, int *arg_cap, union any_node *arg) { - if (*arg_cnt >= *arg_cap) + if (*arg_cnt >= *arg_cap) { *arg_cap += 8; *args = xrealloc (*args, sizeof **args * *arg_cap); @@ -1091,7 +1138,7 @@ add_arg (union any_node ***args, int *arg_cnt, int *arg_cap, static void put_invocation (struct string *s, - const char *func_name, union any_node **args, size_t arg_cnt) + const char *func_name, union any_node **args, size_t arg_cnt) { size_t i; @@ -1108,19 +1155,19 @@ put_invocation (struct string *s, static void no_match (const char *func_name, union any_node **args, size_t arg_cnt, - const struct operation *first, const struct operation *last) + const struct operation *first, const struct operation *last) { struct string s; const struct operation *f; ds_init_empty (&s); - if (last - first == 1) + if (last - first == 1) { ds_put_format (&s, _("Type mismatch invoking %s as "), first->prototype); put_invocation (&s, func_name, args, arg_cnt); } - else + else { ds_put_cstr (&s, _("Function invocation ")); put_invocation (&s, func_name, args, arg_cnt); @@ -1132,12 +1179,12 @@ no_match (const char *func_name, ds_put_char (&s, '.'); msg (SE, "%s", ds_cstr (&s)); - + ds_destroy (&s); } static union any_node * -parse_function (struct expression *e) +parse_function (struct lexer *lexer, struct expression *e) { int min_valid; const struct operation *f, *first, *last; @@ -1150,34 +1197,35 @@ parse_function (struct expression *e) union any_node *n; - ds_init_string (&func_name, &tokstr); - min_valid = extract_min_valid (ds_cstr (&tokstr)); - if (!lookup_function (ds_cstr (&tokstr), &first, &last)) + ds_init_string (&func_name, lex_tokstr (lexer)); + min_valid = extract_min_valid (ds_cstr (lex_tokstr (lexer))); + if (!lookup_function (ds_cstr (lex_tokstr (lexer)), &first, &last)) { - msg (SE, _("No function or vector named %s."), ds_cstr (&tokstr)); + msg (SE, _("No function or vector named %s."), ds_cstr (lex_tokstr (lexer))); ds_destroy (&func_name); return NULL; } - lex_get (); - if (!lex_force_match ('(')) + lex_get (lexer); + if (!lex_force_match (lexer, '(')) { ds_destroy (&func_name); - return NULL; + return NULL; } - + args = NULL; arg_cnt = arg_cap = 0; - if (token != ')') + if (lex_token (lexer) != ')') for (;;) { - if (token == T_ID && lex_look_ahead () == 'T') + if (lex_token (lexer) == T_ID + && toupper (lex_look_ahead (lexer)) == 'T') { - struct variable **vars; + const struct variable **vars; size_t var_cnt; size_t i; - if (!parse_variables (default_dict, &vars, &var_cnt, PV_SINGLE)) + if (!parse_variables_const (lexer, dataset_dict (e->ds), &vars, &var_cnt, PV_SINGLE)) goto fail; for (i = 0; i < var_cnt; i++) add_arg (&args, &arg_cnt, &arg_cap, @@ -1186,17 +1234,17 @@ parse_function (struct expression *e) } else { - union any_node *arg = parse_or (e); + union any_node *arg = parse_or (lexer, e); if (arg == NULL) goto fail; add_arg (&args, &arg_cnt, &arg_cap, arg); } - if (lex_match (')')) + if (lex_match (lexer, ')')) break; - else if (!lex_match (',')) + else if (!lex_match (lexer, ',')) { - lex_error (_("expecting `,' or `)' invoking %s function"), + lex_error (lexer, _("expecting `,' or `)' invoking %s function"), first->name); goto fail; } @@ -1205,7 +1253,7 @@ parse_function (struct expression *e) for (f = first; f < last; f++) if (match_function (args, arg_cnt, f)) break; - if (f >= last) + if (f >= last) { no_match (ds_cstr (&func_name), args, arg_cnt, first, last); goto fail; @@ -1215,37 +1263,34 @@ parse_function (struct expression *e) if (!validate_function_args (f, arg_cnt, min_valid)) goto fail; - if ((f->flags & OPF_EXTENSION) && get_syntax () == COMPATIBLE) + if ((f->flags & OPF_EXTENSION) && settings_get_syntax () == COMPATIBLE) msg (SW, _("%s is a PSPP extension."), f->prototype); - if (f->flags & OPF_UNIMPLEMENTED) + if (f->flags & OPF_UNIMPLEMENTED) { msg (SE, _("%s is not yet implemented."), f->prototype); goto fail; } - if ((f->flags & OPF_PERM_ONLY) && proc_in_temporary_transformations ()) + if ((f->flags & OPF_PERM_ONLY) && + proc_in_temporary_transformations (e->ds)) { msg (SE, _("%s may not appear after TEMPORARY."), f->prototype); goto fail; } - + n = expr_allocate_composite (e, f - operations, args, arg_cnt); - n->composite.min_valid = min_valid != -1 ? min_valid : f->array_min_elems; + n->composite.min_valid = min_valid != -1 ? min_valid : f->array_min_elems; - if (n->type == OP_LAG_Vn || n->type == OP_LAG_Vs) - { - if (n_lag < 1) - n_lag = 1; - } + if (n->type == OP_LAG_Vn || n->type == OP_LAG_Vs) + dataset_need_lag (e->ds, 1); else if (n->type == OP_LAG_Vnn || n->type == OP_LAG_Vsn) { int n_before; assert (n->composite.arg_cnt == 2); assert (n->composite.args[1]->type == OP_pos_int); n_before = n->composite.args[1]->integer.i; - if (n_lag < n_before) - n_lag = n_before; + dataset_need_lag (e->ds, n_before); } - + free (args); ds_destroy (&func_name); return n; @@ -1259,12 +1304,12 @@ fail: /* Utility functions. */ static struct expression * -expr_create (struct dictionary *dict) +expr_create (struct dataset *ds) { struct pool *pool = pool_create (); struct expression *e = pool_alloc (pool, sizeof *e); e->expr_pool = pool; - e->dict = dict; + e->ds = ds; e->eval_pool = pool_create_subpool (e->expr_pool); e->ops = NULL; e->op_types = NULL; @@ -1277,12 +1322,12 @@ expr_node_returns (const union any_node *n) { assert (n != NULL); assert (is_operation (n->type)); - if (is_atom (n->type)) + if (is_atom (n->type)) return n->type; else if (is_composite (n->type)) return operations[n->type].returns; else - abort (); + NOT_REACHED (); } static const char * @@ -1316,33 +1361,33 @@ expr_allocate_binary (struct expression *e, operation_type op, } static bool -is_valid_node (union any_node *n) +is_valid_node (union any_node *n) { - struct operation *op; + const struct operation *op; size_t i; - + assert (n != NULL); assert (is_operation (n->type)); op = &operations[n->type]; - + if (!is_atom (n->type)) { struct composite_node *c = &n->composite; - + assert (is_composite (n->type)); assert (c->arg_cnt >= op->arg_cnt); - for (i = 0; i < op->arg_cnt; i++) - assert (expr_node_returns (c->args[i]) == op->args[i]); - if (c->arg_cnt > op->arg_cnt && !is_operator (n->type)) + for (i = 0; i < op->arg_cnt; i++) + assert (is_compatible (op->args[i], expr_node_returns (c->args[i]))); + if (c->arg_cnt > op->arg_cnt && !is_operator (n->type)) { assert (op->flags & OPF_ARRAY_OPERAND); for (i = 0; i < c->arg_cnt; i++) - assert (operations[c->args[i]->type].returns - == op->args[op->arg_cnt - 1]); + assert (is_compatible (op->args[op->arg_cnt - 1], + expr_node_returns (c->args[i]))); } } - return true; + return true; } union any_node * @@ -1357,7 +1402,7 @@ expr_allocate_composite (struct expression *e, operation_type op, n->composite.arg_cnt = arg_cnt; n->composite.args = pool_alloc (e->expr_pool, sizeof *n->composite.args * arg_cnt); - for (i = 0; i < arg_cnt; i++) + for (i = 0; i < arg_cnt; i++) { if (args[i] == NULL) return NULL; @@ -1438,10 +1483,10 @@ expr_allocate_string (struct expression *e, struct substring s) } union any_node * -expr_allocate_variable (struct expression *e, struct variable *v) +expr_allocate_variable (struct expression *e, const struct variable *v) { union any_node *n = pool_alloc (e->expr_pool, sizeof n->variable); - n->type = v->type == NUMERIC ? OP_num_var : OP_str_var; + n->type = var_is_numeric (v) ? OP_num_var : OP_str_var; n->variable.v = v; return n; } @@ -1458,9 +1503,48 @@ expr_allocate_format (struct expression *e, const struct fmt_spec *format) /* Allocates a unary composite node that represents the value of variable V in expression E. */ static union any_node * -allocate_unary_variable (struct expression *e, struct variable *v) +allocate_unary_variable (struct expression *e, const struct variable *v) { assert (v != NULL); - return expr_allocate_unary (e, v->type == NUMERIC ? OP_NUM_VAR : OP_STR_VAR, + return expr_allocate_unary (e, var_is_numeric (v) ? OP_NUM_VAR : OP_STR_VAR, expr_allocate_variable (e, v)); } + +/* Export function details to other modules. */ + +/* Returns the operation structure for the function with the + given IDX. */ +const struct operation * +expr_get_function (size_t idx) +{ + assert (idx < OP_function_cnt); + return &operations[OP_function_first + idx]; +} + +/* Returns the number of expression functions. */ +size_t +expr_get_function_cnt (void) +{ + return OP_function_cnt; +} + +/* Returns the name of operation OP. */ +const char * +expr_operation_get_name (const struct operation *op) +{ + return op->name; +} + +/* Returns the human-readable prototype for operation OP. */ +const char * +expr_operation_get_prototype (const struct operation *op) +{ + return op->prototype; +} + +/* Returns the number of arguments for operation OP. */ +int +expr_operation_get_arg_cnt (const struct operation *op) +{ + return op->arg_cnt; +}