X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fexpressions%2Fevaluate.c;h=65404b43e4d4d6a725a57794811291881890d4c7;hb=774441e68b4d2e3a4b5c6975e9614dcd4369955e;hp=6e3315c385a40ad45206ef2d6f5bc2880b2b795b;hpb=43b1296aafe7582e7dbe6c2b6a8b478d7d9b0fcf;p=pspp
diff --git a/src/language/expressions/evaluate.c b/src/language/expressions/evaluate.c
index 6e3315c385..65404b43e4 100644
--- a/src/language/expressions/evaluate.c
+++ b/src/language/expressions/evaluate.c
@@ -1,5 +1,5 @@
/* PSPP - a program for statistical analysis.
- Copyright (C) 1997-9, 2000, 2006, 2007 Free Software Foundation, Inc.
+ Copyright (C) 1997-9, 2000, 2006, 2007, 2009, 2010 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -15,16 +15,18 @@
along with this program. If not, see . */
#include
-#include "private.h"
+#include "evaluate.h"
#include
-#include
#include
#include
-#include "helpers.h"
-#include "evaluate.h"
+#include
+#include
+#include
#include
+#include "xalloc.h"
+
static void
expr_evaluate (struct expression *e, const struct ccase *c, int case_idx,
void *result)
@@ -62,7 +64,7 @@ expr_evaluate (struct expression *e, const struct ccase *c, int case_idx,
break;
case OP_return_number:
- *(double *) result = finite (ns[-1]) ? ns[-1] : SYSMIS;
+ *(double *) result = isfinite (ns[-1]) ? ns[-1] : SYSMIS;
return;
case OP_return_string:
@@ -97,7 +99,7 @@ expr_evaluate_str (struct expression *e, const struct ccase *c, int case_idx,
assert ((dst == NULL) == (dst_size == 0));
expr_evaluate (e, c, case_idx, &s);
- buf_copy_rpad (dst, dst_size, s.string, s.length);
+ buf_copy_rpad (dst, dst_size, s.string, s.length, ' ');
}
#include
@@ -125,7 +127,7 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
dump_postfix = 1;
else if (lex_match (lexer, '('))
{
- char name[LONG_NAME_LEN + 1];
+ char name[VAR_NAME_LEN + 1];
struct variable *v;
size_t old_value_cnt;
int width;
@@ -139,15 +141,9 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
goto done;
if (lex_is_number (lexer))
- {
- width = 0;
- fprintf (stderr, "(%s = %.2f)", name, lex_tokval (lexer));
- }
- else if (lex_token (lexer) == T_STRING)
- {
- width = ds_length (lex_tokstr (lexer));
- fprintf (stderr, "(%s = \"%.2s\")", name, ds_cstr (lex_tokstr (lexer)));
- }
+ width = 0;
+ else if (lex_is_string (lexer))
+ width = ds_length (lex_tokstr (lexer));
else
{
lex_error (lexer, _("expecting number or string"));
@@ -156,7 +152,7 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
if ( ds == NULL )
{
- ds = create_dataset (NULL, NULL);
+ ds = create_dataset ();
d = dataset_dict (ds);
}
@@ -169,19 +165,12 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
}
if (c == NULL)
- {
- c = xmalloc (sizeof *c);
- case_create (c, dict_get_next_value_idx (d));
- }
+ c = case_create (dict_get_proto (d));
else
- case_resize (c, dict_get_next_value_idx (d));
+ c = case_unshare_and_resize (c, dict_get_proto (d));
- if (lex_is_number (lexer))
- case_data_rw (c, v)->f = lex_tokval (lexer);
- else
- memcpy (case_data_rw (c, v)->s, ds_data (lex_tokstr (lexer)),
- var_get_width (v));
- lex_get (lexer);
+ if (!parse_value (lexer, case_data_rw (c, v), var_get_width (v)))
+ NOT_REACHED ();
if (!lex_force_match (lexer, ')'))
goto done;
@@ -195,9 +184,6 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
goto done;
}
- if ( ds != NULL )
- fprintf(stderr, "; ");
- fprintf (stderr, "%s => ", lex_rest_of_line (lexer));
lex_get (lexer);
expr = expr_parse_any (lexer, ds, optimize);
@@ -205,7 +191,7 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
{
if (expr != NULL)
expr_free (expr);
- fprintf (stderr, "error\n");
+ printf ("error\n");
goto done;
}
@@ -218,16 +204,16 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
{
double d = expr_evaluate_num (expr, c, 0);
if (d == SYSMIS)
- fprintf (stderr, "sysmis\n");
+ printf ("sysmis\n");
else
- fprintf (stderr, "%.2f\n", d);
+ printf ("%.2f\n", d);
}
break;
case OP_boolean:
{
double b = expr_evaluate_num (expr, c, 0);
- fprintf (stderr, "%s\n",
+ printf ("%s\n",
b == SYSMIS ? "sysmis" : b == 0.0 ? "false" : "true");
}
break;
@@ -237,9 +223,9 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
struct substring s;
expr_evaluate (expr, c, 0, &s);
- fputc ('"', stderr);
- fwrite (s.string, s.length, 1, stderr);
- fputs ("\"\n", stderr);
+ putchar ('"');
+ fwrite (s.string, s.length, 1, stdout);
+ puts ("\"");
break;
}
@@ -254,11 +240,7 @@ cmd_debug_evaluate (struct lexer *lexer, struct dataset *dsother UNUSED)
if (ds)
destroy_dataset (ds);
- if (c != NULL)
- {
- case_destroy (c);
- free (c);
- }
+ case_unref (c);
return retval;
}
@@ -277,24 +259,24 @@ expr_debug_print_postfix (const struct expression *e)
{
case OP_operation:
if (op->operation == OP_return_number)
- fprintf (stderr, "return_number");
+ printf ("return_number");
else if (op->operation == OP_return_string)
- fprintf (stderr, "return_string");
+ printf ("return_string");
else if (is_function (op->operation))
- fprintf (stderr, "%s", operations[op->operation].prototype);
+ printf ("%s", operations[op->operation].prototype);
else if (is_composite (op->operation))
- fprintf (stderr, "%s", operations[op->operation].name);
+ printf ("%s", operations[op->operation].name);
else
- fprintf (stderr, "%s:", operations[op->operation].name);
+ printf ("%s:", operations[op->operation].name);
break;
case OP_number:
if (op->number != SYSMIS)
- fprintf (stderr, "n<%g>", op->number);
+ printf ("n<%g>", op->number);
else
- fprintf (stderr, "n");
+ printf ("n");
break;
case OP_string:
- fprintf (stderr, "s<%.*s>",
+ printf ("s<%.*s>",
(int) op->string.length,
op->string.string != NULL ? op->string.string : "");
break;
@@ -302,21 +284,21 @@ expr_debug_print_postfix (const struct expression *e)
{
char str[FMT_STRING_LEN_MAX + 1];
fmt_to_string (op->format, str);
- fprintf (stderr, "f<%s>", str);
+ printf ("f<%s>", str);
}
break;
case OP_variable:
- fprintf (stderr, "v<%s>", var_get_name (op->variable));
+ printf ("v<%s>", var_get_name (op->variable));
break;
case OP_vector:
- fprintf (stderr, "vec<%s>", vector_get_name (op->vector));
+ printf ("vec<%s>", vector_get_name (op->vector));
break;
case OP_integer:
- fprintf (stderr, "i<%d>", op->integer);
+ printf ("i<%d>", op->integer);
break;
default:
NOT_REACHED ();
}
}
- fprintf (stderr, "\n");
+ printf ("\n");
}