X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fdictionary%2Fvector.c;h=e7e70cecb28a288549b22fdbf9641b2b4b8cd009;hb=2f3bca35516d8f3b3df76b3152fd5c77ff1f09cf;hp=b0d696154b7f212a5c790a87efe7d69b1debd31a;hpb=fe8dc2171009e90d2335f159d05f7e6660e24780;p=pspp diff --git a/src/language/dictionary/vector.c b/src/language/dictionary/vector.c index b0d696154b..e7e70cecb2 100644 --- a/src/language/dictionary/vector.c +++ b/src/language/dictionary/vector.c @@ -1,5 +1,5 @@ /* PSPP - a program for statistical analysis. - Copyright (C) 1997-9, 2000, 2010, 2011 Free Software Foundation, Inc. + Copyright (C) 1997-9, 2000, 2010, 2011, 2012, 2016 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -27,6 +27,7 @@ #include "language/lexer/lexer.h" #include "language/lexer/variable-parser.h" #include "libpspp/assertion.h" +#include "libpspp/i18n.h" #include "libpspp/message.h" #include "libpspp/misc.h" #include "libpspp/pool.h" @@ -68,7 +69,7 @@ cmd_vector (struct lexer *lexer, struct dataset *ds) } for (i = 0; i < vector_cnt; i++) - if (!strcasecmp (vectors[i], lex_tokcstr (lexer))) + if (!utf8_strcasecmp (vectors[i], lex_tokcstr (lexer))) { msg (SE, _("Vector name %s is given twice."), lex_tokcstr (lexer)); @@ -123,20 +124,16 @@ cmd_vector (struct lexer *lexer, struct dataset *ds) { if (lex_is_integer (lexer) && var_cnt == 0) { + if (!lex_force_int_range (lexer, NULL, 1, INT_MAX)) + goto fail; var_cnt = lex_integer (lexer); lex_get (lexer); - if (var_cnt <= 0) - { - msg (SE, _("Vectors must have at least one element.")); - goto fail; - } } else if (lex_token (lexer) == T_ID && !seen_format) { seen_format = true; if (!parse_format_specifier (lexer, &format) - || !fmt_check_output (&format) - || !fmt_check_type_compat (&format, VAL_NUMERIC)) + || !fmt_check_output (&format)) goto fail; } else @@ -167,8 +164,8 @@ cmd_vector (struct lexer *lexer, struct dataset *ds) } if (dict_lookup_var (dict, name)) { - free (name); msg (SE, _("%s is an existing variable name."), name); + free (name); goto fail; } free (name); @@ -183,7 +180,8 @@ cmd_vector (struct lexer *lexer, struct dataset *ds) for (j = 0; j < var_cnt; j++) { char *name = xasprintf ("%s%d", vectors[i], j + 1); - vars[j] = dict_create_var_assert (dict, name, 0); + vars[j] = dict_create_var_assert (dict, name, + fmt_var_width (&format)); var_set_both_formats (vars[j], &format); free (name); }