X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fdata-io%2Fget-data.c;h=a0608f6dd3724ae172b6298b9cefda89f8316956;hb=cc0b5800fcdde6126c4fc65b656f39c1459bf17c;hp=13eebe6c3aaabe840a155c4e405fa797e99af295;hpb=0369a800f7007c89a7e12d190fdc81e4f80d4314;p=pspp diff --git a/src/language/data-io/get-data.c b/src/language/data-io/get-data.c index 13eebe6c3a..a0608f6dd3 100644 --- a/src/language/data-io/get-data.c +++ b/src/language/data-io/get-data.c @@ -46,21 +46,6 @@ #define _(msgid) gettext (msgid) #define N_(msgid) (msgid) - -#ifdef ODF_READ_SUPPORT -static const bool odf_read_support = true; -#else -static const bool odf_read_support = false; -struct spreadsheet *ods_probe (const char *filename, bool report_errors){} -#endif - -#ifdef GNM_READ_SUPPORT -static const bool gnm_read_support = true; -#else -static const bool gnm_read_support = false; -struct spreadsheet *gnumeric_probe (const char *filename, bool report_errors){} -#endif - static bool parse_spreadsheet (struct lexer *lexer, char **filename, struct spreadsheet_read_options *opts); @@ -74,7 +59,7 @@ cmd_get_data (struct lexer *lexer, struct dataset *ds) { char *tok = NULL; struct spreadsheet_read_options opts; - + opts.sheet_name = NULL; opts.sheet_index = -1; opts.cell_range = NULL; @@ -94,7 +79,7 @@ cmd_get_data (struct lexer *lexer, struct dataset *ds) if (s) tok = strdup (s); - + if (lex_match_id (lexer, "TXT")) { free (tok); @@ -105,7 +90,7 @@ cmd_get_data (struct lexer *lexer, struct dataset *ds) free (tok); return parse_get_psql (lexer, ds); } - else if (lex_match_id (lexer, "GNM") || + else if (lex_match_id (lexer, "GNM") || lex_match_id (lexer, "ODS")) { char *filename = NULL; @@ -113,14 +98,18 @@ cmd_get_data (struct lexer *lexer, struct dataset *ds) goto error; struct spreadsheet *spreadsheet = NULL; - if ( gnm_read_support && 0 == strncasecmp (tok, "GNM", 3)) + if ( 0 == strncasecmp (tok, "GNM", 3)) spreadsheet = gnumeric_probe (filename, true); - else if ( odf_read_support && 0 == strncasecmp (tok, "ODS", 3)) + else if ( 0 == strncasecmp (tok, "ODS", 3)) spreadsheet = ods_probe (filename, true); - free (filename); if (spreadsheet == NULL) - goto error; + { + msg (SE, _("error reading file `%s'"), filename); + free (filename); + goto error; + } + free (filename); struct casereader *reader = spreadsheet_make_reader (spreadsheet, &opts); if (reader) @@ -229,7 +218,7 @@ parse_get_psql (struct lexer *lexer, struct dataset *ds) } static bool -parse_spreadsheet (struct lexer *lexer, char **filename, +parse_spreadsheet (struct lexer *lexer, char **filename, struct spreadsheet_read_options *opts) { opts->sheet_index = 1; @@ -684,7 +673,7 @@ parse_get_txt (struct lexer *lexer, struct dataset *ds) if (reader == NULL) goto error; - data_parser_make_active_file (parser, ds, reader, dict); + data_parser_make_active_file (parser, ds, reader, dict, NULL, NULL); fh_unref (fh); free (encoding); return CMD_SUCCESS; @@ -699,7 +688,7 @@ parse_get_txt (struct lexer *lexer, struct dataset *ds) } -static void +static void destroy_spreadsheet_read_info (struct spreadsheet_read_options *opts) { free (opts->cell_range);