X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Flanguage%2Fdata-io%2Ffile-handle.q;h=7e7cdcdf9b839969b883aa43d5db54c2c20d5ffc;hb=9ade26c8349;hp=3e053ed57262eb5f6e94d404ed5686253e640a16;hpb=b40baf410822471fbdeeec553693619d60d7c7b6;p=pspp-builds.git
diff --git a/src/language/data-io/file-handle.q b/src/language/data-io/file-handle.q
index 3e053ed5..7e7cdcdf 100644
--- a/src/language/data-io/file-handle.q
+++ b/src/language/data-io/file-handle.q
@@ -1,5 +1,5 @@
/* PSPP - a program for statistical analysis.
- Copyright (C) 1997-9, 2000, 2006 Free Software Foundation, Inc.
+ Copyright (C) 1997-9, 2000, 2006, 2010, 2011 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@ -15,21 +15,22 @@
along with this program. If not, see . */
#include
+
#include
-#include
-#include
#include
#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include "xalloc.h"
+#include "data/file-name.h"
+#include "language/command.h"
+#include "language/data-io/file-handle.h"
+#include "language/lexer/lexer.h"
+#include "libpspp/assertion.h"
+#include "libpspp/message.h"
+#include "libpspp/str.h"
+#include "data/variable.h"
+#include "data/file-handle-def.h"
+
+#include "gl/xalloc.h"
#include "gettext.h"
#define _(msgid) gettext (msgid)
@@ -51,32 +52,34 @@
int
cmd_file_handle (struct lexer *lexer, struct dataset *ds)
{
- char handle_name[VAR_NAME_LEN + 1];
struct cmd_file_handle cmd;
struct file_handle *handle;
+ enum cmd_result result;
+ char *handle_name;
+ result = CMD_CASCADING_FAILURE;
if (!lex_force_id (lexer))
- return CMD_CASCADING_FAILURE;
- str_copy_trunc (handle_name, sizeof handle_name, lex_tokid (lexer));
+ goto exit;
+ handle_name = xstrdup (lex_tokcstr (lexer));
handle = fh_from_id (handle_name);
if (handle != NULL)
{
msg (SE, _("File handle %s is already defined. "
"Use CLOSE FILE HANDLE before redefining a file handle."),
handle_name);
- return CMD_CASCADING_FAILURE;
+ goto exit_free_handle_name;
}
lex_get (lexer);
- if (!lex_force_match (lexer, '/'))
- return CMD_CASCADING_FAILURE;
+ if (!lex_force_match (lexer, T_SLASH))
+ goto exit_free_handle_name;
if (!parse_file_handle (lexer, ds, &cmd, NULL))
- return CMD_CASCADING_FAILURE;
+ goto exit_free_handle_name;
if (lex_end_of_command (lexer) != CMD_SUCCESS)
- goto lossage;
+ goto exit_free_cmd;
if (cmd.mode != FH_SCRATCH)
{
@@ -85,7 +88,7 @@ cmd_file_handle (struct lexer *lexer, struct dataset *ds)
if (cmd.s_name == NULL)
{
lex_sbc_missing (lexer, "NAME");
- goto lossage;
+ goto exit_free_cmd;
}
switch (cmd.mode)
@@ -118,7 +121,7 @@ cmd_file_handle (struct lexer *lexer, struct dataset *ds)
else
{
msg (SE, _("RECFORM must be specified with MODE=360."));
- goto lossage;
+ goto exit_free_cmd;
}
break;
default:
@@ -129,7 +132,7 @@ cmd_file_handle (struct lexer *lexer, struct dataset *ds)
{
if (cmd.n_lrecl[0] == LONG_MIN)
msg (SE, _("The specified file mode requires LRECL. "
- "Assuming %d-character records."),
+ "Assuming %zu-character records."),
properties.record_width);
else if (cmd.n_lrecl[0] < 1 || cmd.n_lrecl[0] >= (1UL << 31))
msg (SE, _("Record length (%ld) must be between 1 and %lu bytes. "
@@ -144,12 +147,14 @@ cmd_file_handle (struct lexer *lexer, struct dataset *ds)
else
fh_create_scratch (handle_name);
- free_file_handle (&cmd);
- return CMD_SUCCESS;
+ result = CMD_SUCCESS;
- lossage:
+exit_free_cmd:
free_file_handle (&cmd);
- return CMD_CASCADING_FAILURE;
+exit_free_handle_name:
+ free (handle_name);
+exit:
+ return result;
}
int
@@ -159,7 +164,7 @@ cmd_close_file_handle (struct lexer *lexer, struct dataset *ds UNUSED)
if (!lex_force_id (lexer))
return CMD_CASCADING_FAILURE;
- handle = fh_from_id (lex_tokid (lexer));
+ handle = fh_from_id (lex_tokcstr (lexer));
if (handle == NULL)
return CMD_CASCADING_FAILURE;
@@ -200,7 +205,7 @@ fh_parse (struct lexer *lexer, enum fh_referent referent_mask)
handle = fh_inline_file ();
else
{
- if (lex_token (lexer) != T_ID && lex_token (lexer) != T_STRING)
+ if (lex_token (lexer) != T_ID && !lex_is_string (lexer))
{
lex_error (lexer, _("expecting a file name or handle name"));
return NULL;
@@ -208,14 +213,15 @@ fh_parse (struct lexer *lexer, enum fh_referent referent_mask)
handle = NULL;
if (lex_token (lexer) == T_ID)
- handle = fh_from_id (lex_tokid (lexer));
+ handle = fh_from_id (lex_tokcstr (lexer));
if (handle == NULL)
{
- if (lex_token (lexer) != T_ID || lex_tokid (lexer)[0] != '#' || settings_get_syntax () != ENHANCED)
- handle = fh_create_file (NULL, ds_cstr (lex_tokstr (lexer)),
+ if (lex_token (lexer) != T_ID || lex_tokcstr (lexer)[0] != '#'
+ || settings_get_syntax () != ENHANCED)
+ handle = fh_create_file (NULL, lex_tokcstr (lexer),
fh_default_properties ());
else
- handle = fh_create_scratch (lex_tokid (lexer));
+ handle = fh_create_scratch (lex_tokcstr (lexer));
}
lex_get (lexer);
}