X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=ovsdb%2Flog.c;h=ab4a150ca6beacd00297c54bf97e6d3f4c76817e;hb=71baec0655e41bb93f125d162bc62cc9da0be73b;hp=ccb844fdb54a3453f5035ed3bb9bceca1b0a5de3;hpb=ada496b5cc123fca2913be8b73097934f528cec8;p=openvswitch diff --git a/ovsdb/log.c b/ovsdb/log.c index ccb844fd..ab4a150c 100644 --- a/ovsdb/log.c +++ b/ovsdb/log.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2009, 2010 Nicira Networks +/* Copyright (c) 2009, 2010, 2011 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,6 +22,7 @@ #include #include #include +#include #include #include "json.h" @@ -32,16 +33,17 @@ #include "socket-util.h" #include "transaction.h" #include "util.h" - -#define THIS_MODULE VLM_ovsdb_log #include "vlog.h" +VLOG_DEFINE_THIS_MODULE(ovsdb_log); + enum ovsdb_log_mode { OVSDB_LOG_READ, OVSDB_LOG_WRITE }; struct ovsdb_log { + off_t prev_offset; off_t offset; char *name; struct lockfile *lockfile; @@ -120,6 +122,7 @@ ovsdb_log_open(const char *name, enum ovsdb_log_open_mode open_mode, file->name = xstrdup(name); file->lockfile = lockfile; file->stream = stream; + file->prev_offset = 0; file->offset = 0; file->read_error = NULL; file->write_error = NULL; @@ -283,9 +286,10 @@ ovsdb_log_read(struct ovsdb_log *file, struct json **jsonp) goto error; } + file->prev_offset = file->offset; file->offset = data_offset + data_length; *jsonp = json; - return 0; + return NULL; error: file->read_error = ovsdb_error_clone(error); @@ -293,6 +297,22 @@ error: return error; } +/* Causes the log record read by the previous call to ovsdb_log_read() to be + * effectively discarded. The next call to ovsdb_log_write() will overwrite + * that previously read record. + * + * Calling this function more than once has no additional effect. + * + * This function is useful when ovsdb_log_read() successfully reads a record + * but that record does not make sense at a higher level (e.g. it specifies an + * invalid transaction). */ +void +ovsdb_log_unread(struct ovsdb_log *file) +{ + assert(file->mode == OVSDB_LOG_READ); + file->offset = file->prev_offset; +} + struct ovsdb_error * ovsdb_log_write(struct ovsdb_log *file, struct json *json) { @@ -352,7 +372,7 @@ ovsdb_log_write(struct ovsdb_log *file, struct json *json) file->offset += strlen(header) + length; free(json_string); - return 0; + return NULL; error: file->write_error = ovsdb_error_clone(error); @@ -366,7 +386,7 @@ ovsdb_log_commit(struct ovsdb_log *file) if (fsync(fileno(file->stream))) { return ovsdb_io_error(errno, "%s: fsync failed", file->name); } - return 0; + return NULL; } /* Returns the current offset into the file backing 'log', in bytes. This