X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=ofproto%2Fconnmgr.c;h=38052ac5ee52ce13f60fc5ecaf5812e2476c2448;hb=e89993f33c2ccd0373a47941df82bdd797c525ea;hp=865fa29547f78ba10b8ec3cda042b93c48061c03;hpb=2bd5b8145b7cf1851d51e258ab614414f2496aae;p=openvswitch diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c index 865fa295..38052ac5 100644 --- a/ofproto/connmgr.c +++ b/ofproto/connmgr.c @@ -240,7 +240,10 @@ connmgr_run(struct connmgr *mgr, size_t i; if (handle_openflow && mgr->in_band) { - in_band_run(mgr->in_band); + if (!in_band_run(mgr->in_band)) { + in_band_destroy(mgr->in_band); + mgr->in_band = NULL; + } } LIST_FOR_EACH_SAFE (ofconn, next_ofconn, node, &mgr->all_conns) { @@ -604,13 +607,13 @@ update_in_band_remotes(struct connmgr *mgr) if (!mgr->in_band) { in_band_create(mgr->ofproto, mgr->local_port_name, &mgr->in_band); } - if (mgr->in_band) { - in_band_set_remotes(mgr->in_band, addrs, n_addrs); - } in_band_set_queue(mgr->in_band, mgr->in_band_queue); } else { - in_band_destroy(mgr->in_band); - mgr->in_band = NULL; + /* in_band_run() needs a chance to delete any existing in-band flows. + * We will destroy mgr->in_band after it's done with that. */ + } + if (mgr->in_band) { + in_band_set_remotes(mgr->in_band, addrs, n_addrs); } /* Clean up. */