X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=lib%2Fvconn-unix.c;h=f24c84640b2a0bfbabc99cf58accc3d415ded6a0;hb=3f355f47f8e7343e909ccfa854454d667baf3c38;hp=aec2e31d630cbb4b1e956cbd0059580a2eea1d4d;hpb=a14bc59fb8f27db193d74662dc9c5cb8237177ef;p=openvswitch diff --git a/lib/vconn-unix.c b/lib/vconn-unix.c index aec2e31d..f24c8464 100644 --- a/lib/vconn-unix.c +++ b/lib/vconn-unix.c @@ -47,20 +47,21 @@ static int unix_open(const char *name, char *suffix, struct vconn **vconnp) { const char *connect_path = suffix; - char bind_path[128]; + char *bind_path; int fd; - sprintf(bind_path, "/tmp/vconn-unix.%ld.%d", - (long int) getpid(), n_unix_sockets++); + bind_path = xasprintf("/tmp/vconn-unix.%ld.%d", + (long int) getpid(), n_unix_sockets++); fd = make_unix_socket(SOCK_STREAM, true, false, bind_path, connect_path); if (fd < 0) { VLOG_ERR("%s: connection to %s failed: %s", bind_path, connect_path, strerror(-fd)); + free(bind_path); return -fd; } return new_stream_vconn(name, fd, check_connection_completion(fd), - 0, true, vconnp); + bind_path, vconnp); } struct vconn_class unix_vconn_class = { @@ -81,7 +82,7 @@ static int punix_accept(int fd, const struct sockaddr *sa, size_t sa_len, static int punix_open(const char *name UNUSED, char *suffix, struct pvconn **pvconnp) { - int fd; + int fd, error; fd = make_unix_socket(SOCK_STREAM, true, true, suffix, NULL); if (fd < 0) { @@ -89,7 +90,21 @@ punix_open(const char *name UNUSED, char *suffix, struct pvconn **pvconnp) return errno; } - return new_pstream_pvconn("punix", fd, punix_accept, pvconnp); + error = set_nonblocking(fd); + if (error) { + close(fd); + return error; + } + + if (listen(fd, 10) < 0) { + error = errno; + VLOG_ERR("%s: listen: %s", name, strerror(error)); + close(fd); + return error; + } + + return new_pstream_pvconn("punix", fd, punix_accept, + xstrdup(suffix), pvconnp); } static int @@ -105,7 +120,7 @@ punix_accept(int fd, const struct sockaddr *sa, size_t sa_len, } else { strcpy(name, "unix"); } - return new_stream_vconn(name, fd, 0, 0, true, vconnp); + return new_stream_vconn(name, fd, 0, NULL, vconnp); } struct pvconn_class punix_pvconn_class = {