X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=lib%2Fnetdev.c;h=9fba077b6982c9f31e5db6cd1b5c54b1c61ed93f;hb=0ff2282245a87f253843bf357988d7230139888f;hp=995492927bf2fdc4bfd9c34e3957ac253953d9d3;hpb=7b6b0ef47e398a2fbda48fd385f9781b2df8bebb;p=openvswitch diff --git a/lib/netdev.c b/lib/netdev.c index 99549292..9fba077b 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -192,58 +192,39 @@ netdev_enumerate_types(struct sset *types) } } -void -update_device_args(struct netdev_dev *dev, const struct shash *args) -{ - smap_destroy(&dev->args); - smap_clone(&dev->args, args); -} - -/* Opens the network device named 'name' (e.g. "eth0") and returns zero if - * successful, otherwise a positive errno value. On success, sets '*netdevp' - * to the new network device, otherwise to null. +/* Opens the network device named 'name' (e.g. "eth0") of the specified 'type' + * (e.g. "system") and returns zero if successful, otherwise a positive errno + * value. On success, sets '*netdevp' to the new network device, otherwise to + * null. * - * If this is the first time the device has been opened, then create is called - * before opening. The device is created using the given type and - * arguments. */ + * Some network devices may need to be configured (with netdev_set_config()) + * before they can be used. */ int -netdev_open(struct netdev_options *options, struct netdev **netdevp) +netdev_open(const char *name, const char *type, struct netdev **netdevp) { - struct shash empty_args = SHASH_INITIALIZER(&empty_args); struct netdev_dev *netdev_dev; int error; *netdevp = NULL; netdev_initialize(); - if (!options->args) { - options->args = &empty_args; - } - - netdev_dev = shash_find_data(&netdev_dev_shash, options->name); + netdev_dev = shash_find_data(&netdev_dev_shash, name); if (!netdev_dev) { const struct netdev_class *class; - class = netdev_lookup_provider(options->type); + class = netdev_lookup_provider(type); if (!class) { VLOG_WARN("could not create netdev %s of unknown type %s", - options->name, options->type); + name, type); return EAFNOSUPPORT; } - error = class->create(class, options->name, options->args, - &netdev_dev); + error = class->create(class, name, &netdev_dev); if (error) { return error; } assert(netdev_dev->netdev_class == class); - } else if (!shash_is_empty(options->args) && - !netdev_dev_args_equal(netdev_dev, options->args)) { - - VLOG_WARN("%s: attempted to open already open netdev with " - "different arguments", options->name); - return EINVAL; } error = netdev_dev->netdev_class->open(netdev_dev, netdevp); @@ -259,52 +240,49 @@ netdev_open(struct netdev_options *options, struct netdev **netdevp) return error; } -int -netdev_open_default(const char *name, struct netdev **netdevp) -{ - struct netdev_options options; - - memset(&options, 0, sizeof options); - options.name = name; - - return netdev_open(&options, netdevp); -} - /* Reconfigures the device 'netdev' with 'args'. 'args' may be empty * or NULL if none are needed. */ int netdev_set_config(struct netdev *netdev, const struct shash *args) { - struct shash empty_args = SHASH_INITIALIZER(&empty_args); struct netdev_dev *netdev_dev = netdev_get_dev(netdev); - if (!args) { - args = &empty_args; - } - if (netdev_dev->netdev_class->set_config) { - if (!netdev_dev_args_equal(netdev_dev, args)) { - update_device_args(netdev_dev, args); - return netdev_dev->netdev_class->set_config(netdev_dev, args); - } - } else if (!shash_is_empty(args)) { - VLOG_WARN("%s: arguments provided to device whose configuration " - "cannot be changed", netdev_get_name(netdev)); + struct shash no_args = SHASH_INITIALIZER(&no_args); + return netdev_dev->netdev_class->set_config(netdev_dev, + args ? args : &no_args); + } else if (args && !shash_is_empty(args)) { + VLOG_WARN("%s: arguments provided to device that is not configurable", + netdev_get_name(netdev)); } return 0; } -/* Returns the current configuration for 'netdev'. This is either the - * configuration passed to netdev_open() or netdev_set_config(), or it is a - * configuration retrieved from the device itself if no configuration was - * passed to those functions. +/* Returns the current configuration for 'netdev' in 'args'. The caller must + * have already initialized 'args' with shash_init(). Returns 0 on success, in + * which case 'args' will be filled with 'netdev''s configuration. On failure + * returns a positive errno value, in which case 'args' will be empty. * - * 'netdev' retains ownership of the returned configuration. */ -const struct shash * -netdev_get_config(const struct netdev *netdev) + * The caller owns 'args' and its contents and must eventually free them with + * shash_destroy_free_data(). */ +int +netdev_get_config(const struct netdev *netdev, struct shash *args) { - return &netdev_get_dev(netdev)->args; + struct netdev_dev *netdev_dev = netdev_get_dev(netdev); + int error; + + shash_clear_free_data(args); + if (netdev_dev->netdev_class->get_config) { + error = netdev_dev->netdev_class->get_config(netdev_dev, args); + if (error) { + shash_clear_free_data(args); + } + } else { + error = 0; + } + + return error; } /* Closes and destroys 'netdev'. */ @@ -333,7 +311,7 @@ netdev_exists(const char *name) struct netdev *netdev; int error; - error = netdev_open_default(name, &netdev); + error = netdev_open(name, "system", &netdev); if (!error) { netdev_close(netdev); return true; @@ -532,19 +510,36 @@ netdev_get_name(const struct netdev *netdev) * (and received) packets, in bytes, not including the hardware header; thus, * this is typically 1500 bytes for Ethernet devices. * - * If successful, returns 0 and stores the MTU size in '*mtup'. Stores INT_MAX - * in '*mtup' if 'netdev' does not have an MTU (as e.g. some tunnels do not).On - * failure, returns a positive errno value and stores ETH_PAYLOAD_MAX (1500) in - * '*mtup'. */ + * If successful, returns 0 and stores the MTU size in '*mtup'. Returns + * EOPNOTSUPP if 'netdev' does not have an MTU (as e.g. some tunnels do not). + * On other failure, returns a positive errno value. */ int netdev_get_mtu(const struct netdev *netdev, int *mtup) { int error = netdev_get_dev(netdev)->netdev_class->get_mtu(netdev, mtup); - if (error) { + if (error && error != EOPNOTSUPP) { + VLOG_WARN_RL(&rl, "failed to retrieve MTU for network device %s: %s", + netdev_get_name(netdev), strerror(error)); + } + return error; +} + +/* Sets the MTU of 'netdev'. The MTU is the maximum size of transmitted + * (and received) packets, in bytes. + * + * If successful, returns 0. Returns EOPNOTSUPP if 'netdev' does not have an + * MTU (as e.g. some tunnels do not). On other failure, returns a positive + * errno value. */ +int +netdev_set_mtu(const struct netdev *netdev, int mtu) +{ + int error = netdev_get_dev(netdev)->netdev_class->set_mtu(netdev, mtu); + + if (error && error != EOPNOTSUPP) { VLOG_WARN_RL(&rl, "failed to retrieve MTU for network device %s: %s", netdev_get_name(netdev), strerror(error)); - *mtup = ETH_PAYLOAD_MAX; } + return error; } @@ -662,7 +657,7 @@ netdev_set_advertisements(struct netdev *netdev, uint32_t advertise) * * - EOPNOTSUPP: No IPv4 network stack attached to 'netdev'. * - * 'address' or 'netmask' or both may be null, in which case the address or + * 'address' or 'netmask' or both may be null, in which case the address or * netmask is not reported. */ int netdev_get_in4(const struct netdev *netdev, @@ -1277,7 +1272,7 @@ netdev_find_dev_by_in4(const struct in_addr *in4) SSET_FOR_EACH (name, &dev_list) { struct in_addr dev_in4; - if (!netdev_open_default(name, &netdev) + if (!netdev_open(name, "system", &netdev) && !netdev_get_in4(netdev, &dev_in4, NULL) && dev_in4.s_addr == in4->s_addr) { goto exit; @@ -1295,17 +1290,11 @@ exit: * 'netdev_class'. This function is ordinarily called from a netdev provider's * 'create' function. * - * 'args' should be the arguments that were passed to the netdev provider's - * 'create'. If an empty set of arguments was passed, and 'name' is the name - * of a network device that existed before the 'create' call, then 'args' may - * instead be the configuration for that existing device. - * * This function adds 'netdev_dev' to a netdev-owned shash, so it is * very important that 'netdev_dev' only be freed after calling * the refcount drops to zero. */ void netdev_dev_init(struct netdev_dev *netdev_dev, const char *name, - const struct shash *args, const struct netdev_class *netdev_class) { assert(!shash_find(&netdev_dev_shash, name)); @@ -1314,7 +1303,6 @@ netdev_dev_init(struct netdev_dev *netdev_dev, const char *name, netdev_dev->netdev_class = netdev_class; netdev_dev->name = xstrdup(name); netdev_dev->node = shash_add(&netdev_dev_shash, name, netdev_dev); - smap_clone(&netdev_dev->args, args); } /* Undoes the results of initialization. @@ -1332,7 +1320,6 @@ netdev_dev_uninit(struct netdev_dev *netdev_dev, bool destroy) assert(!netdev_dev->ref_cnt); shash_delete(&netdev_dev_shash, netdev_dev->node); - smap_destroy(&netdev_dev->args); if (destroy) { netdev_dev->netdev_class->destroy(netdev_dev); @@ -1392,19 +1379,6 @@ netdev_dev_get_devices(const struct netdev_class *netdev_class, } } -/* Returns true if 'args' is equivalent to the "args" field in - * 'netdev_dev', otherwise false. */ -bool -netdev_dev_args_equal(const struct netdev_dev *netdev_dev, - const struct shash *args) -{ - if (netdev_dev->netdev_class->config_equal) { - return netdev_dev->netdev_class->config_equal(netdev_dev, args); - } else { - return smap_equal(&netdev_dev->args, args); - } -} - /* Initializes 'netdev' as a instance of the netdev_dev. * * This function adds 'netdev' to a netdev-owned linked list, so it is very