X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=lib%2Fdpif-linux.c;h=635fe94111df4c97ba473746024743b7c37faad9;hb=8497dd41214ddaac26928f2efa90becd1b336a52;hp=b7c9e3e6c14848e22b1d1995931bd91bf9ee09bd;hpb=54825e09b3aaf4b9513af7d02011306e01b0768c;p=openvswitch diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index b7c9e3e6..635fe941 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@ -23,11 +23,14 @@ #include #include #include +#include #include +#include #include #include #include #include +#include #include #include "dpif-provider.h" @@ -38,9 +41,9 @@ #include "shash.h" #include "svec.h" #include "util.h" - #include "vlog.h" -#define THIS_MODULE VLM_dpif_linux + +VLOG_DEFINE_THIS_MODULE(dpif_linux) /* Datapath interface for the openvswitch Linux kernel module. */ struct dpif_linux { @@ -335,8 +338,7 @@ dpif_linux_port_poll(const struct dpif *dpif_, char **devnamep) return ENOBUFS; } else if (!shash_is_empty(&dpif->changed_ports)) { struct shash_node *node = shash_first(&dpif->changed_ports); - *devnamep = xstrdup(node->name); - shash_delete(&dpif->changed_ports, node); + *devnamep = shash_steal(&dpif->changed_ports, node); return 0; } else { return EAGAIN; @@ -455,6 +457,18 @@ dpif_linux_set_sflow_probability(struct dpif *dpif_, uint32_t probability) return do_ioctl(dpif_, ODP_SET_SFLOW_PROBABILITY, &probability); } +static int +dpif_linux_queue_to_priority(const struct dpif *dpif OVS_UNUSED, + uint32_t queue_id, uint32_t *priority) +{ + if (queue_id < 0xf000) { + *priority = TC_H_MAKE(1 << 16, queue_id + 1); + return 0; + } else { + return EINVAL; + } +} + static int dpif_linux_recv(struct dpif *dpif_, struct ofpbuf **bufp) { @@ -463,8 +477,7 @@ dpif_linux_recv(struct dpif *dpif_, struct ofpbuf **bufp) int retval; int error; - buf = ofpbuf_new(65536 + DPIF_RECV_MSG_PADDING); - ofpbuf_reserve(buf, DPIF_RECV_MSG_PADDING); + buf = ofpbuf_new_with_headroom(65536, DPIF_RECV_MSG_PADDING); retval = read(dpif->fd, ofpbuf_tail(buf), ofpbuf_tailroom(buf)); if (retval < 0) { error = errno; @@ -537,6 +550,7 @@ const struct dpif_class dpif_linux_class = { dpif_linux_recv_set_mask, dpif_linux_get_sflow_probability, dpif_linux_set_sflow_probability, + dpif_linux_queue_to_priority, dpif_linux_recv, dpif_linux_recv_wait, }; @@ -716,11 +730,7 @@ get_major(const char *target) return major; } } else { - static bool warned; - if (!warned) { - VLOG_WARN("%s:%d: syntax error", fn, ln); - } - warned = true; + VLOG_WARN_ONCE("%s:%d: syntax error", fn, ln); } }