X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=lib%2Fcoverage.c;h=cdc796ec3e661b63a69519a1cd89437c8f21b4e5;hb=30746a1b6a9758a58d6f9a7a85830512aa0e114f;hp=6f805e9eacd44b2c9be0fe825708d5629e55bcc7;hpb=67ca9e6d90808f22332cf475ad01e01bf5d46c4f;p=openvswitch

diff --git a/lib/coverage.c b/lib/coverage.c
index 6f805e9e..cdc796ec 100644
--- a/lib/coverage.c
+++ b/lib/coverage.c
@@ -122,7 +122,10 @@ coverage_log_counter(enum vlog_level level, const struct coverage_counter *c)
 }
 
 /* Logs the coverage counters at the given vlog 'level'.  If
- * 'suppress_dups' is true, then duplicate events are not displayed. */
+ * 'suppress_dups' is true, then duplicate events are not displayed. 
+ * Care should be taken in the value used for 'level'.  Depending on the
+ * configuration, syslog can write changes synchronously, which can
+ * cause the coverage messages to take several seconds to write. */
 void
 coverage_log(enum vlog_level level, bool suppress_dups)
 {
@@ -134,8 +137,8 @@ coverage_log(enum vlog_level level, bool suppress_dups)
         return;
     }
 
+    hash = coverage_hash();
     if (suppress_dups) {
-        hash = coverage_hash();
         if (coverage_hit(hash)) {
             VLOG(level, "Skipping details of duplicate event coverage for "
                  "hash=%08"PRIx32" in epoch %u", hash, epoch);