X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=grading%2Fvm%2Freview.txt;h=a75934570a82ea26adf8e666270e21832ae3e8eb;hb=654121cfc127bc8e1e9aa8859c2d68f0dc4330cb;hp=82a30f07fbf5976d8ffea114995af6ed03c2ce0b;hpb=6a312cdd960c64a305d19ee7182f4f73698460d3;p=pintos-anon diff --git a/grading/vm/review.txt b/grading/vm/review.txt index 82a30f0..a759345 100644 --- a/grading/vm/review.txt +++ b/grading/vm/review.txt @@ -9,14 +9,13 @@ TESTCASES [[/10]] DESIGN [[/40]] -------------- -DESIGNDOC (per problem): +DESIGNDOC: -10 Doesn't discuss page table design -10 Doesn't discuss swap design -5 Doesn't discuss page replacement algorithm -5 Doesn't explain how memory mapping works Overall: - -3 Holds a global lock while accessing the disk -1 Gratuitous use of malloc() (e.g. for allocating a list or a lock) -1 Inappropriate use of ASSERT (e.g. to verify that malloc() succeeded)