X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=grading%2Fthreads%2Freview.txt;h=08585b56f60ccd268bec98b1088b90cf81c0d723;hb=60340711d147c11cd2c70c0d50b6509f498ae1fc;hp=3c01e7ae6efe27b6d8afcbaf5e34dd561d6b52ba;hpb=164d9b3983f7247c2f63313ed6521b5c1940bac1;p=pintos-anon

diff --git a/grading/threads/review.txt b/grading/threads/review.txt
index 3c01e7a..08585b5 100644
--- a/grading/threads/review.txt
+++ b/grading/threads/review.txt
@@ -1,8 +1,19 @@
-DESIGN [[/40]
--------------
+TESTCASES [[/10]]
+-----------------
+  -2 Problem 1-1: no test cases/no test output/no description in TESTCASES
+  -1 Problem 1-1: not enough testing/inconclusive test output
+  -2 Problem 1-2: no test cases/no test output/no description in TESTCASES
+  -1 Problem 1-2: not enough testing/inconclusive test output
+  -2 Problem 1-3: no test cases/no test output/no description in TESTCASES
+  -1 Problem 1-3: not enough testing/inconclusive test output
+  -2 Problem 1-4: no test cases/no test output/no description in TESTCASES
+  -1 Problem 1-4: not enough testing/inconclusive test output
+
+
+DESIGN [[/40]]
+--------------
 
  -20 Missing or far too brief DESIGNDOC
-  -2 Troublesome or unexplained dependencies
   -2 Changing interfaces, each (max -6)
 
 DESIGNDOC (per problem):
@@ -10,15 +21,18 @@ DESIGNDOC (per problem):
   -2 Major details missing
   -5 Totally missing
 
+Overall:
+  -1 Gratuitous use of malloc() (e.g. for allocating a list or a lock)
+  -1 Inappropriate use of ASSERT (e.g. to verify that malloc() succeeded)
+
 Problem 1-1: Alarm Clock
   -1 Uses lock/interrupt disabling without justifying
-  -1 Uses a lock inside of CallBack
+  -1 Uses a lock within interrupt handler
   -3 Busy waiting
   -2 Wakes up too often, e.g. by using semaphores with negative values
   -1 Traverses entire list of sleeping threads every tick
-  -1 Put threads to sleep directly
-  -1 Doesn't protect data structure in CallBack
-  -1 Doesn't protect data structure in WaitUntil
+  -1 Doesn't protect data structure in timer_interrupt
+  -1 Doesn't protect data structure in timer_sleep
   -3 Bad design
 
 Problem 1-2: Join
@@ -26,15 +40,15 @@ Problem 1-2: Join
   -3 A static list of all parent-child pairs is extremely wasteful
   -3 Obviously wasteful with memory (not deleting threads)
   -2 Finished parent deletes children which may still be running
-  -1 Enable/disable interrupts or put thread to sleep directly
-  -2 Joinable child lets its Thread object be deleted before parent dies
+  -1 Enable/disable interrupts
+  -2 Joinable child lets its struct thread be deleted before parent dies
   -1 Race condition between join and thread exit
 
 Problem 1-3: Priority Scheduler
   -3 Doesn't use sorted queue scheduler, and don't justify why they didn't
-  -1 Semaphores don't wake highest-priority thread first
-  -1 Condition variables don't wake highest-priority thread first
+  -2 sema_up() doesn't pick highest-priority waiting thread
   -1 Should use sorted queue in semaphores, unless explained in DESIGNDOC
+  -1 cond_signal() doesn't pick highest-priority waiting thread
   -1 Should use sorted queue in conditions, unless explained in DESIGNDOC
   -2 Yield should pick the highest-priority thread (including current)
   -3 Bad design
@@ -45,21 +59,9 @@ Problem 1-4: Advanced Scheduler
   -5 Bad design
 
 
-TESTCASES [[/10]
-----------------
-  -2 Problem 1-1: no test cases/no test output/no description in TESTCASES
-  -1 Problem 1-1: not enough testing/inconclusive test output
-  -2 Problem 1-2: no test cases/no test output/no description in TESTCASES
-  -1 Problem 1-2: not enough testing/inconclusive test output
-  -2 Problem 1-3: no test cases/no test output/no description in TESTCASES
-  -1 Problem 1-3: not enough testing/inconclusive test output
-  -2 Problem 1-4: no test cases/no test output/no description in TESTCASES
-  -1 Problem 1-4: not enough testing/inconclusive test output
-
-
 STYLE [[/10]]
 -------------
-Insert any comments here
+  -1 No attempt to conform to existing coding style
 
 
 COMMENTS