X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=grading%2Ffilesys%2Frun-tests;h=1b768abf84beb073ab3d15a5e4c1bf9fb7f1a0ad;hb=3cebac2006571a93ea0cbf992faa5eec3454d570;hp=143ab4a0de904664a237e28d556a1abdf3b35e88;hpb=fbea5921d53e698fee2014995cdb13ddb67a982f;p=pintos-anon

diff --git a/grading/filesys/run-tests b/grading/filesys/run-tests
index 143ab4a..1b768ab 100755
--- a/grading/filesys/run-tests
+++ b/grading/filesys/run-tests
@@ -40,12 +40,12 @@ extract_sources ();
 exit if $action eq 'extract';
 
 build (); 
-exit if $action eq 'build';
+exit success () if $action eq 'build';
 
 run_and_grade_tests (); 
 write_grades (); 
 write_details ();
-exit if $action eq 'test';
+exit success () if $action eq 'test';
 
 assemble_final_grade ();
 exit if $action eq 'assemble';
@@ -64,13 +64,12 @@ sub run_test {
 	     DIE => "failed to create swap disk");
 
     # Format disk, install test.
-    my ($pintos_base_cmd) =
-	"pintos "
-	. "--os-disk=pintos/src/$hw/build/os.dsk "
-	. "--fs-disk=output/$test/fs.dsk "
-	. "--swap-disk=output/$test/swap.dsk "
-	. "-v";
-    $result = run_pintos ("$pintos_base_cmd put -f $GRADES_DIR/$test $test",
+    my (@base_opts) = ("--os-disk=pintos/src/$hw/build/os.dsk",
+		       "--fs-disk=output/$test/fs.dsk",
+		       "--swap-disk=output/$test/swap.dsk",
+		       "-v");
+    $result = run_pintos ([@base_opts,
+			   "put", "-f", "$GRADES_DIR/$test", $test],
 			  LOG => "$test/put", TIMEOUT => 60);
     return $result if $result ne 'ok';
 
@@ -79,13 +78,13 @@ sub run_test {
     push (@extra_files, "child-syn-wrt") if $test eq 'syn-write';
     push (@extra_files, "child-syn-rw") if $test eq 'syn-rw';
     for my $fn (@extra_files) {
-	$result = run_pintos ("$pintos_base_cmd put $GRADES_DIR/$fn $fn",
+	$result = run_pintos ([@base_opts, "put", "$GRADES_DIR/$fn", $fn],
 			      LOG => "$test/put-$fn", TIMEOUT => 60);
 	return "Error running `put $fn': $result" if $result ne 'ok';
     }
     
     # Run.
-    return run_pintos ("$pintos_base_cmd run -q -ex \"$test\"",
+    return run_pintos ([@base_opts, "run", "-q", "-ex", $test],
 		       LOG => "$test/run", TIMEOUT => 120);
 }