X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=extras%2Fezio%2Fovs-switchui.c;h=864e34c1e744895a1ade9030d2253bc45ddeed09;hb=91f227cad7cd6a1a36c8cac75e56d1308821fe34;hp=e25d4e1af4585ac5bc05d066260f5a68a1d1591a;hpb=8cd4882fd5c3080816a070ad582ef06842f7c482;p=openvswitch diff --git a/extras/ezio/ovs-switchui.c b/extras/ezio/ovs-switchui.c index e25d4e1a..864e34c1 100644 --- a/extras/ezio/ovs-switchui.c +++ b/extras/ezio/ovs-switchui.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2008, 2009 Nicira Networks, Inc. +/* Copyright (c) 2008, 2009, 2010 Nicira Networks, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -165,7 +165,7 @@ main(int argc, char *argv[]) daemonize(); initialize_terminal(); - fatal_signal_add_hook(restore_terminal, NULL, true); + fatal_signal_add_hook(restore_terminal, NULL, NULL, true); msg = NULL; countdown = 0; @@ -549,7 +549,7 @@ show_dpid_ip(struct rconn *rconn, const struct dict *dict) const char *is_connected, *local_ip; dict_lookup(dict, "local.is-connected", &is_connected); - dict_lookup(dict, "in-band.local-ip", &local_ip); + dict_lookup(dict, "remote.local-ip", &local_ip); if (!is_connected && !local_ip) { /* If we're not connected to the datapath and don't have a local IP, * then we won't have anything useful to show anyhow. */ @@ -1209,7 +1209,7 @@ show_data_rates(struct rconn *rconn, const struct dict *dict) static bool inited = false; dict_lookup(dict, "local.is-connected", &is_connected); - dict_lookup(dict, "in-band.local-ip", &local_ip); + dict_lookup(dict, "remote.local-ip", &local_ip); if (!is_connected && !local_ip) { /* If we're not connected to the datapath and don't have a local IP, * then we won't have anything useful to show anyhow. */ @@ -1247,7 +1247,7 @@ allocate_message(struct message **msgp) { if (!*msgp) { /* Allocate and initialize message. */ - *msgp = xcalloc(1, sizeof **msgp); + *msgp = xzalloc(sizeof **msgp); (*msgp)->index = n_messages; /* Add to list of messages. */ @@ -1486,7 +1486,7 @@ static int menu_show(const struct menu *, int start, bool select); static void cmd_shell(const struct dict *); static void cmd_show_version(const struct dict *); static void cmd_configure(const struct dict *); -static void cmd_setup_pki(const struct dict *); +static void cmd_set_up_pki(const struct dict *); static void cmd_browse_status(const struct dict *); static void cmd_show_motto(const struct dict *); @@ -1542,7 +1542,7 @@ menu(const struct dict *dict) menu_add_item(&menu, "Exit"); menu_add_item(&menu, "Show Version")->f = cmd_show_version; menu_add_item(&menu, "Configure")->f = cmd_configure; - menu_add_item(&menu, "Setup PKI")->f = cmd_setup_pki; + menu_add_item(&menu, "Set up PKI")->f = cmd_set_up_pki; if (debug_mode) { menu_add_item(&menu, "Browse Status")->f = cmd_browse_status; menu_add_item(&menu, "Shell")->f = cmd_shell; @@ -2079,7 +2079,7 @@ save_config(const struct svec *settings) } svec_init(&argv); - svec_add(&argv, "/usr/share/openvswitch/commands/reconfigure"); + svec_add(&argv, "/usr/share/openvswitch-switchui/reconfigure"); svec_append(&argv, settings); svec_terminate(&argv); ok = run_and_report_failure(argv.names, "Save failed"); @@ -2478,9 +2478,9 @@ choose_netdevs(struct svec *choices) continue; } - retval = netdev_open(name, NETDEV_ETH_TYPE_NONE, &netdev); + retval = netdev_open_default(name, &netdev); if (!retval) { - bool exclude = netdev_get_in4(netdev, NULL); + bool exclude = netdev_get_in4(netdev, NULL, NULL) == 0; netdev_close(netdev); if (exclude) { continue; @@ -2801,7 +2801,8 @@ cmd_configure(const struct dict *dict UNUSED) out = prompt("Ctlr rate limit:", in, "^(Disabled|("NUM100_TO_99999_RE")/s)$"); free(in); - config.rate_limit = isdigit(out[0]) ? atoi(out) : -1; + config.rate_limit + = isdigit((unsigned char)out[0]) ? atoi(out) : -1; free(out); break; @@ -2812,7 +2813,8 @@ cmd_configure(const struct dict *dict UNUSED) out = prompt("Activity probe:", in, "^(Default|("NUM5_TO_99999_RE") s)$"); free(in); - config.inactivity_probe = isdigit(out[0]) ? atoi(out) : -1; + config.inactivity_probe + = isdigit((unsigned char)out[0]) ? atoi(out) : -1; free(out); break; @@ -2823,7 +2825,8 @@ cmd_configure(const struct dict *dict UNUSED) out = prompt("Max backoff:", in, "^(Default|("NUM1_TO_99999_RE") s)$"); free(in); - config.max_backoff = isdigit(out[0]) ? atoi(out) : -1; + config.max_backoff + = isdigit((unsigned char)out[0]) ? atoi(out) : -1; free(out); break; } @@ -2886,7 +2889,7 @@ cmd_configure(const struct dict *dict UNUSED) } static void -cmd_setup_pki(const struct dict *dict UNUSED) +cmd_set_up_pki(const struct dict *dict UNUSED) { static const char def_privkey_file[] = "/etc/openflow-switch/of0-privkey.pem";