X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=dump.c;h=57bc9b4489e186abc35175038c40d53ed6031cc1;hb=35d486d1a1ca5dd788b188355fd5e090bed785b3;hp=2ba9827ba53f16a7cd7cb1740d1ffef1b5b6f24c;hpb=06916912cd666cbbe0921609acfab653aaa1f809;p=pspp

diff --git a/dump.c b/dump.c
index 2ba9827ba5..57bc9b4489 100644
--- a/dump.c
+++ b/dump.c
@@ -104,7 +104,7 @@ match_u32_assert(uint32_t x, const char *where)
 static bool
 match_byte(uint8_t b)
 {
-  if (data[pos] == b)
+  if (pos < n && data[pos] == b)
     {
       pos++;
       return true;
@@ -147,6 +147,63 @@ get_string(const char *where)
 }
 #define get_string() get_string(WHERE)
 
+static void
+dump_value_31(void)
+{
+  if (match_byte (0x31))
+    {
+      if (match_u32 (0))
+        {
+          if (match_u32 (1))
+            get_string();
+          else
+            match_u32_assert (0);
+          int subn = get_u32 ();
+          printf ("nested %d bytes", subn);
+          pos += subn;
+        }
+      else if (match_u32 (1))
+        {
+          printf("(footnote %d) ", get_u32());
+          match_byte_assert (0);
+          match_byte_assert (0);
+          int subn = get_u32 ();
+          printf ("nested %d bytes", subn);
+          pos += subn;
+        }
+      else if (match_u32 (2))
+        {
+          printf("(special 2)");
+          match_byte_assert(0);
+          match_byte_assert(0);
+          if (!match_u32 (2))
+            match_u32_assert(1);
+          match_byte_assert(0);
+          match_byte_assert(0);
+          int subn = get_u32 ();
+          printf ("nested %d bytes", subn);
+          pos += subn;
+        }
+      else
+        {
+          match_u32_assert(3);
+          printf("(special 3)");
+          match_byte_assert(0);
+          match_byte_assert(0);
+          match_byte_assert(1);
+          match_byte_assert(0);
+          int subn = get_u32 ();
+          printf ("nested %d bytes, ", subn);
+          pos += subn;
+          subn = get_u32 ();
+          printf ("nested %d bytes, ", subn);
+          pos += subn;
+        }
+    }
+  else
+    match_byte_assert (0x58);
+}
+
 static void
 dump_value(int level)
 {
@@ -159,63 +216,24 @@ dump_value(int level)
   match_byte (0);
   if (match_byte (3))
     {
-      get_string();
-      if (match_byte (0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          else if (match_u32 (2))
-            {
-              printf("(special 2)");
-              match_byte_assert(0);
-              match_byte_assert(0);
-              match_u32_assert(1);
-              match_byte_assert(0);
-              match_byte_assert(0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          else
-            {
-              match_u32_assert(3);
-              printf("(special 3)");
-              match_byte_assert(0);
-              match_byte_assert(0);
-              match_byte_assert(1);
-              match_byte_assert(0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes, ", subn);
-              pos += subn;
-              subn = get_u32 ();
-              printf ("nested %d bytes, ", subn);
-              pos += subn;
-            }
-        }
+      char *s1 = get_string();
+      dump_value_31();
+      char *s2 = get_string();
+      char *s3 = get_string();
+      if (strcmp(s1, s3))
+        printf("strings \"%s\", \"%s\" and \"%s\"", s1, s2, s3);
       else
-        match_byte_assert (0x58);
-      get_string();
-      printf("string \"%s\"", get_string());
-      match_byte (0);
-      match_byte (0);
+        printf("string \"%s\" and \"%s\"", s1, s2);
       match_byte (0);
       match_byte (1);
       match_byte (1);
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (1);
     }
   else if (match_byte (5))
     {
-      match_byte_assert (0x58);
+      dump_value_31();
       printf ("variable \"%s\"", get_string());
       get_string();
       if (!match_byte(1) && !match_byte(2))
@@ -223,7 +241,6 @@ dump_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (0);
     }
   else if (match_byte (2))
     {
@@ -243,10 +260,6 @@ dump_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (0);
-      match_byte (0);
-      match_byte (0);
-      match_byte (0);
     }
   else if (match_byte (4))
     {
@@ -265,27 +278,13 @@ dump_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (0);
     }
   else if (match_byte (1))
     {
       unsigned int format;
       double value;
 
-      if (match_byte (0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-        }
-      else
-        match_byte_assert (0x58);
+      dump_value_31();
       format = get_u32 ();
       value = get_double ();
       printf ("value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
@@ -293,76 +292,12 @@ dump_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (1);
-    }
-  else if (match_byte (0x31))
-    {
-      if (match_u32 (1))
-        {
-          printf("(footnote %d) ", get_u32());
-          match_byte_assert (0);
-          match_byte_assert (0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes", subn);
-          pos += subn;
-        }
-      else
-        {
-          match_u32_assert (0);
-          match_u32_assert (0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes", subn);
-          pos += subn;
-        }
-      char *base = get_string();
-      int x = get_u32();
-      printf ("\"%s\"; %d variables:\n", base, x);
-      if (match_u32(0))
-        {
-          for (int i = 0; i < x; i++)
-            {
-              dump_value (level+1);
-              putchar('\n');
-            }
-        }
-      else
-        {
-          for (int i = 0; i < x; i++)
-            {
-              int y = get_u32();
-              match_u32_assert(0);
-              for (int j = 0; j <= level; j++)
-                printf ("    ");
-              printf("variable %d has %d values:\n", i, y);
-              for (int j = 0; j < y; j++)
-                {
-                  if (match_byte(3))
-                    {
-                      char *a = get_string();
-                      match_byte_assert(0x58);
-                      char *b = get_string();
-                      char *c = get_string();
-                      for (int k = 0; k <= level + 1; k++)
-                        printf ("    ");
-                      printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                    }
-                  else
-                    dump_value (level+1);
-                  putchar('\n');
-                }
-            }
-        }
     }
   else
     {
-
-      match_byte_assert (0x58);
+      dump_value_31();
       char *base = get_string();
+
       int x = get_u32();
       printf ("\"%s\" with %d variables:\n", base, x);
       if (match_u32(0))
@@ -417,25 +352,10 @@ dump_dim_value(int level)
   if (match_byte (3))
     {
       get_string();
-      if (match_byte (0x31))
-        {
-          match_u32 (1);
-          printf("(footnote %d) ", get_u32());
-          match_byte_assert (0);
-          match_byte_assert (0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes", subn);
-          pos += subn;
-        }
-      else
-        match_byte_assert (0x58);
+      dump_value_31();
       get_string();
       printf("string \"%s\"", get_string());
       match_byte (0);
-      match_byte_assert (1);
-      match_byte (0);
-      match_byte (0);
-      match_byte (0);
       match_byte (1);
     }
   else if (match_byte (5))
@@ -443,7 +363,8 @@ dump_dim_value(int level)
       match_byte_assert (0x58);
       printf ("variable \"%s\"", get_string());
       get_string();
-      match_byte_assert (2);
+      if (!match_byte (2))
+        match_byte_assert(3);
     }
   else if (match_byte (2))
     {
@@ -479,15 +400,8 @@ dump_dim_value(int level)
     }
   else
     {
-      int subn;
-
       match_byte (0);
-      match_byte_assert (0x31);
-      match_u32_assert (0);
-      match_u32_assert (0);
-      subn = get_u32 ();
-      printf ("nested %d bytes", subn);
-      pos += subn;
+      dump_value_31();
       printf ("; \"%s\", substitutions:", get_string());
       int total_subs = get_u32();
       int x = get_u32();
@@ -552,69 +466,7 @@ dump_dim(void)
   int n_categories;
   printf("next dim\n");
   match_byte(0);
-  if (match_byte(3))
-    {
-      get_string();
-      match_byte_assert(0x58);
-      get_string();
-      printf("string \"%s\": ", get_string());
-      match_byte(1) || match_byte(0);
-    }
-  else if (match_byte(5)) 
-    {
-      match_byte_assert(0x58);
-      printf("variable \"%s\": ", get_string());
-      get_string();
-      if (!match_byte(2))
-        match_byte_assert(3);
-    }
-  else if (match_byte(0x31))
-    {
-      int subn;
-      int total_subs = 1;
-
-      match_u32_assert (0);
-      match_u32_assert (0);
-      subn = get_u32 ();
-      printf ("nested %d bytes", subn);
-      pos += subn;
-      printf ("; \"%s\", substitutions:", get_string());
-      for (;;)
-        {
-          int n_subst = get_u32();
-          if (!n_subst)
-            break;
-          printf (" %d", n_subst);
-          total_subs *= n_subst;
-        }
-
-      for (int i = 0; i < total_subs; i++)
-        {
-          putc ('\n', stdout);
-          dump_dim_value (0);
-        }
-    }
-  else
-    {
-      int total_subs = 1;
-
-      match_byte_assert (0x58);
-      printf ("\"%s\" with substitutions:", get_string());
-      for (;;)
-        {
-          int n_subst = get_u32();
-          if (!n_subst)
-            break;
-          printf (" %d", n_subst);
-          total_subs *= n_subst;
-        }
-
-      for (int i = 0; i < total_subs; i++)
-        {
-          putc ('\n', stdout);
-          dump_dim_value (0);
-        }
-    }
+  dump_dim_value(0);
 
   /* This byte is usually 0x02 but 0x00 and 0x75 (!) have also been spotted. */
   pos++;
@@ -654,351 +506,119 @@ dump_dims(void)
 }
 
 static void
-dump_data(void)
+dump_data_value(void)
 {
-#if 1
-  int a[16];
-  for (int i = 0; i < 3 + n_dims; i++)
-    a[i] = get_u32();
-  printf ("data intro:");
-  for (int i = 0; i < 3 + n_dims; i++)
-    printf(" %d", a[i]);
-  printf("\n");
-#else
-  fprintf (stderr,"data intro (%d dims):", n_dims);
-  for (int i = 0; i < 3+n_dims; i++)
-    fprintf (stderr," %d", get_u32());
-  fprintf(stderr,"\n");
-#endif
-  int x = get_u32();
-  printf ("%d data values, starting at %08x\n", x, pos);
-  for (int i = 0; i < x; i++)
+  match_byte(0);
+  match_byte(0);
+  match_byte(0);
+  match_byte(0);
+  if (match_byte (1))
     {
-      printf("%08x, index %d:\n", pos, get_u32());
-      match_u32_assert(0);
-      match_byte(0);
-      match_byte(0);
-      match_byte(0);
-      match_byte(0);
-      if (match_byte (1))
-        {
-          unsigned int format;
-          double value;
+      unsigned int format;
+      double value;
 
-          if (match_byte (0x31))
-            {
-              if (match_u32 (0))
-                {
-                  if (match_u32 (1))
-                    get_string();
-                  else
-                    match_u32_assert (0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-              else if (match_u32 (1))
-                {
-                  printf("(footnote %d) ", get_u32());
-                  match_byte_assert (0);
-                  match_byte_assert (0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-              else
-                {
-                  match_u32_assert(2);
-                  printf("(special 2)");
-                  match_byte_assert(0);
-                  match_byte_assert(0);
-                  match_u32_assert(1);
-                  match_byte_assert(0);
-                  match_byte_assert(0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-            }
-          else
-            match_byte_assert (0x58);
-          format = get_u32 ();
-          value = get_double ();
-          printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
-        }
-      else if (match_byte (3))
-        {
-          get_string();
-          if (match_byte (0x31))
-            {
-              if (match_u32 (0))
-                {
-                  match_u32_assert (1);
-                  get_string ();
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-              else if (match_u32 (1))
-                {
-                  printf("(footnote %d) ", get_u32());
-                  match_byte_assert (0);
-                  match_byte_assert (0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-              else if (match_u32 (2))
-                {
-                  printf("(special 2)");
-                  match_byte_assert(0);
-                  match_byte_assert(0);
-                  match_u32_assert(1);
-                  match_byte_assert(0);
-                  match_byte_assert(0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes", subn);
-                  pos += subn;
-                }
-              else
-                {
-                  match_u32_assert(3);
-                  printf("(special 3)");
-                  match_byte_assert(0);
-                  match_byte_assert(0);
-                  match_byte_assert(1);
-                  match_byte_assert(0);
-                  int subn = get_u32 ();
-                  printf ("nested %d bytes, ", subn);
-                  pos += subn;
-                  subn = get_u32 ();
-                  printf ("nested %d bytes, ", subn);
-                  pos += subn;
-                }
-            }
-          else
-            match_byte_assert (0x58);
-          get_string();
-          printf("string \"%s\"", get_string());
-          match_byte (0);
-        }
-      else if (match_byte (2))
-        {
-          unsigned int format;
-          char *var, *vallab;
-          double value;
-
-          match_byte_assert (0x58);
-          format = get_u32 ();
-          value = get_double ();
-          var = get_string ();
-          vallab = get_string ();
-          printf ("value %g format %d(%d.%d) var \"%s\" vallab \"%s\"",
-                  value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
-          if (!match_byte (1) && !match_byte(2))
-            match_byte_assert (3);
-        }
-      else if (match_byte (4))
-        {
-          unsigned int format;
-          char *var, *vallab, *value;
-
-          match_byte_assert (0x58);
-          format = get_u32 ();
-          vallab = get_string ();
-          var = get_string ();
-          if (!match_byte(1) && !match_byte(2))
-            match_byte_assert (3);
-          value = get_string ();
-          printf ("value \"%s\" format %d(%d.%d) var \"%s\" vallab \"%s\"",
-                  value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
-        }
-      else if (match_byte (5))
-        {
-          match_byte_assert (0x58);
-          printf ("variable \"%s\"", get_string());
-          get_string();
-          if (!match_byte(1) && !match_byte(2))
-            match_byte_assert(3);
-          match_byte (0);
-          match_byte (0);
-          match_byte (0);
-          match_byte (0);
-        }
-      else if (match_byte(0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          else
-            {
-              match_u32_assert (0);
-              match_u32_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          char *base = get_string();
-          int x = get_u32();
-          printf ("\"%s\"; %d variables:\n", base, x);
-          for (int i = 0; i < x; i++)
-            {
-              int y = get_u32();
-              if (!y)
-                y = 1;
-              else
-                match_u32_assert(0);
-              for (int j = 0; j <= 0; j++)
-                printf ("    ");
-              printf("variable %d has %d values:\n", i, y);
-              for (int j = 0; j < y; j++)
-                {
-                  if (match_byte (1))
-                    {
-                      unsigned int format;
-                      double value;
-
-                      if (match_byte (0x31))
-                        {
-                          if (match_u32 (0))
-                            {
-                              if (match_u32 (1))
-                                get_string();
-                              else
-                                match_u32_assert (0);
-                              int subn = get_u32 ();
-                              printf ("nested %d bytes", subn);
-                              pos += subn;
-                            }
-                          else if (match_u32 (1))
-                            {
-                              printf("(footnote %d) ", get_u32());
-                              match_byte_assert (0);
-                              match_byte_assert (0);
-                              int subn = get_u32 ();
-                              printf ("nested %d bytes", subn);
-                              pos += subn;
-                            }
-                          else
-                            {
-                              match_u32_assert(2);
-                              printf("(special 2)");
-                              match_byte_assert(0);
-                              match_byte_assert(0);
-                              match_u32_assert(1);
-                              match_byte_assert(0);
-                              match_byte_assert(0);
-                              int subn = get_u32 ();
-                              printf ("nested %d bytes", subn);
-                              pos += subn;
-                            }
-                        }
-                      else
-                        match_byte_assert (0x58);
-                      format = get_u32 ();
-                      value = get_double ();
-                      printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
-                    }
-                  else if (match_byte(3))
-                    {
-                      char *a = get_string();
-                      match_byte_assert(0x58);
-                      char *b = get_string();
-                      char *c = get_string();
-                      for (int k = 0; k <= 1; k++)
-                        printf ("    ");
-                      printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                    }
-                  else if (match_byte(5))
-                    {
-                      match_byte_assert (0x58);
-                      printf ("variable \"%s\"", get_string());
-                      get_string();
-                      if (!match_byte(1) && !match_byte(2))
-                        match_byte_assert(3);
-                      match_byte (0);
-                      match_byte (0);
-                      match_byte (0);
-                      match_byte (0);
-                    }
-                  else
-                    dump_value (0);
-                  putchar('\n');
-                }
-            }
-        }
-      else
+      dump_value_31();
+      format = get_u32 ();
+      value = get_double ();
+      printf ("    value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
+    }
+  else if (match_byte (3))
+    {
+      get_string();
+      dump_value_31();
+      get_string();
+      printf("string \"%s\"", get_string());
+      match_byte (0);
+    }
+  else if (match_byte (2))
+    {
+      unsigned int format;
+      char *var, *vallab;
+      double value;
+
+      match_byte_assert (0x58);
+      format = get_u32 ();
+      value = get_double ();
+      var = get_string ();
+      vallab = get_string ();
+      printf ("value %g format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+      if (!match_byte (1) && !match_byte(2))
+        match_byte_assert (3);
+    }
+  else if (match_byte (4))
+    {
+      unsigned int format;
+      char *var, *vallab, *value;
+
+      match_byte_assert (0x58);
+      format = get_u32 ();
+      vallab = get_string ();
+      var = get_string ();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert (3);
+      value = get_string ();
+      printf ("value \"%s\" format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+    }
+  else if (match_byte (5))
+    {
+      match_byte_assert (0x58);
+      printf ("variable \"%s\"", get_string());
+      get_string();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert(3);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+    }
+  else
+    {
+      dump_value_31();
+      char *base = get_string();
+      int x = get_u32();
+      printf ("\"%s\"; %d variables:\n", base, x);
+      for (int i = 0; i < x; i++)
         {
-          match_byte_assert (0x58);
-          char *base = get_string();
-          int x = get_u32();
-          printf ("\"%s\" with %d variables:\n", base, x);
-          for (int i = 0; i < x; i++)
-            {
-              int y = get_u32();
-              if (!y)
-                y = 1;
-              else
-                match_u32_assert(0);
-              for (int j = 0; j <= 0; j++)
-                printf ("    ");
-              printf("variable %d has %d values:\n", i, y);
-              for (int j = 0; j < y; j++)
-                {
-                  if (match_byte(3))
-                    {
-                      char *a = get_string();
-                      match_byte_assert(0x58);
-                      char *b = get_string();
-                      char *c = get_string();
-                      for (int k = 0; k <= 1; k++)
-                        printf ("    ");
-                      printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                      match_byte(0);
-                    }
-                  else if (match_byte (1))
-                    {
-                      unsigned int format;
-                      double value;
-
-                      if (match_byte (0x31))
-                        {
-                          if (match_u32 (1))
-                            {
-                              printf("(footnote %d) ", get_u32());
-                              match_byte_assert (0);
-                              match_byte_assert (0);
-                              int subn = get_u32 ();
-                              printf ("nested %d bytes", subn);
-                              pos += subn;
-                            }
-                        }
-                      else
-                        match_byte_assert (0x58);
-                      format = get_u32 ();
-                      value = get_double ();
-                      printf ("value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
-                    }
-                  else
-                    dump_value (1);
-                  putchar('\n');
-                }
-            }
+          int y = get_u32();
+          if (!y)
+            y = 1;
+          else
+            match_u32_assert(0);
+          for (int j = 0; j <= 0; j++)
+            printf ("    ");
+          printf("variable %d has %d values:\n", i, y);
+          for (int j = 0; j < y; j++)
+            dump_data_value();
         }
+    }
+}
+
+static void
+dump_data(void)
+{
+#if 1
+  int a[16];
+  for (int i = 0; i < 3 + n_dims; i++)
+    a[i] = get_u32();
+  printf ("data intro:");
+  for (int i = 0; i < 3 + n_dims; i++)
+    printf(" %d", a[i]);
+  printf("\n");
+#else
+  fprintf (stderr,"data intro (%d dims):", n_dims);
+  for (int i = 0; i < 3+n_dims; i++)
+    fprintf (stderr," %d", get_u32());
+  fprintf(stderr,"\n");
+#endif
+  int x = get_u32();
+  printf ("%d data values, starting at %08x\n", x, pos);
+  for (int i = 0; i < x; i++)
+    {
+      printf("%08x, index %d:\n", pos, get_u32());
+      match_u32_assert(0);
+      dump_data_value();
       putchar('\n');
     }
 }
@@ -1013,80 +633,22 @@ dump_title_value(int level)
   match_byte (0);
   match_byte (0);
   match_byte (0);
-  match_byte (0);
   if (match_byte (3))
     {
       get_string();
-      if (match_byte (0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          else if (match_u32 (2))
-            {
-              printf("(special 2)");
-              match_byte_assert(0);
-              match_byte_assert(0);
-              if (!match_u32(2))
-                match_u32_assert(1);
-              match_byte_assert(0);
-              match_byte_assert(0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-          else
-            {
-              match_u32_assert(3);
-              printf("(special 3)");
-              match_byte_assert(0);
-              match_byte_assert(0);
-              match_byte_assert(1);
-              match_byte_assert(0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes, ", subn);
-              pos += subn;
-              subn = get_u32 ();
-              printf ("nested %d bytes, ", subn);
-              pos += subn;
-            }
-        }
-      else
-        match_byte_assert (0x58);
+      dump_value_31();
       get_string();
       printf("string \"%s\"", get_string());
       match_byte (0);
-      match_byte (0);
-      match_byte (0);
       match_byte (1);
       match_byte (1);
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (1);
     }
   else if (match_byte (5))
     {
-      if (match_byte (0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-        }
-      else
-        match_byte_assert (0x58);
+      dump_value_31();
       printf ("variable \"%s\"", get_string());
       get_string();
       if (!match_byte(1) && !match_byte(2))
@@ -1110,10 +672,6 @@ dump_title_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (0);
-      match_byte (0);
-      match_byte (0);
-      match_byte (0);
     }
   else if (match_byte (4))
     {
@@ -1132,27 +690,13 @@ dump_title_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (0);
     }
   else if (match_byte (1))
     {
       unsigned int format;
       double value;
 
-      if (match_byte (0x31))
-        {
-          if (match_u32 (1))
-            {
-              printf("(footnote %d) ", get_u32());
-              match_byte_assert (0);
-              match_byte_assert (0);
-              int subn = get_u32 ();
-              printf ("nested %d bytes", subn);
-              pos += subn;
-            }
-        }
-      else
-        match_byte_assert (0x58);
+      dump_value_31();
       format = get_u32 ();
       value = get_double ();
       printf ("value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
@@ -1160,45 +704,14 @@ dump_title_value(int level)
       match_byte (0);
       match_byte (0);
       match_byte (0);
-      match_byte (1);
     }
-  else if (match_byte (0x31))
+  else
     {
-      if (match_u32 (1))
-        {
-          printf("(footnote %d) ", get_u32());
-          match_byte_assert (0);
-          match_byte_assert (0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes", subn);
-          pos += subn;
-        }
-      else if (match_u32 (0))
-        {
-          match_u32_assert (0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes", subn);
-          pos += subn;
-        }
-      else
-        {
-          match_u32_assert(3);
-          printf("(special 3)");
-          match_byte_assert(0);
-          match_byte_assert(0);
-          match_byte_assert(1);
-          match_byte_assert(0);
-          int subn = get_u32 ();
-          printf ("nested %d bytes, ", subn);
-          pos += subn;
-          subn = get_u32 ();
-          printf ("nested %d bytes, ", subn);
-          pos += subn;
-        }
+      dump_value_31();
 
       char *base = get_string();
       int x = get_u32();
-      printf ("\"%s\"; %d variables:\n", base, x);
+      printf ("\"%s\" with %d variables:\n", base, x);
       for (int i = 0; i < x; i++)
         {
           int y = get_u32();
@@ -1211,6 +724,7 @@ dump_title_value(int level)
           printf("variable %d has %d values:\n", i, y);
           for (int j = 0; j < y; j++)
             {
+              match_byte(0);
               if (match_byte(3))
                 {
                   char *a = get_string();
@@ -1220,7 +734,6 @@ dump_title_value(int level)
                   for (int k = 0; k <= level + 1; k++)
                     printf ("    ");
                   printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
-                  match_byte(0);
                 }
               else
                 dump_title_value (level+1);
@@ -1228,12 +741,93 @@ dump_title_value(int level)
             }
         }
     }
-  else
+}
+
+static void
+dump_footnote_value(int level)
+{
+  for (int i = 0; i <= level; i++)
+    printf ("    ");
+
+  match_byte (0);
+  match_byte (0);
+  match_byte (0);
+  match_byte (0);
+  if (match_byte (3))
+    {
+      get_string();
+      dump_value_31();
+      get_string();
+      printf("string \"%s\"", get_string());
+      if (!match_byte (0))
+        match_byte_assert (1);
+    }
+  else if (match_byte (5))
+    {
+      match_byte_assert (0x58);
+      printf ("variable \"%s\"", get_string());
+      get_string();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert(3);
+    }
+  else if (match_byte (2))
+    {
+      unsigned int format;
+      char *var, *vallab;
+      double value;
+
+      match_byte_assert (0x58);
+      format = get_u32 ();
+      value = get_double ();
+      var = get_string ();
+      vallab = get_string ();
+      printf ("value %g format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+      if (!match_byte (1) && !match_byte(2))
+        match_byte_assert (3);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+    }
+  else if (match_byte (4))
     {
+      unsigned int format;
+      char *var, *vallab, *value;
+
       match_byte_assert (0x58);
+      format = get_u32 ();
+      vallab = get_string ();
+      var = get_string ();
+      if (!match_byte(1) && !match_byte(2))
+        match_byte_assert (3);
+      value = get_string ();
+      printf ("value \"%s\" format %d(%d.%d) var \"%s\" vallab \"%s\"",
+              value, format >> 16, (format >> 8) & 0xff, format & 0xff, var, vallab);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+      match_byte (0);
+    }
+  else if (match_byte (1))
+    {
+      unsigned int format;
+      double value;
+
+      dump_value_31();
+      format = get_u32 ();
+      value = get_double ();
+      printf ("value %g format %d(%d.%d)", value, format >> 16, (format >> 8) & 0xff, format & 0xff);
+    }
+  else
+    {
+      dump_value_31();
       char *base = get_string();
       int x = get_u32();
-      printf ("\"%s\" with %d variables:\n", base, x);
+      printf ("\"%s\"; %d variables:\n", base, x);
       for (int i = 0; i < x; i++)
         {
           int y = get_u32();
@@ -1255,9 +849,11 @@ dump_title_value(int level)
                   for (int k = 0; k <= level + 1; k++)
                     printf ("    ");
                   printf ("\"%s\", \"%s\", \"%s\"", a, b, c);
+                  if (!match_byte(1))
+                    match_byte_assert(0);
                 }
               else
-                dump_title_value (level+1);
+                dump_footnote_value (level+1);
               putchar('\n');
             }
         }
@@ -1268,37 +864,46 @@ static void
 dump_title(void)
 {
   pos = 0x27;
-  dump_title_value(0); putchar('\n'); putchar('\n');
-  dump_title_value(0); putchar('\n'); putchar('\n');
+  dump_title_value(0); putchar('\n');
+  dump_title_value(0); putchar('\n');
   match_byte_assert(0x31);
-  dump_title_value(0); putchar('\n'); putchar('\n');
+  dump_title_value(0); putchar('\n');
   match_byte(0);
   match_byte_assert(0x58);
   if (match_byte(0x31))
     {
-      dump_title_value(0); putchar('\n');
+      dump_footnote_value(0); putchar('\n');
     }
   else
     match_byte_assert(0x58);
 
 
   int n_footnotes = get_u32();
-  fprintf(stderr, "%d footnotes\n", n_footnotes);
+  if (n_footnotes >= 20)
+    {
+      fprintf(stderr, "%08x: %d footnotes\n", pos - 4, n_footnotes);
+      exit(1);
+    }
+
   printf("------\n%d footnotes\n", n_footnotes);
-  if (n_footnotes < 10)
+  if (n_footnotes < 20)
     {
       for (int i = 0; i < n_footnotes; i++)
         {
           printf("footnote %d:\n", i);
-          dump_value(0);
+          dump_footnote_value(0);
+          match_byte(0);
+          match_byte(0);
+          match_byte(0);
+          match_byte(0);
           if (match_byte (0x31))
             {
+              /* Custom footnote marker string. */
               match_byte_assert(3);
               get_string();
               match_byte_assert(0x58);
               match_u32_assert(0);
               get_string();
-              match_byte_assert(0);
             }
           else
             match_byte_assert (0x58);
@@ -1307,6 +912,98 @@ dump_title(void)
     }
 }
 
+static int
+find_dimensions(void)
+{
+  {
+    const char dimensions[] = "-,,,.\0";
+    int x = try_find_tail(dimensions, sizeof dimensions - 1);
+    if (x)
+      return x;
+  }
+
+  const char dimensions[] = "-,,, .\0";
+  return find_tail(dimensions, sizeof dimensions - 1);
+}
+
+static void
+dump_fonts(void)
+{
+  printf("fonts: offset=%08x\n", pos);
+  match_byte(0);
+  for (int i = 1; i <= 8; i++)
+    {
+      printf("%08x: font %d, ", pos, i);
+      match_byte_assert(i);
+      match_byte_assert(0x31);
+      printf("%s, ", get_string());
+      match_byte_assert(0);
+      match_byte_assert(0);
+      if (!match_byte(0x40) && !match_byte(0x20) && !match_byte(0x80) && !match_byte(0x10))
+        match_byte_assert(0x50);
+      if (!match_byte(0x41))
+        match_byte_assert(0x51);
+      pos += 13;
+      printf ("%s, ", get_string());
+      printf ("%s, ", get_string());
+      match_u32_assert(0);
+      match_u32_assert(0);
+      pos++;
+      get_u32();
+      get_u32();
+      get_u32();
+      get_u32();
+      putchar('\n');
+    }
+
+  match_u32_assert(240);
+  pos += 240;
+
+  match_u32_assert(18);
+  pos += 18;
+
+  if (match_u32(117))
+    pos += 117;
+  else
+    {
+      match_u32_assert(142);
+      pos += 142;
+    }
+
+  int count = get_u32();
+  pos += 4 * count;
+
+  char *encoding = get_string();
+  printf("encoding=%s\n", encoding);
+
+  if (!match_u32(0))
+    match_u32_assert(UINT32_MAX);
+  if (!match_byte(0))
+    match_byte_assert(1);
+  match_byte_assert(0);
+  if (!match_byte(0))
+    match_byte_assert(1);
+  if (!match_byte(0x99) && !match_byte(0x98))
+    match_byte_assert(0x97);
+  match_byte_assert(7);
+  match_byte_assert(0);
+  match_byte_assert(0);
+  if (match_byte('.'))
+    match_byte_assert(',');
+  else
+    {
+      match_byte_assert(',');
+      if (!match_byte('.'))
+        match_byte_assert(' ');
+    }
+  match_u32_assert(5);
+  for (int i = 0; i < 5; i++)
+    get_string();
+  pos += get_u32();
+  if (pos != find_dimensions())
+    fprintf (stderr, "%08x / %08x\n", pos, find_dimensions());
+}
+
 int
 main(int argc, char *argv[])
 {
@@ -1375,22 +1072,33 @@ main(int argc, char *argv[])
         }
       else if (!strcmp(argv[1], "dimensions") || !strcmp(argv[1], "all"))
         {
-          {
-            const char dimensions[] = "-,,,.\0";
-            start = try_find_tail(dimensions, sizeof dimensions - 1);
-          }
-
-          if (!start)
-            {
-              const char dimensions[] = "-,,, .\0";
-              start = find_tail(dimensions, sizeof dimensions - 1);
-            }
-
-          pos = start;
+          pos = 0;
+          match_byte_assert(1);
+          match_byte_assert(0);
+          match_u32_assert(3);
+          match_byte_assert(1);
+          if (!match_byte(0))
+            match_byte_assert(1);
+          match_byte_assert(0);
+          match_byte_assert(0);
+          if (!match_byte(0))
+            match_byte_assert(1);
+          pos++;
+          match_byte_assert(0);
+          match_byte_assert(0);
+          match_byte_assert(0);
+          dump_title ();
+          dump_fonts();
           dump_dims ();
+          printf("\n\ndata:\n");
           dump_data ();
-          if (!strcmp(argv[1], "all"))
-            dump_title ();
+          if (pos == n - 1)
+            match_byte_assert (1);
+          if (pos != n)
+            {
+              fprintf (stderr, "%x / %x\n", pos, n);
+              exit(1);
+            }
           exit(0);
         }
       else