X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=doc%2Fstandards.texi;h=ab0f01a15c4965c0641f787d606059e90ee7bc3b;hb=63bae7d91cfdc5d6f73b52702ecb6dcca515496c;hp=fd25730e370c1ca1b6506ef791cf2d0b241f82c0;hpb=bfc014623e8ece5a3258f83b00a9948b73403a44;p=pintos-anon diff --git a/doc/standards.texi b/doc/standards.texi index fd25730..ab0f01a 100644 --- a/doc/standards.texi +++ b/doc/standards.texi @@ -42,6 +42,8 @@ different style won't cause actual problems, but it's ugly to see gratuitous differences in style from one function to another. If your code is too ugly, it will cost you points. +Please limit C source file lines to at most 79 characters long. + Pintos comments sometimes refer to external standards or specifications by writing a name inside square brackets, like this: @code{[IA32-v3]}. These names refer to the reference names used in @@ -77,11 +79,6 @@ compile properly without the need for any new macros to be defined. There are a few exceptions: @itemize @bullet -@item -Problem 1-2, @func{thread_join}. Some other code expects -@code{THREAD_JOIN_IMPLEMENTED} to be defined once you've implemented -this function. - @item Problem 1-4, the advanced scheduler. We must be able to turn this on and off with a compile-time directive. You must use the macro name we @@ -207,7 +204,7 @@ terminator and it has performance problems besides. Again, use @func{strlcpy}. @item strcat -Same issue as @func{strcpy}, but substitute @func{strlcat}. +Same issue as @func{strcpy}. Use @func{strlcat} instead. Again, refer to comments in its source code in @code{lib/string.c} for documentation.