X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=datapath%2Fdatapath.c;h=32572c6f9d5a2bced7cdc005a3e4d0ec45cc1540;hb=431585099e82a88a23d5dec28138b5a3a8bb11da;hp=c715f0ec7d3650f879efb720f2d3c176823959a8;hpb=9fc10ed911312c9cec86ef968877cae568770151;p=openvswitch diff --git a/datapath/datapath.c b/datapath/datapath.c index c715f0ec..32572c6f 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -32,7 +32,7 @@ #include #include #include -#include +#include #include #include #include @@ -69,8 +69,22 @@ EXPORT_SYMBOL(dp_ioctl_hook); static struct datapath *dps[ODP_MAX]; static DEFINE_MUTEX(dp_mutex); -/* Number of milliseconds between runs of the maintenance thread. */ -#define MAINT_SLEEP_MSECS 1000 +/* We limit the number of times that we pass into dp_process_received_packet() + * to avoid blowing out the stack in the event that we have a loop. */ +struct loop_counter { + int count; /* Count. */ + bool looping; /* Loop detected? */ +}; + +#define DP_MAX_LOOPS 5 + +/* We use a separate counter for each CPU for both interrupt and non-interrupt + * context in order to keep the limit deterministic for a given packet. */ +struct percpu_loop_counters { + struct loop_counter counters[2]; +}; + +static DEFINE_PER_CPU(struct percpu_loop_counters, dp_loop_counters); static int new_dp_port(struct datapath *, struct odp_port *, int port_no); @@ -380,6 +394,7 @@ static int new_dp_port(struct datapath *dp, struct odp_port *odp_port, int port_ p->port_no = port_no; p->dp = dp; + p->vport = vport; atomic_set(&p->sflow_pool, 0); err = vport_attach(vport, p); @@ -513,6 +528,14 @@ out: return err; } +static void suppress_loop(struct datapath *dp, struct sw_flow_actions *actions) +{ + if (net_ratelimit()) + printk(KERN_WARNING "%s: flow looped %d times, dropping\n", + dp_name(dp), DP_MAX_LOOPS); + actions->n_actions = 0; +} + /* Must be called with rcu_read_lock. */ void dp_process_received_packet(struct dp_port *p, struct sk_buff *skb) { @@ -521,12 +544,13 @@ void dp_process_received_packet(struct dp_port *p, struct sk_buff *skb) int stats_counter_off; struct odp_flow_key key; struct tbl_node *flow_node; - - WARN_ON_ONCE(skb_shared(skb)); - skb_warn_if_lro(skb); + struct sw_flow *flow; + struct sw_flow_actions *acts; + struct loop_counter *loop; OVS_CB(skb)->dp_port = p; + /* Extract flow from 'skb' into 'key'. */ if (flow_extract(skb, p ? p->port_no : ODPP_NONE, &key)) { if (dp->drop_frags) { kfree_skb(skb); @@ -535,23 +559,51 @@ void dp_process_received_packet(struct dp_port *p, struct sk_buff *skb) } } + /* Look up flow. */ flow_node = tbl_lookup(rcu_dereference(dp->table), &key, flow_hash(&key), flow_cmp); - if (flow_node) { - struct sw_flow *flow = flow_cast(flow_node); - struct sw_flow_actions *acts = rcu_dereference(flow->sf_acts); - flow_used(flow, skb); - execute_actions(dp, skb, &key, acts->actions, acts->n_actions, - GFP_ATOMIC); - stats_counter_off = offsetof(struct dp_stats_percpu, n_hit); - } else { - stats_counter_off = offsetof(struct dp_stats_percpu, n_missed); + if (unlikely(!flow_node)) { dp_output_control(dp, skb, _ODPL_MISS_NR, OVS_CB(skb)->tun_id); + stats_counter_off = offsetof(struct dp_stats_percpu, n_missed); + goto out; } + flow = flow_cast(flow_node); + flow_used(flow, skb); + + acts = rcu_dereference(flow->sf_acts); + + /* Check whether we've looped too much. */ + loop = &get_cpu_var(dp_loop_counters).counters[!!in_interrupt()]; + if (unlikely(++loop->count > DP_MAX_LOOPS)) + loop->looping = true; + if (unlikely(loop->looping)) { + suppress_loop(dp, acts); + goto out_loop; + } + + /* Execute actions. */ + execute_actions(dp, skb, &key, acts->actions, acts->n_actions, GFP_ATOMIC); + stats_counter_off = offsetof(struct dp_stats_percpu, n_hit); + + /* Check whether sub-actions looped too much. */ + if (unlikely(loop->looping)) + suppress_loop(dp, acts); + +out_loop: + /* Decrement loop counter. */ + if (!--loop->count) + loop->looping = false; + put_cpu_var(dp_loop_counters); + out: + /* Update datapath statistics. */ local_bh_disable(); stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); + + write_seqcount_begin(&stats->seqlock); (*(u64 *)((u8 *)stats + stats_counter_off))++; + write_seqcount_end(&stats->seqlock); + local_bh_enable(); } @@ -656,8 +708,7 @@ out: * be reverified). If we receive a packet with CHECKSUM_HW that really means * CHECKSUM_PARTIAL, it will be sent with the wrong checksum. However, there * shouldn't be any devices that do this with bridging. */ -void -compute_ip_summed(struct sk_buff *skb, bool xmit) +void compute_ip_summed(struct sk_buff *skb, bool xmit) { /* For our convenience these defines change repeatedly between kernel * versions, so we can't just copy them over... */ @@ -714,8 +765,7 @@ compute_ip_summed(struct sk_buff *skb, bool xmit) * is slightly different because we are only concerned with bridging and not * other types of forwarding and can get away with slightly more optimal * behavior.*/ -void -forward_ip_summed(struct sk_buff *skb) +void forward_ip_summed(struct sk_buff *skb) { #ifdef CHECKSUM_HW if (OVS_CB(skb)->ip_summed == OVS_CSUM_COMPLETE) @@ -725,9 +775,8 @@ forward_ip_summed(struct sk_buff *skb) /* Append each packet in 'skb' list to 'queue'. There will be only one packet * unless we broke up a GSO packet. */ -static int -queue_control_packets(struct sk_buff *skb, struct sk_buff_head *queue, - int queue_no, u32 arg) +static int queue_control_packets(struct sk_buff *skb, struct sk_buff_head *queue, + int queue_no, u32 arg) { struct sk_buff *nskb; int port_no; @@ -769,9 +818,8 @@ err_kfree_skbs: return err; } -int -dp_output_control(struct datapath *dp, struct sk_buff *skb, int queue_no, - u32 arg) +int dp_output_control(struct datapath *dp, struct sk_buff *skb, int queue_no, + u32 arg) { struct dp_stats_percpu *stats; struct sk_buff_head *queue; @@ -816,7 +864,11 @@ err_kfree_skb: err: local_bh_disable(); stats = per_cpu_ptr(dp->stats_percpu, smp_processor_id()); + + write_seqcount_begin(&stats->seqlock); stats->n_lost++; + write_seqcount_end(&stats->seqlock); + local_bh_enable(); return err; @@ -907,27 +959,43 @@ error: return ERR_PTR(error); } -static void get_stats(struct sw_flow *flow, struct odp_flow_stats *stats) +static struct timespec get_time_offset(void) { - if (flow->used.tv_sec) { - stats->used_sec = flow->used.tv_sec; - stats->used_nsec = flow->used.tv_nsec; + struct timespec now_mono, now_jiffies; + + ktime_get_ts(&now_mono); + jiffies_to_timespec(jiffies, &now_jiffies); + return timespec_sub(now_mono, now_jiffies); +} + +static void get_stats(struct sw_flow *flow, struct odp_flow_stats *stats, + struct timespec time_offset) +{ + if (flow->used) { + struct timespec flow_ts, used; + + jiffies_to_timespec(flow->used, &flow_ts); + set_normalized_timespec(&used, flow_ts.tv_sec + time_offset.tv_sec, + flow_ts.tv_nsec + time_offset.tv_nsec); + + stats->used_sec = used.tv_sec; + stats->used_nsec = used.tv_nsec; } else { stats->used_sec = 0; stats->used_nsec = 0; } + stats->n_packets = flow->packet_count; stats->n_bytes = flow->byte_count; - stats->ip_tos = flow->ip_tos; + stats->reserved = 0; stats->tcp_flags = flow->tcp_flags; stats->error = 0; } static void clear_stats(struct sw_flow *flow) { - flow->used.tv_sec = flow->used.tv_nsec = 0; + flow->used = 0; flow->tcp_flags = 0; - flow->ip_tos = 0; flow->packet_count = 0; flow->byte_count = 0; } @@ -1025,7 +1093,7 @@ static int do_put_flow(struct datapath *dp, struct odp_flow_put *uf, /* Fetch stats, then clear them if necessary. */ spin_lock_bh(&flow->lock); - get_stats(flow, stats); + get_stats(flow, stats, get_time_offset()); if (uf->flags & ODPPF_ZERO_STATS) clear_stats(flow); spin_unlock_bh(&flow->lock); @@ -1062,6 +1130,7 @@ static int put_flow(struct datapath *dp, struct odp_flow_put __user *ufp) } static int do_answer_query(struct sw_flow *flow, u32 query_flags, + struct timespec time_offset, struct odp_flow_stats __user *ustats, union odp_action __user *actions, u32 __user *n_actionsp) @@ -1071,7 +1140,7 @@ static int do_answer_query(struct sw_flow *flow, u32 query_flags, u32 n_actions; spin_lock_bh(&flow->lock); - get_stats(flow, &stats); + get_stats(flow, &stats, time_offset); if (query_flags & ODPFF_ZERO_TCP_FLAGS) flow->tcp_flags = 0; @@ -1095,6 +1164,7 @@ static int do_answer_query(struct sw_flow *flow, u32 query_flags, } static int answer_query(struct sw_flow *flow, u32 query_flags, + struct timespec time_offset, struct odp_flow __user *ufp) { union odp_action *actions; @@ -1102,7 +1172,7 @@ static int answer_query(struct sw_flow *flow, u32 query_flags, if (get_user(actions, &ufp->actions)) return -EFAULT; - return do_answer_query(flow, query_flags, + return do_answer_query(flow, query_flags, time_offset, &ufp->stats, actions, &ufp->n_actions); } @@ -1141,7 +1211,7 @@ static int del_flow(struct datapath *dp, struct odp_flow __user *ufp) if (IS_ERR(flow)) return PTR_ERR(flow); - error = answer_query(flow, 0, ufp); + error = answer_query(flow, 0, get_time_offset(), ufp); flow_deferred_free(flow); return error; } @@ -1149,8 +1219,11 @@ static int del_flow(struct datapath *dp, struct odp_flow __user *ufp) static int do_query_flows(struct datapath *dp, const struct odp_flowvec *flowvec) { struct tbl *table = rcu_dereference(dp->table); + struct timespec time_offset; u32 i; + time_offset = get_time_offset(); + for (i = 0; i < flowvec->n_flows; i++) { struct odp_flow __user *ufp = &flowvec->flows[i]; struct odp_flow uf; @@ -1165,7 +1238,7 @@ static int do_query_flows(struct datapath *dp, const struct odp_flowvec *flowvec if (!flow_node) error = put_user(ENOENT, &ufp->stats.error); else - error = answer_query(flow_cast(flow_node), uf.flags, ufp); + error = answer_query(flow_cast(flow_node), uf.flags, time_offset, ufp); if (error) return -EFAULT; } @@ -1176,6 +1249,7 @@ struct list_flows_cbdata { struct odp_flow __user *uflows; u32 n_flows; u32 listed_flows; + struct timespec time_offset; }; static int list_flow(struct tbl_node *node, void *cbdata_) @@ -1187,7 +1261,7 @@ static int list_flow(struct tbl_node *node, void *cbdata_) if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key)) return -EFAULT; - error = answer_query(flow, 0, ufp); + error = answer_query(flow, 0, cbdata->time_offset, ufp); if (error) return error; @@ -1207,6 +1281,8 @@ static int do_list_flows(struct datapath *dp, const struct odp_flowvec *flowvec) cbdata.uflows = flowvec->flows; cbdata.n_flows = flowvec->n_flows; cbdata.listed_flows = 0; + cbdata.time_offset = get_time_offset(); + error = tbl_foreach(rcu_dereference(dp->table), list_flow, &cbdata); return error ? error : cbdata.listed_flows; } @@ -1326,12 +1402,21 @@ static int get_dp_stats(struct datapath *dp, struct odp_stats __user *statsp) stats.max_groups = DP_MAX_GROUPS; stats.n_frags = stats.n_hit = stats.n_missed = stats.n_lost = 0; for_each_possible_cpu(i) { - const struct dp_stats_percpu *s; - s = per_cpu_ptr(dp->stats_percpu, i); - stats.n_frags += s->n_frags; - stats.n_hit += s->n_hit; - stats.n_missed += s->n_missed; - stats.n_lost += s->n_lost; + const struct dp_stats_percpu *percpu_stats; + struct dp_stats_percpu local_stats; + unsigned seqcount; + + percpu_stats = per_cpu_ptr(dp->stats_percpu, i); + + do { + seqcount = read_seqcount_begin(&percpu_stats->seqlock); + local_stats = *percpu_stats; + } while (read_seqcount_retry(&percpu_stats->seqlock, seqcount)); + + stats.n_frags += local_stats.n_frags; + stats.n_hit += local_stats.n_hit; + stats.n_missed += local_stats.n_missed; + stats.n_lost += local_stats.n_lost; } stats.max_miss_queue = DP_MAX_QUEUE_LEN; stats.max_action_queue = DP_MAX_QUEUE_LEN; @@ -1379,8 +1464,7 @@ void set_internal_devs_mtu(const struct datapath *dp) } } -static int -put_port(const struct dp_port *p, struct odp_port __user *uop) +static int put_port(const struct dp_port *p, struct odp_port __user *uop) { struct odp_port op; @@ -1396,8 +1480,7 @@ put_port(const struct dp_port *p, struct odp_port __user *uop) return copy_to_user(uop, &op, sizeof op) ? -EFAULT : 0; } -static int -query_port(struct datapath *dp, struct odp_port __user *uport) +static int query_port(struct datapath *dp, struct odp_port __user *uport) { struct odp_port port; @@ -1444,8 +1527,8 @@ error_unlock: return put_port(dp->ports[port.port], uport); } -static int -do_list_ports(struct datapath *dp, struct odp_port __user *uports, int n_ports) +static int do_list_ports(struct datapath *dp, struct odp_port __user *uports, + int n_ports) { int idx = 0; if (n_ports) { @@ -1461,8 +1544,7 @@ do_list_ports(struct datapath *dp, struct odp_port __user *uports, int n_ports) return idx; } -static int -list_ports(struct datapath *dp, struct odp_portvec __user *upv) +static int list_ports(struct datapath *dp, struct odp_portvec __user *upv) { struct odp_portvec pv; int retval; @@ -1484,8 +1566,8 @@ static void free_port_group(struct rcu_head *rcu) kfree(g); } -static int -do_set_port_group(struct datapath *dp, u16 __user *ports, int n_ports, int group) +static int do_set_port_group(struct datapath *dp, u16 __user *ports, + int n_ports, int group) { struct dp_port_group *new_group, *old_group; int error; @@ -1516,8 +1598,8 @@ error: return error; } -static int -set_port_group(struct datapath *dp, const struct odp_port_group __user *upg) +static int set_port_group(struct datapath *dp, + const struct odp_port_group __user *upg) { struct odp_port_group pg; @@ -1527,10 +1609,9 @@ set_port_group(struct datapath *dp, const struct odp_port_group __user *upg) return do_set_port_group(dp, pg.ports, pg.n_ports, pg.group); } -static int -do_get_port_group(struct datapath *dp, - u16 __user *ports, int n_ports, int group, - u16 __user *n_portsp) +static int do_get_port_group(struct datapath *dp, + u16 __user *ports, int n_ports, int group, + u16 __user *n_portsp) { struct dp_port_group *g; u16 n_copy; @@ -1819,6 +1900,7 @@ static int compat_put_flow(struct datapath *dp, struct compat_odp_flow_put __use } static int compat_answer_query(struct sw_flow *flow, u32 query_flags, + struct timespec time_offset, struct compat_odp_flow __user *ufp) { compat_uptr_t actions; @@ -1826,7 +1908,7 @@ static int compat_answer_query(struct sw_flow *flow, u32 query_flags, if (get_user(actions, &ufp->actions)) return -EFAULT; - return do_answer_query(flow, query_flags, &ufp->stats, + return do_answer_query(flow, query_flags, time_offset, &ufp->stats, compat_ptr(actions), &ufp->n_actions); } @@ -1843,7 +1925,7 @@ static int compat_del_flow(struct datapath *dp, struct compat_odp_flow __user *u if (IS_ERR(flow)) return PTR_ERR(flow); - error = compat_answer_query(flow, 0, ufp); + error = compat_answer_query(flow, 0, get_time_offset(), ufp); flow_deferred_free(flow); return error; } @@ -1851,8 +1933,11 @@ static int compat_del_flow(struct datapath *dp, struct compat_odp_flow __user *u static int compat_query_flows(struct datapath *dp, struct compat_odp_flow *flows, u32 n_flows) { struct tbl *table = rcu_dereference(dp->table); + struct timespec time_offset; u32 i; + time_offset = get_time_offset(); + for (i = 0; i < n_flows; i++) { struct compat_odp_flow __user *ufp = &flows[i]; struct odp_flow uf; @@ -1867,7 +1952,7 @@ static int compat_query_flows(struct datapath *dp, struct compat_odp_flow *flows if (!flow_node) error = put_user(ENOENT, &ufp->stats.error); else - error = compat_answer_query(flow_cast(flow_node), uf.flags, ufp); + error = compat_answer_query(flow_cast(flow_node), uf.flags, time_offset, ufp); if (error) return -EFAULT; } @@ -1878,6 +1963,7 @@ struct compat_list_flows_cbdata { struct compat_odp_flow __user *uflows; u32 n_flows; u32 listed_flows; + struct timespec time_offset; }; static int compat_list_flow(struct tbl_node *node, void *cbdata_) @@ -1889,7 +1975,7 @@ static int compat_list_flow(struct tbl_node *node, void *cbdata_) if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key)) return -EFAULT; - error = compat_answer_query(flow, 0, ufp); + error = compat_answer_query(flow, 0, cbdata->time_offset, ufp); if (error) return error; @@ -1909,6 +1995,8 @@ static int compat_list_flows(struct datapath *dp, struct compat_odp_flow *flows, cbdata.uflows = flows; cbdata.n_flows = n_flows; cbdata.listed_flows = 0; + cbdata.time_offset = get_time_offset(); + error = tbl_foreach(rcu_dereference(dp->table), compat_list_flow, &cbdata); return error ? error : cbdata.listed_flows; } @@ -2193,21 +2281,16 @@ success: if (skb->ip_summed == CHECKSUM_PARTIAL) { if (copy_bytes == skb->len) { __wsum csum = 0; - int csum_start, csum_offset; + unsigned int csum_start, csum_offset; #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,22) - /* Until 2.6.22, the start of the transport header was - * also the start of data to be checksummed. Linux - * 2.6.22 introduced the csum_start field for this - * purpose, but we should point the transport header to - * it anyway for backward compatibility, as - * dev_queue_xmit() does even in 2.6.28. */ - skb_set_transport_header(skb, skb->csum_start - skb_headroom(skb)); + csum_start = skb->csum_start - skb_headroom(skb); csum_offset = skb->csum_offset; #else + csum_start = skb_transport_header(skb) - skb->data; csum_offset = skb->csum; #endif - csum_start = skb_transport_header(skb) - skb->data; + BUG_ON(csum_start >= skb_headlen(skb)); retval = skb_copy_and_csum_datagram(skb, csum_start, buf + csum_start, copy_bytes - csum_start, &csum); if (!retval) { @@ -2215,6 +2298,8 @@ success: copy_bytes = csum_start; csump = (__sum16 __user *)(buf + csum_start + csum_offset); + + BUG_ON((char *)csump + sizeof(__sum16) > buf + nbytes); put_user(csum_fold(csum), csump); } } else