X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=CodingStyle;h=f4765ad8dc36e4e926830619c704f4c4a7897652;hb=0f07ce33c49ce522d69c0e6aab8ca7ce0757e98c;hp=126b45a89b7cb9ccc021043a44718e36c672fcec;hpb=064af42167bf4fc9aaea2702d80ce08074b889c0;p=openvswitch diff --git a/CodingStyle b/CodingStyle index 126b45a8..f4765ad8 100644 --- a/CodingStyle +++ b/CodingStyle @@ -168,7 +168,7 @@ prototype: Omit parameter names from function prototypes when the names do not give useful information, e.g.: - int netdev_get_mtu(const struct netdev *); + int netdev_get_mtu(const struct netdev *, int *mtup); STATEMENTS @@ -430,7 +430,9 @@ and precedence makes it necessary, or unless the operands are themselves expressions that use && and ||. Thus: - if (!isdigit(s[0]) || !isdigit(s[1]) || !isdigit(s[2])) { + if (!isdigit((unsigned char)s[0]) + || !isdigit((unsigned char)s[1]) + || !isdigit((unsigned char)s[2])) { printf("string %s does not start with 3-digit code\n", s); }