X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=ta-advice%2Fhw2.txt;h=f2764a94e9af89de1f405f180d91f0e51d985a70;hb=84be0fa6a2efde38ca3e8e97ec17b53f0a16b399;hp=f5aab65e759ab847e3b05935b7b870db952d96a4;hpb=e9f27d6bb8c80370aa3b249c090b012f3f24449e;p=pintos-anon diff --git a/ta-advice/hw2.txt b/ta-advice/hw2.txt index f5aab65..f2764a9 100644 --- a/ta-advice/hw2.txt +++ b/ta-advice/hw2.txt @@ -101,5 +101,8 @@ PROBLEM 2: SYSTEM CALLS -5 Added big array (>= 512 bytes) to struct thread without justifying -10 Added big array (>= 1024 bytes) to struct thread -5 Superfluous locking on per-thread data structure [which] + -10 System call handler is poorly abstracted or unreadable + -5 Failed to update comment on process_wait() function after implementing + -5 "open" system call fails to release all resources in error cases Subtotal: /60 (capped at 0)