X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=src%2Fmath%2Fcovariance.c;h=bc5382c0c12752e899c5b7b6570f16acf7ae4c11;hb=478954c1ed028744ab870f0e6a5befcc8f643758;hp=1a39335108693dd2754ded021c08082cbc6c524a;hpb=13a15a585b06cb5be411fdc48dba946079d5a437;p=pspp

diff --git a/src/math/covariance.c b/src/math/covariance.c
index 1a39335108..bc5382c0c1 100644
--- a/src/math/covariance.c
+++ b/src/math/covariance.c
@@ -160,8 +160,8 @@ covariance_1pass_create (size_t n_vars, const struct variable *const *vars,
 
   cov->n_cm = (n_vars * (n_vars - 1)  ) / 2;
 
-  if (cov->n_cm > 0)
-    cov->cm = xcalloc (sizeof *cov->cm, cov->n_cm);
+
+  cov->cm = xcalloc (cov->n_cm, sizeof *cov->cm);
   cov->categoricals = NULL;
 
   return cov;
@@ -268,7 +268,7 @@ get_val (const struct covariance *cov, int i, const struct ccase *c)
       return val->f;
     }
 
-  return categoricals_get_binary_by_subscript (cov->categoricals, i - cov->n_vars, c);
+  return categoricals_get_code_for_case (cov->categoricals, i - cov->n_vars, c);
 }
 
 #if 0
@@ -347,14 +347,16 @@ covariance_accumulate_pass2 (struct covariance *cov, const struct ccase *c)
       assert (cov->state == 1);
       cov->state = 2;
 
+      if (cov->categoricals)
+      	categoricals_done (cov->categoricals);
+
       cov->dim = cov->n_vars;
       
       if (cov->categoricals)
-	cov->dim += categoricals_total (cov->categoricals) 
-	  - categoricals_get_n_variables (cov->categoricals);
+	cov->dim += categoricals_df_total (cov->categoricals);
 
       cov->n_cm = (cov->dim * (cov->dim - 1)  ) / 2;
-      cov->cm = xcalloc (sizeof *cov->cm, cov->n_cm);
+      cov->cm = xcalloc (cov->n_cm, sizeof *cov->cm);
 
       /* Grow the moment matrices so that they're large enough to accommodate the
 	 categorical elements */
@@ -363,9 +365,6 @@ covariance_accumulate_pass2 (struct covariance *cov, const struct ccase *c)
 	  cov->moments[i] = resize_matrix (cov->moments[i], cov->dim);
 	}
 
-      if (cov->categoricals)
-	categoricals_done (cov->categoricals);
-
       /* Populate the moments matrices with the categorical value elements */
       for (i = cov->n_vars; i < cov->dim; ++i)
 	{
@@ -632,22 +631,6 @@ covariance_calculate (struct covariance *cov)
 static gsl_matrix *
 covariance_calculate_double_pass_unnormalized (struct covariance *cov)
 {
-  size_t i, j;
-  for (i = 0 ; i < cov->dim; ++i)
-    {
-      for (j = 0 ; j < cov->dim; ++j)
-	{
-	  int idx;
-	  double *x = gsl_matrix_ptr (cov->moments[MOMENT_VARIANCE], i, j);
-
-	  idx = cm_idx (cov, i, j);
-	  if ( idx >= 0)
-	    {
-	      x = &cov->cm [idx];
-	    }
-	}
-    }
-
   return  cm_to_gsl (cov);
 }
 
@@ -739,4 +722,89 @@ covariance_dim (const struct covariance * cov)
   return (cov->dim);
 }
 
+
+
+/*
+  Routines to assist debugging.
+  The following are not thoroughly tested and in certain respects
+  unreliable.  They should only be
+  used for aids to development. Not as user accessible code.
+*/
+
+#include "libpspp/str.h"
+#include "output/tab.h"
+#include "data/format.h"
+
+
+/* Create a table which can be populated with the encodings for
+   the covariance matrix COV */
+struct tab_table *
+covariance_dump_enc_header (const struct covariance *cov, int length)
+{
+  struct tab_table *t = tab_create (cov->dim,  length);
+  int n;
+  int i;
+
+  tab_title (t, "Covariance Encoding");
+
+  tab_box (t, 
+	   TAL_2, TAL_2, 0, 0,
+	   0, 0,   tab_nc (t) - 1,   tab_nr (t) - 1);
+
+  tab_hline (t, TAL_2, 0, tab_nc (t) - 1, 1);
+
+
+  for (i = 0 ; i < cov->n_vars; ++i)
+    {
+      tab_text (t, i, 0, TAT_TITLE, var_get_name (cov->vars[i]));
+      tab_vline (t, TAL_1, i + 1, 0, tab_nr (t) - 1);
+    }
+
+  n = 0;
+  while (i < cov->dim)
+    {
+      struct string str;
+      int idx = i - cov->n_vars;
+      const struct interaction *iact =
+	categoricals_get_interaction_by_subscript (cov->categoricals, idx);
+      int df;
+
+      ds_init_empty (&str);
+      interaction_to_string (iact, &str);
+
+      df = categoricals_df (cov->categoricals, n);
+
+      tab_joint_text (t,
+		      i, 0,
+		      i + df - 1, 0,
+		      TAT_TITLE, ds_cstr (&str));
+
+      if (i + df < tab_nr (t) - 1)
+	tab_vline (t, TAL_1, i + df, 0, tab_nr (t) - 1);
+
+      i += df;
+      n++;
+      ds_destroy (&str);
+    }
+
+  return t;
+}
+
 
+/*
+  Append table T, which should have been returned by covariance_dump_enc_header
+  with an entry corresponding to case C for the covariance matrix COV
+ */
+void
+covariance_dump_enc (const struct covariance *cov, const struct ccase *c,
+		     struct tab_table *t)
+{
+  static int row = 0;
+  int i;
+  ++row;
+  for (i = 0 ; i < cov->dim; ++i)
+    {
+      double v = get_val (cov, i, c);
+      tab_double (t, i, row, 0, v, i < cov->n_vars ? NULL : &F_8_0);
+    }
+}