X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=src%2Fdata%2Fcasereader-filter.c;h=d387f5ea03181794e790ea297a3b10cdc8337880;hb=9e0e4996fad6563f0a1ce628b80db5c23ef8279e;hp=5c46ed50dba436d1584a320e134be8fefc5e5de0;hpb=b65cf0519aa1db140d30c878978f29b1e23c9cd0;p=pspp-builds.git diff --git a/src/data/casereader-filter.c b/src/data/casereader-filter.c index 5c46ed50..d387f5ea 100644 --- a/src/data/casereader-filter.c +++ b/src/data/casereader-filter.c @@ -1,5 +1,5 @@ /* PSPP - a program for statistical analysis. - Copyright (C) 2007 Free Software Foundation, Inc. + Copyright (C) 2007, 2009 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -86,22 +86,22 @@ casereader_create_filter_func (struct casereader *subreader, } /* Internal read function for filtering casereader. */ -static bool -casereader_filter_read (struct casereader *reader UNUSED, void *filter_, - struct ccase *c) +static struct ccase * +casereader_filter_read (struct casereader *reader UNUSED, void *filter_) { struct casereader_filter *filter = filter_; for (;;) { - if (!casereader_read (filter->subreader, c)) - return false; + struct ccase *c = casereader_read (filter->subreader); + if (c == NULL) + return NULL; else if (filter->include (c, filter->aux)) - return true; + return c; else if (filter->exclude != NULL) casewriter_write (filter->exclude, c); else - case_destroy (c); + case_unref (c); } } @@ -115,12 +115,12 @@ casereader_filter_destroy (struct casereader *reader, void *filter_) casewriter, if there is one. */ if (filter->exclude != NULL) { - struct ccase c; - while (casereader_read (filter->subreader, &c)) - if (filter->include (&c, filter->aux)) - case_destroy (&c); + struct ccase *c; + while ((c = casereader_read (filter->subreader)) != NULL) + if (filter->include (c, filter->aux)) + case_unref (c); else - casewriter_write (filter->exclude, &c); + casewriter_write (filter->exclude, c); } casereader_destroy (filter->subreader); @@ -266,7 +266,7 @@ static bool casereader_filter_missing_destroy (void *); is destroyed. If N_MISSING is non-null, then after reading, it will be filled - with the total number of dropped cases. + with the totla number of dropped cases. After this function is called, READER must not ever again be referenced directly. It will be destroyed automatically @@ -285,8 +285,7 @@ casereader_create_filter_missing (struct casereader *reader, cfm->var_cnt = var_cnt; cfm->class = class; cfm->n_missing = n_missing; - if (n_missing) - *n_missing = 0; + if (n_missing) *n_missing = 0; return casereader_create_filter_func (reader, casereader_filter_missing_include, casereader_filter_missing_destroy,