X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=grading%2Fuserprog%2Ftests.txt;h=afeed079fde0d8dcf1cc8791ff234be72e89f1b2;hb=2e2f580dd9eb1a8fa094e35f4b967e2547774d9c;hp=1ba870e96eb1daa71d2ac4055a421dd756dc9805;hpb=064e19becdc8969ddb605223b340606706a33f86;p=pintos-anon

diff --git a/grading/userprog/tests.txt b/grading/userprog/tests.txt
index 1ba870e..afeed07 100644
--- a/grading/userprog/tests.txt
+++ b/grading/userprog/tests.txt
@@ -4,14 +4,16 @@ CORRECTNESS [[total]]
 Argument passing
   -3 args-argc: argc is not set correctly
   -3 args-argv0: executable name not passed as argv[0]
+  -3 args-argvn: argv[argc] is not a null pointer
+  -3 args-single: passing single argument fails
   -3 args-multiple: passing multiple arguments fails
-  -3 args-dblspace: using multiple spaces between arguments fails
-Score: /12
+  -3 args-dbl-space: using multiple spaces between arguments fails
+Score: /18
 
 System calls
-  -3 syscall-bad-sp: system call with a bad stack pointer must not crash OS
-  -3 syscall-bad-arg: syscall with argument off top of stack must not crash OS
-  -3 syscall-boundary: syscall with args across page boundary must work
+  -3 sc-bad-sp: system call with a bad stack pointer must not crash OS
+  -3 sc-bad-arg: syscall with argument off top of stack must not crash OS
+  -3 sc-boundary: syscall with args across page boundary must work
 Score: /9
 
 System calls: halt, exec 
@@ -26,8 +28,8 @@ System calls: create
   -1 create-bad-ptr: pass invalid pointer to create system call
   -1 create-long: pass long file name to create system call
   -1 create-exists: pass name of an existing file to create system call
-  -1 create-boundary: pass name of file crossing page boundary
-Score: /7
+  -1 create-bound: pass name of file crossing page boundary
+Score: /8
 
 System calls: open
   -2 open-normal: open a file in the most normal way
@@ -35,8 +37,9 @@ System calls: open
   -2 open-boundary: pass name of file crossing page boundary
   -1 open-empty: pass empty string to open system call
   -1 open-null: pass null pointer to open system call
+  -1 open-bad-ptr: pass invalid pointer to open system call
   -1 open-twice: open the same file twice
-Score: /7
+Score: /10
 
 System calls: close
   -2 close-normal: close an open file in the most normal way
@@ -53,7 +56,7 @@ System calls: read
   -1 read-zero: try to read zero bytes
   -1 read-stdout: try to read from stdout
   -1 read-bad-fd: try to read from invalid file descriptor
-Score: /7
+Score: /9
 
 System calls: write
   -2 write-normal: write to open file in most normal way
@@ -62,14 +65,15 @@ System calls: write
   -1 write-zero: try to write zero bytes
   -1 write-stdin: try to write to stdin
   -1 write-bad-fd: try to write to invalid file descriptor
-Score: /7
+Score: /9
 
 System calls: exec
   -2 exec-once: call exec/join once
+  -2 exec-arg: check command-line passing on exec
   -2 exec-multiple: call exec/join multiple times
   -2 exec-missing: exec of nonexistent file must return -1
   -1 exec-bad-ptr: pass invalid pointer to exec system call
-Score: /7
+Score: /9
 
 System calls: join
   -2 join-simple: join must return proper value