X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;ds=sidebyside;f=CodingStyle;h=2ee189faf0f4bfe4b2734aeebce182392ef41943;hb=a23aab1fc2f66b63ba9b7e4b9c9a8f6d58c367d0;hp=f4765ad8dc36e4e926830619c704f4c4a7897652;hpb=be2c418b73fcb6c606725d84c18b0ad618082c75;p=openvswitch diff --git a/CodingStyle b/CodingStyle index f4765ad8..2ee189fa 100644 --- a/CodingStyle +++ b/CodingStyle @@ -156,6 +156,12 @@ parameters and their corresponding size parameters should be paired. ... } +Functions that destroy an instance of a dynamically-allocated type +should accept and ignore a null pointer argument. Code that calls +such a function (including the C standard library function free()) +should omit a null-pointer check. We find that this usually makes +code easier to read. + FUNCTION PROTOTYPES @@ -412,13 +418,8 @@ Exception 1: Put a space after (but not before) the "sizeof" keyword. Exception 2: Put a space between the () used in a cast and the expression whose type is cast: (void *) 0. - Break long lines before binary operators and the ternary operators ? -and :, rather than after them, e.g. - - if (first_long_condition() || second_long_condition() - || third_long_condition()) - -and + Break long lines before the ternary operators ? and :, rather than +after them, e.g. return (out_port != VIGP_CONTROL_PATH ? alpheus_output_port(dp, skb, out_port)