secchan: Improve logging when rejecting a controller vconn.

[openvswitch] / secchan / secchan.c

diff --git a/secchan/secchan.c b/secchan/secchan.c
index 5577a27afb582f665f6e14bcaf8ef88684c0897e..0f8ac9870b4ce5c506f2c7287ff086e8618e4969 100644 (file)
--- a/secchan/secchan.c
+++ b/secchan/secchan.c
@@ -297,6 +297,7 @@ main(int argc, char *argv[])
             }
             dhclient_run(dhcp);
             if (dhclient_changed(dhcp)) {
+                dhclient_configure_netdev(dhcp);
                 free(controller_name);
                 if (dhclient_is_bound(dhcp)) {
                     controller_name = dhcp_msg_get_string(
@@ -665,6 +666,10 @@ validate_dhcp_offer(const struct dhcp_msg *msg, void *aux)
         return false;
     }
     accept = !regexec(&accept_controller_regex, vconn_name, 0, NULL, 0);
+    if (!accept) {
+        VLOG_WARN("rejecting controller vconn that fails to match %s",
+                  accept_controller_re);
+    }
     free(vconn_name);
     return accept;
 }
@@ -754,7 +759,7 @@ parse_options(int argc, char *argv[])
             break;
 
         case 'P':
-            set_pidfile(optarg ? optarg : "secchan.pid");
+            set_pidfile(optarg);
             break;
 
         case 'l':