Cleanup isdigit() warnings.

[openvswitch] / lib / dpif-linux.c

diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 0973b5d9516b3a9f0e11e35b9363c647f1a5d1dc..a1a666bddaa64aced1945007d2d390f08842db2c 100644 (file)
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -31,9 +31,9 @@
 #include <unistd.h>
 
 #include "dpif-provider.h"
-#include "netdev-linux.h"
 #include "ofpbuf.h"
 #include "poll-loop.h"
+#include "rtnetlink.h"
 #include "svec.h"
 #include "util.h"
 
@@ -52,7 +52,8 @@ struct dpif_linux {
     /* Change notification. */
     int local_ifindex;          /* Ifindex of local port. */
     struct svec changed_ports;  /* Ports that have changed. */
-    struct linux_netdev_notifier port_notifier;
+    struct rtnetlink_notifier port_notifier;
+    bool change_error;
 };
 
 static struct vlog_rate_limit error_rl = VLOG_RATE_LIMIT_INIT(9999, 5);
@@ -63,7 +64,7 @@ static int finish_open(struct dpif *, const char *local_ifname);
 static int create_minor(const char *name, int minor, struct dpif **dpifp);
 static int open_minor(int minor, struct dpif **dpifp);
 static int make_openvswitch_device(int minor, char **fnp);
-static void dpif_linux_port_changed(const struct linux_netdev_change *,
+static void dpif_linux_port_changed(const struct rtnetlink_change *,
                                     void *dpif);
 
 static struct dpif_linux *
@@ -73,18 +74,6 @@ dpif_linux_cast(const struct dpif *dpif)
     return CONTAINER_OF(dpif, struct dpif_linux, dpif);
 }
 
-static void
-dpif_linux_run(void)
-{
-    linux_netdev_notifier_run();
-}
-
-static void
-dpif_linux_wait(void)
-{
-    linux_netdev_notifier_wait();
-}
-
 static int
 dpif_linux_enumerate(struct svec *all_dps)
 {
@@ -115,7 +104,8 @@ dpif_linux_open(const char *name UNUSED, char *suffix, bool create,
 {
     int minor;
 
-    minor = !strncmp(name, "dp", 2) && isdigit(name[2]) ? atoi(name + 2) : -1;
+    minor = !strncmp(name, "dp", 2)
+            && isdigit((unsigned char)name[2]) ? atoi(name + 2) : -1;
     if (create) {
         if (minor >= 0) {
             return create_minor(suffix, minor, dpifp);
@@ -172,7 +162,7 @@ static void
 dpif_linux_close(struct dpif *dpif_)
 {
     struct dpif_linux *dpif = dpif_linux_cast(dpif_);
-    linux_netdev_notifier_unregister(&dpif->port_notifier);
+    rtnetlink_notifier_unregister(&dpif->port_notifier);
     svec_destroy(&dpif->changed_ports);
     free(dpif->local_ifname);
     close(dpif->fd);
@@ -285,29 +275,27 @@ static int
 dpif_linux_port_poll(const struct dpif *dpif_, char **devnamep)
 {
     struct dpif_linux *dpif = dpif_linux_cast(dpif_);
-    int error;
 
-    error = linux_netdev_notifier_get_error(&dpif->port_notifier);
-    if (!error) {
-        if (!dpif->changed_ports.n) {
-            return EAGAIN;
-        }
+    if (dpif->change_error) {
+        dpif->change_error = false;
+        svec_clear(&dpif->changed_ports);
+        return ENOBUFS;
+    } else if (dpif->changed_ports.n) {
         *devnamep = dpif->changed_ports.names[--dpif->changed_ports.n];
+        return 0;
     } else {
-        svec_clear(&dpif->changed_ports);
+        return EAGAIN;
     }
-    return error;
 }
 
 static void
 dpif_linux_port_poll_wait(const struct dpif *dpif_)
 {
     struct dpif_linux *dpif = dpif_linux_cast(dpif_);
-    if (dpif->changed_ports.n
-        || linux_netdev_notifier_peek_error(&dpif->port_notifier)) {
+    if (dpif->changed_ports.n || dpif->change_error) {
         poll_immediate_wake();
     } else {
-        linux_netdev_notifier_wait();
+        rtnetlink_notifier_wait();
     }
 }
 
@@ -452,8 +440,8 @@ dpif_linux_recv_wait(struct dpif *dpif_)
 const struct dpif_class dpif_linux_class = {
     "",                         /* This is the default class. */
     "linux",
-    dpif_linux_run,
-    dpif_linux_wait,
+    NULL,
+    NULL,
     dpif_linux_enumerate,
     dpif_linux_open,
     dpif_linux_close,
@@ -711,8 +699,8 @@ open_minor(int minor, struct dpif **dpifp)
     fd = open(fn, O_RDONLY | O_NONBLOCK);
     if (fd >= 0) {
         struct dpif_linux *dpif = xmalloc(sizeof *dpif);
-        error = linux_netdev_notifier_register(&dpif->port_notifier,
-                                               dpif_linux_port_changed, dpif);
+        error = rtnetlink_notifier_register(&dpif->port_notifier,
+                                           dpif_linux_port_changed, dpif);
         if (!error) {
             char *name;
 
@@ -725,6 +713,7 @@ open_minor(int minor, struct dpif **dpifp)
             dpif->minor = minor;
             dpif->local_ifindex = 0;
             svec_init(&dpif->changed_ports);
+            dpif->change_error = false;
             *dpifp = &dpif->dpif;
         } else {
             free(dpif);
@@ -739,19 +728,23 @@ open_minor(int minor, struct dpif **dpifp)
 }
 
 static void
-dpif_linux_port_changed(const struct linux_netdev_change *change, void *dpif_)
+dpif_linux_port_changed(const struct rtnetlink_change *change, void *dpif_)
 {
     struct dpif_linux *dpif = dpif_;
 
-    if (change->master_ifindex == dpif->local_ifindex
-        && (change->nlmsg_type == RTM_NEWLINK
-            || change->nlmsg_type == RTM_DELLINK))
-    {
-        /* Our datapath changed, either adding a new port or deleting an
-         * existing one. */
-        if (!svec_contains(&dpif->changed_ports, change->ifname)) {
-            svec_add(&dpif->changed_ports, change->ifname);
-            svec_sort(&dpif->changed_ports);
+    if (change) {
+        if (change->master_ifindex == dpif->local_ifindex
+            && (change->nlmsg_type == RTM_NEWLINK
+                || change->nlmsg_type == RTM_DELLINK))
+        {
+            /* Our datapath changed, either adding a new port or deleting an
+             * existing one. */
+            if (!svec_contains(&dpif->changed_ports, change->ifname)) {
+                svec_add(&dpif->changed_ports, change->ifname);
+                svec_sort(&dpif->changed_ports);
+            }
         }
+    } else {
+        dpif->change_error = true;
     }
 }